Hi Felix, good spot. I just fixed it ...
Thanks, Norman 2011/3/22 Felix Knecht <[email protected]> > Hi > > In StartTlsCmdHandler.onCommand [1] the response at lines 64 and 86 looks > like dead store. Either lines 64/86 should return the value instead storing > into 'response' or line 88 (end of method) should look like 'return > response;' instead of 'return null;'. Not sure if when 'return response' we > will have a double response because of line 71 > 'session.writeResponse(response);' in some cases. > > Regards > Felix > > > [1] > https://builds.apache.org/hudson/view/G-L/view/James/job/protocols-trunk-site/site/xref/org/apache/james/protocols/smtp/core/esmtp/StartTlsCmdHandler.html#58 > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
