Author: rdonkin
Date: Tue Apr 26 11:16:16 2011
New Revision: 1096728

URL: http://svn.apache.org/viewvc?rev=1096728&view=rev
Log:
JAMES-1228 Tidied up code by removing unused methods and variables, and by 
annotating suppressions.

Modified:
    
james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/BayesianAnalysis.java
    
james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/BayesianAnalysisFeeder.java
    
james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/BayesianAnalyzer.java
    
james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/JDBCBayesianAnalyzer.java

Modified: 
james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/BayesianAnalysis.java
URL: 
http://svn.apache.org/viewvc/james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/BayesianAnalysis.java?rev=1096728&r1=1096727&r2=1096728&view=diff
==============================================================================
--- 
james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/BayesianAnalysis.java
 (original)
+++ 
james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/BayesianAnalysis.java
 Tue Apr 26 11:16:16 2011
@@ -327,7 +327,9 @@ public class BayesianAnalysis extends Ge
                 senderString = mail.getSender().toString();
             }
             if (probability > 0.1) {
-                log(headerName + ": " + probabilityString + "; From: " + 
senderString + "; Recipient(s): " + getAddressesString(mail.getRecipients()));
+                @SuppressWarnings("unchecked")
+                final Collection<MailAddress> recipients = 
mail.getRecipients();
+                log(headerName + ": " + probabilityString + "; From: " + 
senderString + "; Recipient(s): " + getAddressesString(recipients));
 
                 // Check if we should tag the subject
                 if (tagSubject) {

Modified: 
james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/BayesianAnalysisFeeder.java
URL: 
http://svn.apache.org/viewvc/james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/BayesianAnalysisFeeder.java?rev=1096728&r1=1096727&r2=1096728&view=diff
==============================================================================
--- 
james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/BayesianAnalysisFeeder.java
 (original)
+++ 
james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/BayesianAnalysisFeeder.java
 Tue Apr 26 11:16:16 2011
@@ -328,6 +328,7 @@ public class BayesianAnalysisFeeder exte
     }
 
     private void clearAllHeaders(MimeMessage message) throws 
javax.mail.MessagingException {
+        @SuppressWarnings("rawtypes")
         Enumeration headers = message.getAllHeaders();
 
         while (headers.hasMoreElements()) {

Modified: 
james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/BayesianAnalyzer.java
URL: 
http://svn.apache.org/viewvc/james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/BayesianAnalyzer.java?rev=1096728&r1=1096727&r2=1096728&view=diff
==============================================================================
--- 
james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/BayesianAnalyzer.java
 (original)
+++ 
james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/BayesianAnalyzer.java
 Tue Apr 26 11:16:16 2011
@@ -708,21 +708,6 @@ public class BayesianAnalyzer {
         return (p / (p + np));
     }
 
-    private boolean allSameChar(String s) {
-        if (s.length() < 2) {
-            return false;
-        }
-
-        char c = s.charAt(0);
-
-        for (int i = 1; i < s.length(); i++) {
-            if (s.charAt(i) != c) {
-                return false;
-            }
-        }
-        return true;
-    }
-
     private boolean allDigits(String s) {
         for (int i = 0; i < s.length(); i++) {
             if (!Character.isDigit(s.charAt(i))) {

Modified: 
james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/JDBCBayesianAnalyzer.java
URL: 
http://svn.apache.org/viewvc/james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/JDBCBayesianAnalyzer.java?rev=1096728&r1=1096727&r2=1096728&view=diff
==============================================================================
--- 
james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/JDBCBayesianAnalyzer.java
 (original)
+++ 
james/mailet/ai/trunk/classic/src/main/java/org/apache/james/ai/classic/JDBCBayesianAnalyzer.java
 Tue Apr 26 11:16:16 2011
@@ -372,7 +372,7 @@ abstract public class JDBCBayesianAnalyz
     }
 
     private void checkTables(Connection conn) throws SQLException {
-        DatabaseMetaData dbMetaData = conn.getMetaData();
+        // DatabaseMetaData dbMetaData = conn.getMetaData();
         // Need to ask in the case that identifiers are stored, ask the
         // DatabaseMetaInfo.
         // Try UPPER, lower, and MixedCase, to see if the table is there.



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to