Hi Norman,
Thx for the confirmation.
I've reactivated the test in trunk, but it break the maildir test.
Maildir is special because 'INBOX' is a folder (with its cur/ new/ tmp/)
and any other folders (.INBOX.SUB1, .Archives,...) reside within that
'INBOX' folder. So if we leave MaildirMailboxMapper.delete as now, and
invoke it with mailbox=INBOX, it will simply remove all the folders, and
this is not what we want.
Other mailbox implementations don't have that.
So we could test beforehand for any subfolders others that cur/, new/,
tmp/ and throwing a MailboxException if we find some ('You must delete
all INBOX subfolders to delete INBOX on Maildir implementation').
If this sounds good, I will implement it.
Thx.
On 17/07/11 11:17, Norman Maurer wrote:
If you delete a Mailbox with sub Mailboxen, its necessary that the
submailboxes don't get deleted.
Bye
Norman
Am Samstag, 16. Juli 2011 schrieb Eric Charles<[email protected]>:
The question is "what do we do when we delete a mailbox with sub mailboxes ?"
For now, we allow this (I didn't check in RFC if this is allowed).
With the merge of mailboxmanager tests, it succeeds with jpa/jcr, but fails
with maildir (logical!).
Any hint?
On 16/07/11 09:37, [email protected] wrote:
Author: eric
Date: Sat Jul 16 07:37:48 2011
New Revision: 1147372
URL: http://svn.apache.org/viewvc?rev=1147372&view=rev
Log:
Temporary comment to avoid maildir test failure (MAILBOX-73)
Modified:
james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/AbstractMailboxManagerTest.java
Modified:
james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/AbstractMailboxManagerTest.java
URL:
http://svn.apache.org/viewvc/james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/AbstractMailboxManagerTest.java?rev=1147372&r1=1147371&r2=1147372&view=diff
==============================================================================
---
james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/AbstractMailboxManagerTest.java
(original)
+++
james/mailbox/trunk/api/src/test/java/org/apache/james/mailbox/AbstractMailboxManagerTest.java
Sat Jul 16 07:37:48 2011
@@ -76,10 +76,13 @@ public abstract class AbstractMailboxMan
getMailboxManager().deleteMailbox(inbox, session);
Assert.assertFalse(getMailboxManager().mailboxExists(inbox,
session));
- Assert.assertTrue(getMailboxManager().mailboxExists(inboxSubMailbox,
session));
- getMailboxManager().deleteMailbox(inboxSubMailbox, session);
- Assert.assertFalse(getMailboxManager().mailboxExists(inboxSubMailbox,
session));
+ // TODO Temporary commented to avoid maildir test failure
+
+// Assert.assertTrue(getMailboxManager().mailboxExists(inboxSubMailbox,
session));
+
+// getMailboxManager().deleteMailbox(inboxSubMailbox, session);
+//
Assert.assertFalse(getMailboxManager().mailboxExists(inboxSubMailbox, session));
getMailboxManager().logout(session, false);
getMailboxManager().endProcessingRequest(session);
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
--
Eric Charles
http://about.echarles.net
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
--
Eric Charles
http://about.echarles.net
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
