2011/8/16 Norman Maurer <[email protected]>: > Am 16.08.2011 11:25, schrieb Ioan Eugen Stan: >> >> 2011/8/16 Eric Charles<[email protected]>: >>> >>> Hi Ioan, >>> >>> I've run a few tests but didn't see the ClassCastException. >> >> Thats because last night some gremlins worked on the code and >> committed the fixes for that ;). >> >>> e.g. Running from eclipse: >>> >>> NonAuthenticatedStateTest : 100% OK >>> >>> SelectTest : >>> >>> org.apache.james.imap.tester.base.ProtocolSession$InvalidServerResponseException: >>> Location: /org/apache/james/imap/scripts/SelectUnseen.test:24 >>> LastClientMsg: 10 SELECT selectappend >>> Expected: '\* FLAGS \(\\Answered \\Deleted \\Draft \\Flagged \\Seen\)' >>> Actual : '10 NO SELECT completed.' >>> >>> I don't think there is a dependency/class incompatibility. >>> It's more on the scripts results. >>> >>> I would track them one by one, trying to understand what the scripts are >>> doing (in src/main/resources/org/apache/james/imap/script) and >>> correcting. A >>> fix in your code could solve many integration tests... >> >> I hope so. I'm planning to write some unit tests for message mapper to >> see if I get fails on methods. It seems that one method fails, because >> I get many errors with EXISTS. E.g. expected \* 2 EXISTS, actual \* 0 >> EXISTS. > > A NO or BAD response usual means that there was an exception thrown from the > mailbox code. To get an better idea what happens you should use this patch > on the integration tests: > > diff -r 3c892cf9a2c0 pom.xml > --- a/pom.xml Tue Aug 16 03:06:46 2011 +0300 > +++ b/pom.xml Tue Aug 16 11:40:17 2011 +0200 > @@ -198,7 +198,7 @@ > </dependency> > <dependency> > <groupId>org.slf4j</groupId> > - <artifactId>slf4j-simple</artifactId> > + <artifactId>slf4j-log4j12</artifactId> > <version>1.6.1</version> > </dependency> > <dependency> > diff -r 3c892cf9a2c0 src/main/resources/log4j.properties > --- a/src/main/resources/log4j.properties Tue Aug 16 03:06:46 2011 +0300 > +++ b/src/main/resources/log4j.properties Tue Aug 16 11:40:17 2011 +0200 > @@ -17,11 +17,9 @@ > # under the License. # > ################################################################ > > -log4j.rootLogger=ERROR, A1 > +log4j.rootLogger=DEBUG, A1 > log4j.appender.A1=org.apache.log4j.ConsoleAppender > log4j.appender.A1.layout=org.apache.log4j.PatternLayout > > # Print the date in ISO 8601 format > log4j.appender.A1.layout.ConversionPattern=%d [%t] %-5p %c - %m%n > - > -org.apache.james.imap=DEBUG,CONS > \ No newline at end of file
Thanks for the patch Norman. I re-ran the test suite after integrating the fixes and suggestions you provided and now we stand at: Tests run: 291, Failures: 0, Errors: 171, Skipped: 0. This is a great improvement. I will test again with the debugging options to see if I can get it to comply 100%. I have committed and pushed the changes so the repos are up to date. Thanks, -- Ioan Eugen Stan http://ieugen.blogspot.com/ --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
