Author: felixk
Date: Wed Sep 21 13:22:29 2011
New Revision: 1173620
URL: http://svn.apache.org/viewvc?rev=1173620&view=rev
Log:
Don't concatenate strings using + in a loop
Modified:
james/hupa/trunk/shared/src/main/java/org/apache/hupa/shared/data/AbstractMessage.java
Modified:
james/hupa/trunk/shared/src/main/java/org/apache/hupa/shared/data/AbstractMessage.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/shared/src/main/java/org/apache/hupa/shared/data/AbstractMessage.java?rev=1173620&r1=1173619&r2=1173620&view=diff
==============================================================================
---
james/hupa/trunk/shared/src/main/java/org/apache/hupa/shared/data/AbstractMessage.java
(original)
+++
james/hupa/trunk/shared/src/main/java/org/apache/hupa/shared/data/AbstractMessage.java
Wed Sep 21 13:22:29 2011
@@ -36,19 +36,19 @@ public class AbstractMessage implements
private boolean hasAttachment;
public String toString() {
- String toList = "";
+ StringBuffer toList = new StringBuffer("");
if (to != null)
for (String s: to)
- toList += s + " ";
+ toList.append(s).append(" ");
- String ccList = "";
+ StringBuffer ccList = new StringBuffer("");
if (cc != null)
for (String s: cc)
- ccList += s + " ";
+ ccList.append(s).append(" ");
return "From='" + from
- + "' To='" + toList
- + "' CC='" + ccList
+ + "' To='" + toList.toString()
+ + "' CC='" + ccList.toString()
+ "' ReplyTo='" + (replyto == null ? "": replyto)
+ "' Subject='" + subject
+ "' Attachments=" + hasAttachment;
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
