Author: felixk
Date: Wed Sep 21 15:50:56 2011
New Revision: 1173734
URL: http://svn.apache.org/viewvc?rev=1173734&view=rev
Log:
Use for-each loop (since Java 1.5)
Modified:
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListPresenter.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageView.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainPresenter.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainView.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenter.java
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/EmailListValidator.java
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/AbstractFetchMessagesHandler.java
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/DeleteMessageByUidHandler.java
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/FetchFoldersHandler.java
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/JavamailUtil.java
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/TagMessagesHandler.java
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/mock/MockIMAPFolder.java
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/mock/MockIMAPStore.java
james/hupa/trunk/widgets/src/main/java/org/apache/hupa/widgets/ui/RefetchPagingScrollTable.java
Modified:
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListPresenter.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListPresenter.java?rev=1173734&r1=1173733&r2=1173734&view=diff
==============================================================================
---
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListPresenter.java
(original)
+++
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListPresenter.java
Wed Sep 21 15:50:56 2011
@@ -248,8 +248,7 @@ public class IMAPMessageListPresenter ex
public void onClick(ClickEvent event) {
final ArrayList<Message> selectedMessages = new
ArrayList<Message>(display.getSelectedMessages());
ArrayList<Long> uids = new ArrayList<Long>();
- for (int i = 0; i < selectedMessages.size(); i++) {
- Message m = selectedMessages.get(i);
+ for (Message m : selectedMessages) {
if (m.getFlags().contains(IMAPFlag.SEEN) == false) {
uids.add(m.getUid());
} else {
@@ -258,8 +257,7 @@ public class IMAPMessageListPresenter ex
}
dispatcher.execute(new SetFlag(folder, IMAPFlag.SEEN, true,
uids), new HupaCallback<GenericResult>(dispatcher, eventBus) {
public void callback(GenericResult result) {
- for (int i = 0; i < selectedMessages.size(); i++) {
- Message m = selectedMessages.get(i);
+ for (Message m : selectedMessages) {
if (m.getFlags().contains(IMAPFlag.SEEN) == false)
{
m.getFlags().add(IMAPFlag.SEEN);
}
@@ -277,8 +275,7 @@ public class IMAPMessageListPresenter ex
public void onClick(ClickEvent event) {
final ArrayList<Message> selectedMessages = new
ArrayList<Message>(display.getSelectedMessages());
ArrayList<Long> uids = new ArrayList<Long>();
- for (int i = 0; i < selectedMessages.size(); i++) {
- Message m = selectedMessages.get(i);
+ for (Message m : selectedMessages) {
if (m.getFlags().contains(IMAPFlag.SEEN)) {
uids.add(m.getUid());
} else {
@@ -288,8 +285,7 @@ public class IMAPMessageListPresenter ex
dispatcher.execute(new SetFlag(folder, IMAPFlag.SEEN, false,
uids), new HupaCallback<GenericResult>(dispatcher, eventBus) {
public void callback(GenericResult result) {
- for (int i = 0; i < selectedMessages.size(); i++) {
- Message m = selectedMessages.get(i);
+ for (Message m : selectedMessages) {
if (m.getFlags().contains(IMAPFlag.SEEN)) {
m.getFlags().remove(IMAPFlag.SEEN);
}
@@ -359,8 +355,8 @@ public class IMAPMessageListPresenter ex
private void deleteMessages() {
final ArrayList<Message> selectedMessages = new
ArrayList<Message>(display.getSelectedMessages());
ArrayList<Long> uids = new ArrayList<Long>();
- for (int i = 0; i < selectedMessages.size(); i++) {
- uids.add(selectedMessages.get(i).getUid());
+ for (Message m : selectedMessages) {
+ uids.add(m.getUid());
}
// maybe its better to just remove the messages from the table and
expect the removal will work
display.removeMessages(selectedMessages);
Modified:
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java?rev=1173734&r1=1173733&r2=1173734&view=diff
==============================================================================
---
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java
(original)
+++
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java
Wed Sep 21 15:50:56 2011
@@ -777,9 +777,9 @@ public class IMAPMessageListView extends
* @see
org.apache.hupa.client.mvp.MainPresenter.Display#fillSearchOracle(java.util.ArrayList)
*/
public void fillSearchOracle(ArrayList<Message> messages) {
- for (int i = 0; i < messages.size(); i++) {
- String subject = messages.get(i).getSubject();
- String from = messages.get(i).getFrom();
+ for (Message m : messages) {
+ String subject = m.getSubject();
+ String from = m.getFrom();
if (subject != null && subject.trim().length() > 0) {
oracle.add(subject.trim());
}
Modified:
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageView.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageView.java?rev=1173734&r1=1173733&r2=1173734&view=diff
==============================================================================
---
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageView.java
(original)
+++
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageView.java
Wed Sep 21 15:50:56 2011
@@ -142,14 +142,13 @@ public class IMAPMessageView extends Com
attachments.clear();
final Element downloadIframe =
RootPanel.get("__download").getElement();
if (attachements != null) {
- for (int i = 0; i < attachements.size(); i++) {
- final MessageAttachment a = attachements.get(i);
- Label link = new Label(a.getName() + " (" + a.getSize() / 1024
+ "kB)");
+ for (final MessageAttachment messageAttachment : attachements) {
+ Label link = new Label(messageAttachment.getName() + " (" +
messageAttachment.getSize() / 1024 + "kB)");
link.setStyleName(HupaCSS.C_hyperlink);
link.addClickHandler(new ClickHandler() {
public void onClick(ClickEvent event) {
String url = GWT.getModuleBaseURL() +
SConsts.SERVLET_DOWNLOAD
- + "?" + SConsts.PARAM_NAME + "=" +
a.getName()
+ + "?" + SConsts.PARAM_NAME + "=" +
messageAttachment.getName()
+ "&" + SConsts.PARAM_FOLDER + "=" + folder
+ "&" + SConsts.PARAM_UID + "=" + uid;
if (downloadIframe == null)
Modified:
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainPresenter.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainPresenter.java?rev=1173734&r1=1173733&r2=1173734&view=diff
==============================================================================
---
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainPresenter.java
(original)
+++
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainPresenter.java
Wed Sep 21 15:50:56 2011
@@ -172,8 +172,7 @@ public class MainPresenter extends Widge
private ArrayList<IMAPTreeItem> createTreeNodes(ArrayList<IMAPFolder>
list) {
ArrayList<IMAPTreeItem> tList = new ArrayList<IMAPTreeItem>();
- for (int i = 0; i < list.size(); i++) {
- IMAPFolder iFolder = list.get(i);
+ for (IMAPFolder iFolder : list) {
final IMAPTreeItem record = new IMAPTreeItem(iFolder);
record.addEditHandler(new EditHandler() {
@@ -201,8 +200,8 @@ public class MainPresenter extends Widge
ArrayList<IMAPFolder> childFolders = iFolder.getChildIMAPFolders();
if (childFolders != null && childFolders.isEmpty() == false) {
ArrayList<IMAPTreeItem> items = createTreeNodes(childFolders);
- for (int a = 0; a < items.size(); a++) {
- record.addItem(items.get(a));
+ for (IMAPTreeItem item : items) {
+ record.addItem(item);
}
}
Modified:
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainView.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainView.java?rev=1173734&r1=1173733&r2=1173734&view=diff
==============================================================================
---
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainView.java
(original)
+++
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MainView.java
Wed Sep 21 15:50:56 2011
@@ -181,17 +181,16 @@ public class MainView extends Composite
*/
public void bindTreeItems(ArrayList<IMAPTreeItem> treeList) {
folderTree.clear();
- for (int i = 0; i < dropControllerList.size(); i++) {
- controller.unregisterDropController(dropControllerList.get(i));
+ for (DropController dropController : dropControllerList) {
+ controller.unregisterDropController(dropController);
}
- for (int i = 0; i < treeList.size(); i++) {
- IMAPTreeItem item = treeList.get(i);
- bindDropController(item);
- folderTree.addItem(item);
+ for (IMAPTreeItem iTreeItem : treeList) {
+ bindDropController(iTreeItem);
+ folderTree.addItem(iTreeItem);
- if (((IMAPFolder)
item.getUserObject()).getFullName().equalsIgnoreCase(user.getSettings().getInboxFolderName()))
{
- folderTree.setSelectedItem(item, false);
+ if (((IMAPFolder)
iTreeItem.getUserObject()).getFullName().equalsIgnoreCase(user.getSettings().getInboxFolderName()))
{
+ folderTree.setSelectedItem(iTreeItem, false);
}
}
Modified:
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenter.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenter.java?rev=1173734&r1=1173733&r2=1173734&view=diff
==============================================================================
---
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenter.java
(original)
+++
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/MessageSendPresenter.java
Wed Sep 21 15:50:56 2011
@@ -221,13 +221,10 @@ public class MessageSendPresenter extend
protected ArrayList<String> emailTextToArray(String emails) {
ArrayList<String> cc = new ArrayList<String>();
- String[] ccRaw = emails.split("[,;]+");
- if (ccRaw != null) {
- for (int i = 0; i < ccRaw.length; i++) {
- String ccRecip = ccRaw[i].trim();
- if (ccRecip.length() > 0) {
- cc.add(ccRaw[i].trim());
- }
+ for (String ccRaw : emails.split("[,;]+")) {
+ String ccRecip = ccRaw.trim();
+ if (ccRecip.length() > 0) {
+ cc.add(ccRaw.trim());
}
}
return cc;
Modified:
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/EmailListValidator.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/EmailListValidator.java?rev=1173734&r1=1173733&r2=1173734&view=diff
==============================================================================
---
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/EmailListValidator.java
(original)
+++
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/validation/EmailListValidator.java
Wed Sep 21 15:50:56 2011
@@ -62,9 +62,8 @@ public class EmailListValidator extends
*/
public static boolean isValidAddressList(String text) {
if (text != null && text.length() > 0) {
- String[] addresses = text.split("[,;\r\n]+");
- for (int i = 0; i < addresses.length; i++) {
- if (addresses[i].trim().length() > 0 &&
isValidAddress(addresses[i].trim()) == false) {
+ for (String address : text.split("[,;\r\n]+")) {
+ if (address.trim().length() > 0 &&
isValidAddress(address.trim()) == false) {
return false;
}
}
Modified:
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/AbstractFetchMessagesHandler.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/AbstractFetchMessagesHandler.java?rev=1173734&r1=1173733&r2=1173734&view=diff
==============================================================================
---
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/AbstractFetchMessagesHandler.java
(original)
+++
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/AbstractFetchMessagesHandler.java
Wed Sep 21 15:50:56 2011
@@ -152,10 +152,10 @@ public abstract class AbstractFetchMessa
// Add to addresses
Address[] toArray = m.getRecipients(RecipientType.TO);
if (toArray != null) {
- for (int b =0; b < toArray.length;b++) {
+ for (Address addr : toArray) {
String mailTo = null;
try {
- mailTo = MimeUtility.decodeText(toArray[b].toString());
+ mailTo = MimeUtility.decodeText(addr.toString());
userPreferences.addContact(mailTo);
} catch (UnsupportedEncodingException e) {
logger.debug("Unable to decode mailTo " + mailTo + " "
+ e.getMessage());
@@ -182,8 +182,8 @@ public abstract class AbstractFetchMessa
ArrayList<String> cc = new ArrayList<String>();
if (ccArray != null) {
- for (int b =0; b < ccArray.length;b++) {
- cc.add(ccArray[b].toString());
+ for (Address addr : ccArray) {
+ cc.add(addr.toString());
}
}
msg.setCc(cc);
@@ -194,9 +194,7 @@ public abstract class AbstractFetchMessa
ArrayList<IMAPFlag> iFlags = JavamailUtil.convert(m.getFlags());
ArrayList<Tag> tags = new ArrayList<Tag>();
- String[] userFlags = m.getFlags().getUserFlags();
- for (int a = 0; a < userFlags.length;a++) {
- String flag = userFlags[a];
+ for (String flag : m.getFlags().getUserFlags()) {
if (flag.startsWith(Tag.PREFIX)) {
tags.add(new Tag(flag.substring(Tag.PREFIX.length())));
}
Modified:
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/DeleteMessageByUidHandler.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/DeleteMessageByUidHandler.java?rev=1173734&r1=1173733&r2=1173734&view=diff
==============================================================================
---
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/DeleteMessageByUidHandler.java
(original)
+++
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/DeleteMessageByUidHandler.java
Wed Sep 21 15:50:56 2011
@@ -79,8 +79,8 @@ public class DeleteMessageByUidHandler e
}
// build up the list of messages to delete
List<Message> messages = new ArrayList<Message>();
- for (int i = 0; i < uids.size(); i++) {
- messages.add(f.getMessageByUID(uids.get(i)));
+ for (Long uid : uids) {
+ messages.add(f.getMessageByUID(uid));
}
Message[] mArray = messages.toArray(new Message[messages.size()]);
return mArray;
Modified:
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/FetchFoldersHandler.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/FetchFoldersHandler.java?rev=1173734&r1=1173733&r2=1173734&view=diff
==============================================================================
---
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/FetchFoldersHandler.java
(original)
+++
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/FetchFoldersHandler.java
Wed Sep 21 15:50:56 2011
@@ -65,10 +65,8 @@ public class FetchFoldersHandler extends
IMAPStore store = cache.get(user);
com.sun.mail.imap.IMAPFolder folder =
(com.sun.mail.imap.IMAPFolder) store.getDefaultFolder();
- Folder[] folders = folder.list();
// loop over all folders
- for (int i = 0; i < folders.length; i++) {
- Folder f = folders[i];
+ for (Folder f : folder.list()) {
createIMAPFolderTree(fList, createFolder(f), f.list());
}
logger.debug("Fetching folders for user: " + user + " returns: " +
fList.size() + " folders");
@@ -132,11 +130,11 @@ public class FetchFoldersHandler extends
*/
private void createIMAPFolderTree(List<IMAPFolder> fList,
IMAPFolder iFolder, Folder[] childFolders) throws
MessagingException, ActionException {
-
- for (int a = 0; a < childFolders.length; a++) {
- IMAPFolder folder = createFolder(childFolders[a]);
+
+ for (Folder f : childFolders) {
+ IMAPFolder folder = createFolder(f);
if (folder != null) {
-
iFolder.getChildIMAPFolders().add(createFolder(childFolders[a]));
+ iFolder.getChildIMAPFolders().add(createFolder(f));
}
}
fList.add(iFolder);
Modified:
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/JavamailUtil.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/JavamailUtil.java?rev=1173734&r1=1173733&r2=1173734&view=diff
==============================================================================
---
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/JavamailUtil.java
(original)
+++
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/JavamailUtil.java
Wed Sep 21 15:50:56 2011
@@ -40,9 +40,7 @@ public class JavamailUtil {
*/
public static ArrayList<IMAPFlag> convert(Flags flags) {
ArrayList<IMAPFlag> fList = new ArrayList<IMAPFlag>();
- Flag[] flagArray = flags.getSystemFlags();
- for (int i = 0; i < flagArray.length; i++) {
- Flag flag = flagArray[i];
+ for (Flag flag : flags.getSystemFlags()) {
fList.add(convert(flag));
}
return fList;
@@ -76,11 +74,8 @@ public class JavamailUtil {
*/
public static Flags convert(ArrayList<IMAPFlag> imapFlags) {
Flags iFlags = new Flags();
- for ( int i = 0; i< imapFlags.size(); i++) {
- IMAPFlag flag = imapFlags.get(i);
-
+ for (IMAPFlag flag : imapFlags) {
iFlags.add(convert(flag));
-
}
return iFlags;
}
Modified:
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/TagMessagesHandler.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/TagMessagesHandler.java?rev=1173734&r1=1173733&r2=1173734&view=diff
==============================================================================
---
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/TagMessagesHandler.java
(original)
+++
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/handler/TagMessagesHandler.java
Wed Sep 21 15:50:56 2011
@@ -69,9 +69,7 @@ public class TagMessagesHandler extends
if (folder.isOpen() == false) {
folder.open(Folder.READ_WRITE);
}
- Message[] messages = folder.getMessagesByUID(copyUids(uids));
- for (int i = 0; i < messages.length; i++) {
- Message m = messages[i];
+ for (Message m :folder.getMessagesByUID(copyUids(uids))) {
m.getFlags().add(tag.toString());
}
return new GenericResult();
Modified:
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/mock/MockIMAPFolder.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/server/src/main/java/org/apache/hupa/server/mock/MockIMAPFolder.java?rev=1173734&r1=1173733&r2=1173734&view=diff
==============================================================================
---
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/mock/MockIMAPFolder.java
(original)
+++
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/mock/MockIMAPFolder.java
Wed Sep 21 15:50:56 2011
@@ -245,11 +245,10 @@ public class MockIMAPFolder extends IMAP
throws MessagingException {
checkExists();
List<Message> mList = new ArrayList<Message>();
- for (int i = 0; i < msgs.length; i++) {
- Message m = msgs[i];
- if (m.getFlags().contains(Flag.DELETED)) {
- if (messages.remove(m)) {
- mList.add(m);
+ for (Message message : msgs) {
+ if (message.getFlags().contains(Flag.DELETED)) {
+ if (messages.remove(message)) {
+ mList.add(message);
}
}
}
@@ -267,12 +266,10 @@ public class MockIMAPFolder extends IMAP
public synchronized void setFlags(Message[] mArray, Flags flags,
boolean value) throws MessagingException {
checkExists();
- for (int i = 0; i < mArray.length; i++) {
- Message m = mArray[i];
- for (int a = 0; a < messages.size(); a++) {
- Message m2 = messages.get(a);
- if (m2.equals(m)) {
- m2.setFlags(flags, value);
+ for (Message message : mArray) {
+ for (Message message2 : messages) {
+ if (message2.equals(message)) {
+ message2.setFlags(flags, value);
break;
}
}
Modified:
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/mock/MockIMAPStore.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/server/src/main/java/org/apache/hupa/server/mock/MockIMAPStore.java?rev=1173734&r1=1173733&r2=1173734&view=diff
==============================================================================
---
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/mock/MockIMAPStore.java
(original)
+++
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/mock/MockIMAPStore.java
Wed Sep 21 15:50:56 2011
@@ -77,8 +77,8 @@ public class MockIMAPStore extends IMAPS
}
public boolean save(MockIMAPFolder folder) {
- for (int i= 0; i < folders.size(); i++) {
- if (folders.get(i).getFullName().equals(folder.getFullName())) {
+ for (MockIMAPFolder iFolder : folders) {
+ if (iFolder.getFullName().equals(folder.getFullName())) {
return false;
}
}
@@ -104,8 +104,7 @@ public class MockIMAPStore extends IMAPS
}
public MockIMAPFolder getParent(MockIMAPFolder folder) {
- for (int i = 0; i < folders.size(); i++) {
- MockIMAPFolder f = folders.get(i);
+ for (MockIMAPFolder f : folders) {
if ((f.getFullName() + MockIMAPFolder.SEPARATOR +
folder.getName()).equals(folder.getFullName())) {
return f;
}
@@ -122,8 +121,7 @@ public class MockIMAPStore extends IMAPS
}
return folders;
} else {
- for (int i = 0; i < folders.size(); i++) {
- MockIMAPFolder f = folders.get(i);
+ for (MockIMAPFolder f : folders) {
if (f.getFullName().startsWith(
folder.getFullName() + MockIMAPFolder.SEPARATOR)) {
childs.add(f);
@@ -158,8 +156,7 @@ public class MockIMAPStore extends IMAPS
@Override
public synchronized Folder getFolder(String name) {
- for (int i = 0; i < folders.size(); i++) {
- MockIMAPFolder mfolder = folders.get(i);
+ for (MockIMAPFolder mfolder : folders) {
if (mfolder.getFullName().equals(name)) {
return mfolder;
}
Modified:
james/hupa/trunk/widgets/src/main/java/org/apache/hupa/widgets/ui/RefetchPagingScrollTable.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/widgets/src/main/java/org/apache/hupa/widgets/ui/RefetchPagingScrollTable.java?rev=1173734&r1=1173733&r2=1173734&view=diff
==============================================================================
---
james/hupa/trunk/widgets/src/main/java/org/apache/hupa/widgets/ui/RefetchPagingScrollTable.java
(original)
+++
james/hupa/trunk/widgets/src/main/java/org/apache/hupa/widgets/ui/RefetchPagingScrollTable.java
Wed Sep 21 15:50:56 2011
@@ -86,11 +86,10 @@ public class RefetchPagingScrollTable<Ro
*
* @param rows
*/
- @SuppressWarnings("unchecked")
public void removeRows(ArrayList<RowType> rows) {
ArrayList<Integer> rowsIndex = new ArrayList<Integer>();
- for (int i = 0; i < rows.size(); i++) {
- int rowIndex = getRowValues().indexOf(rows.get(i));
+ for (RowType rowType : rows) {
+ int rowIndex = getRowValues().indexOf(rowType);
if (rowsIndex.contains(rowIndex) == false) {
rowsIndex.add(rowIndex);
}
@@ -103,7 +102,7 @@ public class RefetchPagingScrollTable<Ro
selectedRows.remove(getRowValue(index));
getRowValues().remove(index);
- ((MutableTableModel) getTableModel()).removeRow(index);
+ ((MutableTableModel<RowType>)
getTableModel()).removeRow(index);
}
// Check if we need to refetch rows
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
