Author: felixk
Date: Fri Sep 23 14:32:46 2011
New Revision: 1174812
URL: http://svn.apache.org/viewvc?rev=1174812&view=rev
Log:
Some small performance improvements
Modified:
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/InMemoryIMAPStoreCache.java
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/mock/MockIMAPFolder.java
james/hupa/trunk/shared/src/main/java/org/apache/hupa/shared/data/MessageDetails.java
james/hupa/trunk/widgets/src/main/java/org/apache/hupa/widgets/ui/impl/RndPanelGeneratorImplIE.java
Modified:
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java?rev=1174812&r1=1174811&r2=1174812&view=diff
==============================================================================
---
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java
(original)
+++
james/hupa/trunk/client/src/main/java/org/apache/hupa/client/mvp/IMAPMessageListView.java
Fri Sep 23 14:32:46 2011
@@ -385,7 +385,7 @@ public class IMAPMessageListView extends
* @author Norman
*
*/
- private final class AttachmentColumnDefination extends
AbstractColumnDefinition<Message, Boolean> {
+ private static final class AttachmentColumnDefination extends
AbstractColumnDefinition<Message, Boolean> {
@Override
public Boolean getCellValue(Message rowValue) {
@@ -402,7 +402,7 @@ public class IMAPMessageListView extends
* ColumnDefination which display the From
*
*/
- private final class FromColumnDefination extends
AbstractColumnDefinition<Message, String> {
+ private static final class FromColumnDefination extends
AbstractColumnDefinition<Message, String> {
@Override
public String getCellValue(Message rowValue) {
@@ -420,7 +420,7 @@ public class IMAPMessageListView extends
* ColumnDefination which display the Subject
*
*/
- private final class SubjectColumnDefination extends
AbstractColumnDefinition<Message, String> {
+ private static final class SubjectColumnDefination extends
AbstractColumnDefinition<Message, String> {
@Override
public String getCellValue(Message rowValue) {
@@ -439,7 +439,7 @@ public class IMAPMessageListView extends
* ColumnDefination which display the Date
*
*/
- private final class DateColumnDefination extends
AbstractColumnDefinition<Message, Date> {
+ private static final class DateColumnDefination extends
AbstractColumnDefinition<Message, Date> {
@Override
public Date getCellValue(Message rowValue) {
@@ -516,7 +516,7 @@ public class IMAPMessageListView extends
*
* @param <E> RowType
*/
- private final class WhiteSpaceCellRenderer<E> implements CellRenderer<E,
String> {
+ private static final class WhiteSpaceCellRenderer<E> implements
CellRenderer<E, String> {
/*
* (non-Javadoc)
Modified:
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/InMemoryIMAPStoreCache.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/server/src/main/java/org/apache/hupa/server/InMemoryIMAPStoreCache.java?rev=1174812&r1=1174811&r2=1174812&view=diff
==============================================================================
---
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/InMemoryIMAPStoreCache.java
(original)
+++
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/InMemoryIMAPStoreCache.java
Fri Sep 23 14:32:46 2011
@@ -168,7 +168,7 @@ public class InMemoryIMAPStoreCache impl
pool.remove(username);
}
- private final class CachedIMAPStore {
+ private static final class CachedIMAPStore {
private long validUntil;
private int validForMillis;
private IMAPStore store;
Modified:
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/mock/MockIMAPFolder.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/server/src/main/java/org/apache/hupa/server/mock/MockIMAPFolder.java?rev=1174812&r1=1174811&r2=1174812&view=diff
==============================================================================
---
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/mock/MockIMAPFolder.java
(original)
+++
james/hupa/trunk/server/src/main/java/org/apache/hupa/server/mock/MockIMAPFolder.java
Fri Sep 23 14:32:46 2011
@@ -156,7 +156,7 @@ public class MockIMAPFolder extends IMAP
public synchronized Message getMessageByUID(long uid)
throws MessagingException {
checkExists();
- return getMessage(new Long(uid).intValue());
+ return getMessage((int)uid);
}
@Override
@@ -169,8 +169,7 @@ public class MockIMAPFolder extends IMAP
public synchronized Message[] getMessagesByUID(long uidstart, long uidend)
throws MessagingException {
checkExists();
- return getMessages(new Long(uidstart).intValue(), new Long(uidend)
- .intValue());
+ return getMessages((int)uidstart, (int)uidend);
}
@Override
@@ -179,7 +178,7 @@ public class MockIMAPFolder extends IMAP
checkExists();
int ints[] = new int[uids.length];
for (int i = 0; i < uids.length; i++) {
- ints[i] = new Long(uids[i]).intValue();
+ ints[i] = (int)uids[i];
}
return getMessages(ints);
}
Modified:
james/hupa/trunk/shared/src/main/java/org/apache/hupa/shared/data/MessageDetails.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/shared/src/main/java/org/apache/hupa/shared/data/MessageDetails.java?rev=1174812&r1=1174811&r2=1174812&view=diff
==============================================================================
---
james/hupa/trunk/shared/src/main/java/org/apache/hupa/shared/data/MessageDetails.java
(original)
+++
james/hupa/trunk/shared/src/main/java/org/apache/hupa/shared/data/MessageDetails.java
Fri Sep 23 14:32:46 2011
@@ -112,7 +112,7 @@ public class MessageDetails implements S
}
public int hashCode() {
- Long l = new Long(getUid());
+ Long l = Long.valueOf(getUid());
return l.intValue() * 16;
}
}
Modified:
james/hupa/trunk/widgets/src/main/java/org/apache/hupa/widgets/ui/impl/RndPanelGeneratorImplIE.java
URL:
http://svn.apache.org/viewvc/james/hupa/trunk/widgets/src/main/java/org/apache/hupa/widgets/ui/impl/RndPanelGeneratorImplIE.java?rev=1174812&r1=1174811&r2=1174812&view=diff
==============================================================================
---
james/hupa/trunk/widgets/src/main/java/org/apache/hupa/widgets/ui/impl/RndPanelGeneratorImplIE.java
(original)
+++
james/hupa/trunk/widgets/src/main/java/org/apache/hupa/widgets/ui/impl/RndPanelGeneratorImplIE.java
Fri Sep 23 14:32:46 2011
@@ -37,7 +37,7 @@ import com.google.gwt.user.client.ui.Wid
*/
public class RndPanelGeneratorImplIE implements RndPanelGenerator {
- class MyRoundedLinePanel extends RoundedLinePanel {
+ static class MyRoundedLinePanel extends RoundedLinePanel {
public MyRoundedLinePanel(int a, int b) {
super(a,b);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
