I agree, we should use the same logging framework. - Manolo
On Wed, Sep 28, 2011 at 8:15 AM, Norman Maurer <[email protected] > wrote: > +1 to move to slf4j > > Bye, > Norman > > > 2011/9/28 Felix Knecht <[email protected]>: > > IIRC at least James-Server uses slf4j and not commons-logging. Maybe hupa > > should also use slf4j to be constant in using the same logging facade? > > > > On 09/28/2011 12:03 AM, Felix Knecht wrote: > >> > >> Hi Manolo > >> > >> Comments inline > >> > >> On 09/27/2011 07:11 PM, Manuel Carrasco Mońino wrote: > >>> > >>> Hi Felix, > >>> Demo is a set of messages used for unit testting. Those messages are > used > >>> for demoing, in demo mode we inject mock imap and smpt > >>> implementations, so > >>> there is no imap connection nor smtp (although it is possible to > deliver > >>> smtp if it is configured). > >> > >> I'm quite sure we can use a dummy mail server (like greenmail, see > >> later) to contain and deliver these demo message also. > >> > >>> > >>> I think we could move those classes/resources to the test folder but > demo > >>> mode is pretty useful when developing or testing the app before > >>> configuring > >>> it. I prefer to leave these classes here instead of creating a package > >>> to be > >>> shared by test and production war. > >> > >> What do you mean by 'test war'? IMO a 'production war' should not > >> contain code used only for running tests but not in productivity. There > >> should be another way to do this. > >> Some tests may have to be run as integration tests - not only test. So a > >> dummy mail server can be started before the integration tests are run > >> and be shutdown after the integration test. Maybe we can use greenmail > >> (http://www.icegreen.com/greenmail/) for this. > >> > >> I can imaging that the application run as demo also bases on such a > >> dummy server. > >> > >>> > >>> BTW, I have some code I started to port HUPA to use the Request > >>> Factory in > >>> gwt-2.4.0, I did not finished it since 2.2 and 2.3 had an important > >>> memory > >>> leak issue, which it seems fixed in 2.4.0, may I commit it?, or better > >>> could > >>> we use this or another thread to propose a set of changes hupa needs. > >> > >> No problem, go ahead and commit it. Hupa has - as far as I can see - > >> never been released, so everything can be done. > >> > >> Regards > >> Felix > >> > >>> > >>> Cheers > >>> - Manolo > >>> > >>> On Fri, Sep 23, 2011 at 2:35 PM, Felix Knecht<[email protected]> wrote: > >>> > >>>> Hi all > >>>> > >>>> According to HUPA-25 [1] there should be a running demo of hupa at > >>>> [2]. It > >>>> isn't - I know, it's an open issue. > >>>> > >>>> Why I come to this? I found several classes in the productive (not > test) > >>>> part in the server module to enable running the demo. I wonder if > >>>> there's > >>>> really a need to 'pollute' productive parts with code used only to run > a > >>>> demo? > >>>> > >>>> What about removing this 'demo-code' from the productive part and find > >>>> another way to run a demo if ever? > >>>> > >>>> WDOT? > >>>> > >>>> Regards > >>>> Felix > >>>> > >>>> [1] > >>>> > >>>> https://issues.apache.org/**jira/browse/HUPA-25< > https://issues.apache.org/jira/browse/HUPA-25> > >>>> > >>>> [2] > >>>> > >>>> http://james.zones.apache.org:**8080/hupa/< > http://james.zones.apache.org:8080/hupa/> > >>>> > >>>> > >>>> > >>>> > ------------------------------**------------------------------**--------- > >>>> > >>>> To unsubscribe, e-mail: > >>>> > >>>> server-dev-unsubscribe@james.**apache.org< > [email protected]> > >>>> > >>>> For additional commands, e-mail: > >>>> [email protected].**org<[email protected]> > >>>> > >>>> > >>> > >> > >> > >> --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > > > > > > --------------------------------------------------------------------- > > To unsubscribe, e-mail: [email protected] > > For additional commands, e-mail: [email protected] > > > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > >
