Everything below fixed.
On 09/28/2011 10:34 AM, Felix Knecht wrote:
Hi Norman
On 09/28/2011 09:45 AM, Norman Maurer wrote:
Hi there,
I think we should get ready for a new mailbox release. This is the
first step needed for the next james server release. So please let me
know if you have any concerns ..
( ... findbugs tells me ... )
IMO there are some 'missings' which could be fix like
- close an opened stream explicitly
- respect return value of createNewFile / mkdir / delete / renameTo (and
throw an IOException in this case? )
- when defining compareTo also define the equals method [1]
- fix synchronization [2]
- fix serializable [3]
In many modules exists empty directories
src/[main|test]/[config|resources]. What are they for?
Are some of the mentioned points a NoGo for release or should they just
be added to JIRA for later improvement?
Regards
Felix
stream / file operations
https://builds.apache.org/view/G-L/view/James/job/mailbox-site/site/apache-james-mailbox-hbase/findbugs.html
https://builds.apache.org/view/G-L/view/James/job/mailbox-site/site/apache-james-mailbox-maildir/findbugs.html
[1]
https://builds.apache.org/view/G-L/view/James/job/mailbox-site/site/apache-james-mailbox-store/findbugs.html#org.apache.james.mailbox.store.StoreMessageResultIterator$UnloadedMessageResult
[2]
https://builds.apache.org/view/G-L/view/James/job/mailbox-site/site/apache-james-mailbox-store/findbugs.html#org.apache.james.mailbox.store.search.MessageSearcher
[3]
https://builds.apache.org/view/G-L/view/James/job/mailbox-site/site/apache-james-mailbox-api/findbugs.html#org.apache.james.mailbox.StandardMailboxMetaDataComparator
Bye,
Norman
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
