[
https://issues.apache.org/jira/browse/MAILETSTANDARD-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257501#comment-13257501
]
Dinyar Rabady commented on MAILETSTANDARD-12:
---------------------------------------------
Hi Eric,
I might be wrong, but the current way the code is written the setRemoveAddr
method is passed the host name, while the setRemoteHost method is passed an
address. I'm not aware that this leads to any errors, it just struck me while
reading the source. The suggestion to swap the lines came after a very quick
scan, the patch applies the correct change however by only swapping the method
calls in the try blocks.
> In DSNBounce the exception handling is mixed up for setting Remote Address
> and Host
> -----------------------------------------------------------------------------------
>
> Key: MAILETSTANDARD-12
> URL: https://issues.apache.org/jira/browse/MAILETSTANDARD-12
> Project: JAMES Standard Mailets
> Issue Type: Bug
> Affects Versions: 1.0
> Reporter: Dinyar Rabady
> Assignee: Robert Burrell Donkin
> Priority: Trivial
> Attachments: james_patch.diff
>
> Original Estimate: 10m
> Remaining Estimate: 10m
>
> In the DSNBounce Mailet line 159 and line 165 are probably mixed up. (These
> are the catch blocks for setting the Remote Address and Host respectively).
> This means that newMail.setRemoteHost("localhost"); and
> newMail.setRemoteAddr("127.0.0.1"); should be swapped.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
