Hi Manuel,
I will use the apache code-style, probably with Maven's check-style
plug-in, and use 4 spaces instead of tabs, eclipse can do this for me
:), I will use the license header and write Java docs from now on out.
Thank you,
Mihai
On 05.05.2012 12:47, Manuel Carrasco Moñino wrote:
Just a recommendation about code style, could you use 4 spaces instead
of tabs?, it makes the code more readable in the repository.
There are a few more points in code-styling which if you consider from
the beginning would make easier merge with james in the future
(license header, java docs, ...). Take a look to
http://james.apache.org/contribute.html.
God job.
- Manolo
On Sat, May 5, 2012 at 11:36 AM, Ioan Eugen Stan
<stan.ieu...@gmail.com <mailto:stan.ieu...@gmail.com>> wrote:
Hello Mihai,
Good job. I've took a small peek at the code and it's ok. The next
step will be to create a Directory implementation that extends lucene
Directory [1] and make the tests so that you can supply a directory
implementation.
Your implementation should just throw exceptions initially, so all
tests will fail. After this we will concentrate on implementing
functionality. You can use the code for other implementations to gain
some insight (Ramdirectory).
[1]
http://lucene.apache.org/core/old_versioned_docs/versions/3_5_0/api/all/index.html
2012/5/5 Mihai Soloi <mihai.so...@gmail.com
<mailto:mihai.so...@gmail.com>>:
> Hey Eugen,
>
> I've pushed an initial two classes on the apache-extras repo, I
created [1].
> I've used git versionning, you can clone the repo. I will add
more classes,
> this weekend, this is just the two classes from the Lucene in
Action book,
> updated to the lucene-core 3.6
>
> [1]
http://code.google.com/a/apache-extras.org/p/mailbox-lucene-index-hbase/
--
Ioan Eugen Stan
http://ieugen.blogspot.com/ *** http://bucharest-jug.github.com/ ***
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
<mailto:server-dev-unsubscr...@james.apache.org>
For additional commands, e-mail: server-dev-h...@james.apache.org
<mailto:server-dev-h...@james.apache.org>
