One more thing, I've seen that you are getting a good knowledge of gin !,
so I think you could remove many boilerplate code in constructors if you
annotate classes attributes like this:
>>>>>>>>>>>> Before
private final Displayable display;
private final EventBus eventBus;
private final PlaceController placeController;
private DispatchAsync dispatcher;
private final Provider<MessageSendPlace> messageSendPlaceProvider;
@Inject
public IMAPMessageListActivity(Displayable display, EventBus eventBus,
PlaceController placeController,
DispatchAsync dispatcher,Provider<MessageSendPlace>
messageSendPlaceProvider){
this.display = display;
this.eventBus = eventBus;
this.placeController = placeController;
this.dispatcher = dispatcher;
this.messageSendPlaceProvider = messageSendPlaceProvider;
// add this event on constructor because we don't want to remove it
on unbind
eventBus.addHandler(LogoutEvent.TYPE, new LogoutEventHandler() {
public void onLogout(LogoutEvent logoutEvent) {
IMAPMessageListActivity.this.display.reset();
IMAPMessageListActivity.this.display.getSearchValue().setValue("");
}
});
}
>>>>>> After
private final EventBus eventBus;
@Inject private Displayable display;
@Inject private PlaceController placeController;
@Inject private DispatchAsync dispatcher;
@Inject private Provider<MessageSendPlace> messageSendPlaceProvider;
@Inject
public IMAPMessageListActivity(EventBus eventBus){
this.eventBus = eventBus;
// add this event on constructor because we don't want to remove it
on unbind
eventBus.addHandler(LogoutEvent.TYPE, new LogoutEventHandler() {
public void onLogout(LogoutEvent logoutEvent) {
IMAPMessageListActivity.this.display.reset();
IMAPMessageListActivity.this.display.getSearchValue().setValue("");
}
});
}
Note that in this case attributes are set after the class has been created,
so you cannot use them in constructors.
On Thu, Jul 5, 2012 at 6:28 AM, echo <[email protected]> wrote:
> Hi there,
>
>> #1 I dont know why hupa-evo only works with the folder 'Inbox' which makes
>> fail demo mode which uses the name Mock-Inbox. If you replace Mock-Inbox
>> by
>> Inbox in the url, the right panel is shown but it fails to show messages
>> because in the server the folder name is different. Try to fix it and work
>> with demo data otherwise developing in gmail mode consumes a lot of time.
>>
> In my case, I've make it work after changing the DefaultInboxFolder=*
> Mock-Inbox,* not INBOX, in [{$HOME}/.hupa/config.properties], even though
> it still need to click the *refresh* link in order to display messages
> list.
>
> --
> *echo*
>