I dont see the patch in jira either https://issues.apache.org/jira/browse/HUPA-93
- Manolo On Fri, Jul 13, 2012 at 10:49 AM, <[email protected]> wrote: > Yes, it seems, that happened. I will attach the patch to the JIRA ticket > > > Zsombor > > > > On Fri Jul 13 10:38:16 GMT+200 2012, Ioan Eugen Stan & > lt;[email protected]>. wrote: > > Hi Manolo, Zsombor, > > The list may remove the attachments. If it fails maybe isuue on JIRA + > file attached would be better, > > 2012/7/13 Manuel Carrasco Moñino <[email protected]>: > > Hi, I do not see your patches, did you forget to attach to your email? > > > > - Manolo > > > > On Thu, Jul 12, 2012 at 11:48 PM, Zsombor <[email protected]> > wrote: > > > >> Hi, > >> > >> I've attached two patch: > >> - the first for adding 'View' link for the attachments in Hupa > for images > >> - the secod for modifying the regexp for the email address > validator, > >> because the current regexp doesn't allow to subscribe to the > server-dev > >> mail list,the mailing list manager sends email where the reply-to > address > >> contains '=' > >> > >> Regards > >> Zsombor > >> > >> > >> On Thu, Jul 12, 2012 at 11:05 PM, Zsombor <[email protected]> > wrote: > >> > >>> Sorry, my bad. It turned out, that a browser extension had > removed the > >>> target attributes from the html, just after it was attached > to the DOM. > >>> > >>> I will create a proper patch file about it. > >>> > >>> Regards > >>> Zsombor > >>> > >>> > >>> On Thu, Jul 12, 2012 at 3:41 PM, <[email protected]> > wrote: > >>> > >>>> Hmm, interesting, because on an other gwt project, > >>>> > >>>> Anchor a = new Anchor("click me"); > >>>> a.setTarget("_blank"); > >>>> my_panel.add(a); > >>>> > >>>> worked flawlessly. > >>>> > >>>> Thanks > >>>> > >>>> On Thu Jul 12 15:11:51 GMT+200 2012, Manuel Carrasco > Moñino < > >>>> [email protected]>. wrote: > >>>> > >>>> Gwt Anchor widget is thought to maintain the user in the > same page so as > >>>> the app is not replaced accidentally. So the correct code > is: > >>>> Anchor a = new Anchor("click me"); > >>>> a.addClickHandler(new ClickHandler() { > >>>> public void onClick(ClickEvent event) { > >>>> Window.open("/show_attachments/", "_blank", ""); > >>>> } > >>>> }); > >>>> your_panel.add(a); > >>>> > >>>> If you want to add html code to the view you can use the > HTML widget, > >>>> but > >>>> you have to be aware about what you do. > >>>> > >>>> HTML h = new HTML("<a href='/your_url' > target='_blank'>click me</a>"); > >>>> your_panel.add(h); > >>>> > >>>> > >>>> - Manolo > >>>> > >>>> On Thu, Jul 12, 2012 at 9:52 AM, <[email protected]> > wrote: > >>>> > >>>> > Hi, > >>>> > > >>>> > I've recently started using hupa, and it's awesome, > with a couple of > >>>> > glitches. For example, it is impossible to subscribe > to this mail list > >>>> > using hupa, because of the email address validation > regexp ;) But it > >>>> was > >>>> > easy to fix. I've tried to implement a 'View > attachment' functionality > >>>> for > >>>> > attachments (the servlet related parts was simple - > skip the > >>>> > 'content-disposition' header), I've stucked on > creating a 'View' link > >>>> with > >>>> > target="_blank". It seems that, I can create Anchor > object with > >>>> > setTarget("_blank"), and I can add it to the > container - and in that > >>>> case I > >>>> > can still see the generated html is correct, but in > the browser, that > >>>> > attribute is removed. Do you know any functionality > which could adjust > >>>> the > >>>> > html ? It seems a bit overkill to have click handler > on it, and call > >>>> > Window.open(...), instead of using the builtin html > functionality. > >>>> > Other question, I see, there are git mirror > repositories of apache > >>>> > softwares at http://git.apache.org , but there is > no repo for hupa - > >>>> can > >>>> > you create one ? With a github mirror would be > awesome ;) > >>>> > > >>>> > Thanks > >>>> > Zsombor > >>>> > > >>>> > >>>> > >>> > >> > >> > >> > --------------------------------------------------------------------- > >> To unsubscribe, e-mail: [email protected] > >> For additional commands, e-mail: [email protected] > >> > > > > -- > Ioan Eugen Stan / CTO / http://axemblr.com >
