[
https://issues.apache.org/jira/browse/JAMES-1015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13573364#comment-13573364
]
Ioan Eugen Stan commented on JAMES-1015:
----------------------------------------
Hello Eric,
I'm talking about the way we wire components. spring-server.xml contains bean
definitions that are also found in each component context.
For example, in sping-server.xml we have:
<bean id="dnsservice"
class="org.apache.james.dnsservice.dnsjava.DNSJavaService" />
and in dns-context.xml we have:
<bean id="dnsservice"
class="org.apache.james.dnsservice.dnsjava.DNSJavaService" />
I haven't seen any import of dns-service.xml so this makes me believe that we
are duplication wiring configuration. Shouldn't we import them in
spring-server? [3], [4]
[1]
https://github.com/ieugen/james/blob/trunk/app/src/main/resources/META-INF/org/apache/james/spring-server.xml
[2]
https://github.com/ieugen/james/blob/trunk/dns-service/dnsservice-dnsjava/src/main/resources/META-INF/spring/dns-context.xml
[3]
http://static.springsource.org/spring/docs/3.0.x/spring-framework-reference/html/beans.html#beans-factory-xml-import
[4]
http://stackoverflow.com/questions/5092133/divide-spring-configuration-across-multiple-projects
> Configuration files of components should be moved from the spring-deployment
> module to the concrete implementation
> ------------------------------------------------------------------------------------------------------------------
>
> Key: JAMES-1015
> URL: https://issues.apache.org/jira/browse/JAMES-1015
> Project: James Server
> Issue Type: Sub-task
> Reporter: Norman Maurer
> Assignee: Ioan Eugen Stan
>
> At the moment all configuration files are in the spring-deployment module.
> This does not make sense, we should move the configuration file to the
> component it belongs to. So for example smtpserver.xml should get moved to
> the smtpserver component / module.
> This will make it easier to create a osgi deployment later too
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
