Github user aduprat commented on a diff in the pull request:

    https://github.com/apache/james-project/pull/17#discussion_r43881372
  
    --- Diff: 
backends-common/cassandra/src/test/java/org/apache/james/backends/cassandra/CassandraCluster.java
 ---
    @@ -42,10 +42,12 @@
     
         private static final long SLEEP_BEFORE_RETRY = 200;
         private static final int MAX_RETRY = 200;
    +    private static final long EMBEDDED_CASSANDRA_TIMEOUT = MAX_RETRY * 
SLEEP_BEFORE_RETRY;
    --- End diff --
    
    I would prefer an independent value, as the MAX_RETRY & SLEEP_BEFORE_RETRY 
don't make sense for this, IMHO.
    You may also add the unit in the constant name.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to