Repository: james-project Updated Branches: refs/heads/master e2b52479e -> b9629e9a8
JAMES-1754 Remove authentication from download JMAP endpoint Project: http://git-wip-us.apache.org/repos/asf/james-project/repo Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/db97e4bf Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/db97e4bf Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/db97e4bf Branch: refs/heads/master Commit: db97e4bf33697f2e9771ef141662689491e76162 Parents: 7c8a65b Author: Antoine Duprat <[email protected]> Authored: Wed Jun 8 13:11:39 2016 +0200 Committer: Antoine Duprat <[email protected]> Committed: Wed Jun 8 13:11:39 2016 +0200 ---------------------------------------------------------------------- .../src/test/resources/cucumber/DownloadEndpoint.feature | 4 ++-- .../jmap/src/main/java/org/apache/james/jmap/JMAPServer.java | 3 --- 2 files changed, 2 insertions(+), 5 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/james-project/blob/db97e4bf/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/resources/cucumber/DownloadEndpoint.feature ---------------------------------------------------------------------- diff --git a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/resources/cucumber/DownloadEndpoint.feature b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/resources/cucumber/DownloadEndpoint.feature index b5f9d3b..6edcbc0 100644 --- a/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/resources/cucumber/DownloadEndpoint.feature +++ b/server/protocols/jmap-integration-testing/jmap-integration-testing-common/src/test/resources/cucumber/DownloadEndpoint.feature @@ -19,9 +19,9 @@ Feature: Download endpoint When asking for an attachment Then the user should be authorized - Scenario: An unauthenticated user should not have access to the download endpoint + Scenario: An unauthenticated user should have access to the download endpoint When asking for an attachment - Then the user should not be authorized + Then the user should be authorized Scenario: A known user should not have access to the download endpoint without a blobId Given a current user with username "[email protected]" and password "secret" http://git-wip-us.apache.org/repos/asf/james-project/blob/db97e4bf/server/protocols/jmap/src/main/java/org/apache/james/jmap/JMAPServer.java ---------------------------------------------------------------------- diff --git a/server/protocols/jmap/src/main/java/org/apache/james/jmap/JMAPServer.java b/server/protocols/jmap/src/main/java/org/apache/james/jmap/JMAPServer.java index 5161412..0e6b616 100644 --- a/server/protocols/jmap/src/main/java/org/apache/james/jmap/JMAPServer.java +++ b/server/protocols/jmap/src/main/java/org/apache/james/jmap/JMAPServer.java @@ -57,9 +57,6 @@ public class JMAPServer implements Configurable { .only() .serveAsOneLevelTemplate(JMAPUrls.DOWNLOAD) .with(downloadServlet) - .filterAsOneLevelTemplate(JMAPUrls.DOWNLOAD) - .with(new AllowAllCrossOriginRequests(bypass(authenticationFilter).on("OPTIONS").only())) - .only() .build()); } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
