[ https://issues.apache.org/jira/browse/JAMES-1808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392225#comment-15392225 ]
Paul Lee commented on JAMES-1808: --------------------------------- Unfortunately, I don't have any failing test case. I inadvertently watched the code and noticed that it was theoretically wrong and just reported it. By the way, I'm curious if the code block is really necessary. I know that US-ASCII characters are only allowed by the standard, but isn't it just O.K to leave non-ASCII characters as is without converting them to question marks? > if (character > 128) should be changed to if (character >= 128) > --------------------------------------------------------------- > > Key: JAMES-1808 > URL: https://issues.apache.org/jira/browse/JAMES-1808 > Project: James Server > Issue Type: Bug > Components: IMAPServer > Affects Versions: 3.0.0-beta5 > Reporter: Paul Lee > Priority: Minor > Fix For: 3.0.0-beta5 > > > There is a conditional code block as follows in the class > 'ImapResponseComposerImpl' of the package 'org.apache.james.imap.encode.base' > in the 'protocols-imap' project. > // 7-bit ASCII only > if (character > 128) { > buffer.write(BYTE_QUESTION); > } else { > buffer.write((byte) character); > } > An equals(=) sign should be included in the conditional since the range of > US-ASCII is from 0 to 127(not including 128). -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org