Tests and readme are OK to me.
The conf folder is only populated with -template.xml - IMHO we should
provide upon the template a full set of default configuration xml files
so that the server starts out-of-the-box.
On 04/07/17 14:03, Benoit Tellier wrote:
Hi Eric,
My answers inlined.
Cheers,
Benoit
Le 04/07/2017 à 17:41, Eric Charles a écrit :
I have successfully built with skipTests
With tests enabled, it failed two times (one at es module, the other
at the web integration module) to finally succeed after relaunch. This
can be considered and flaky tests and is good to me.
We got a green build: https://james.open-paas.org/
However, when I launch the binary distribution without any change, I
get and exception [1], which is a blocker to me.
You are missing a configuration file:
Caused by: org.apache.commons.configuration.ConfigurationException:
Unable to load configuration for component indexer
Please have a look to the docker sample configuration :
https://github.com/apache/james-project/tree/master/dockerfiles/run/spring/destination/conf
Moreover, these files are included in sample configuration:
https://github.com/apache/james-project/tree/master/server/app/src/main/resources
So it is in my opinion not a blocker. Thus it do not require any fix.
Can we fix this, I will try again, and then relaunch a vote?
Also, there are 3 README is the top folder of the distribution tarball:
README
README.crypto
README.txt
README.crypto is fine, but content of the 2 other don't help a
new-comer to start (no information on how to start the server, read
the logs...) - Ideally we should just have a README.md.
The base repository exposed on the website does only have one readme:
https://github.com/apache/james-project/
Concerning the READMEs you points (which needs code navigation from
james-project), they are clearly oudated. I would advocate deleting them.
https://github.com/apache/james-project/blob/master/server/Overview.md
Is a duplicate from website content.
https://github.com/apache/james-project/blob/master/server/README.txt Also
https://github.com/apache/james-project/blob/master/server/NOTICE is a
duplicate for LICENSE
https://github.com/apache/james-project/blob/master/server/BUILD.txt do
not seem useful. It is less detailed than
https://github.com/apache/james-project/blob/master/README.adoc
However, should we really delay the release for issues not related to
the issue? (and thus not bundled with it?) This can be fixed on the
master branch, which is the first one seen when reaching github, even if
handled after 3.0.
See the related JIRA https://issues.apache.org/jira/browse/JAMES-2088 .
Thx, Eric
INFO 12:35:07,284 |
org.apache.james.container.spring.context.JamesServerApplicationContext
| Refreshing
org.apache.james.container.spring.context.JamesServerApplicationContext@60c5aa8d:
startup date [Tue Jul 04 12:35:07 CEST 2017]; root of context hierarchy
WARN 12:35:08,626 |
org.apache.james.container.spring.context.JamesServerApplicationContext
| Exception encountered during context initialization - cancelling
refresh attempt
org.springframework.beans.FatalBeanException: Unable to config the
indexer; nested exception is
org.apache.commons.configuration.ConfigurationException: Unable to
load configuration for component indexer
at
org.apache.james.container.spring.bean.factorypostprocessor.IndexerConfigurationBeanFactoryPostProcessor.postProcessBeanFactory(IndexerConfigurationBeanFactoryPostProcessor.java:70)
at
org.springframework.context.support.AbstractApplicationContext.invokeBeanFactoryPostProcessors(AbstractApplicationContext.java:696)
at
org.springframework.context.support.AbstractApplicationContext.invokeBeanFactoryPostProcessors(AbstractApplicationContext.java:686)
at
org.springframework.context.support.AbstractApplicationContext.refresh(AbstractApplicationContext.java:461)
at
org.springframework.context.support.ClassPathXmlApplicationContext.<init>(ClassPathXmlApplicationContext.java:139)
at
org.springframework.context.support.ClassPathXmlApplicationContext.<init>(ClassPathXmlApplicationContext.java:93)
at
org.apache.james.container.spring.context.JamesServerApplicationContext.<init>(JamesServerApplicationContext.java:40)
at
org.apache.james.app.spring.JamesAppSpringMain.init(JamesAppSpringMain.java:61)
at
org.apache.james.app.spring.JamesAppSpringMain.main(JamesAppSpringMain.java:42)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at
sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
at
sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:497)
at
org.tanukisoftware.wrapper.WrapperSimpleApp.run(WrapperSimpleApp.java:240)
at java.lang.Thread.run(Thread.java:745)
Caused by: org.apache.commons.configuration.ConfigurationException:
Unable to load configuration for component indexer
at
org.apache.james.container.spring.lifecycle.ConfigurationProviderImpl.getConfiguration(ConfigurationProviderImpl.java:135)
at
org.apache.james.container.spring.bean.factorypostprocessor.IndexerConfigurationBeanFactoryPostProcessor.postProcessBeanFactory(IndexerConfigurationBeanFactoryPostProcessor.java:47)
... 14 more
On 30/06/17 09:22, aduprat wrote:
Hello every one,
I'm very very very happy to announce the vote for the upcoming 3.0.0
version
of our beloved james server.
You can access sources on github
https://github.com/apache/james-project/releases
Nexus artifact to be released can be found here :
https://repository.apache.org/#stagingRepositories
It is number #1017
Moreover I uploaded compiled zip, along with md5 and sha1 sums, all
signed.
http://www.apache.org/dist/james/server/3.0.0/james-server-app-3.0.0-app.zip
http://www.apache.org/dist/james/server/3.0.0/james-server-app-3.0.0-app.zip.sig
http://www.apache.org/dist/james/server/3.0.0/james-server-app-3.0.0-app.zip.md5
http://www.apache.org/dist/james/server/3.0.0/james-server-app-3.0.0-app.zip.md5.sig
http://www.apache.org/dist/james/server/3.0.0/james-server-app-3.0.0-app.zip.sha1
http://www.apache.org/dist/james/server/3.0.0/james-server-app-3.0.0-app.zip.sha1.sig
According to Release policy, we need a majority vote :
- At least 3 PMC
- A majority of voters
- This release can't be vetoed
Followhttp://www.apache.org/dev/release.html for more details.
To vote, you can reply to this email with
+1
If you accept the release
-1
If you reject the release
Votes will close on Monday 7th July 2017, 9am CET.
Regards,
Antoine Duprat
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
