[ https://issues.apache.org/jira/browse/JAMES-2193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16210509#comment-16210509 ]
Luc DUZAN commented on JAMES-2193: ---------------------------------- Thank you Randal for opening this issue. But considering your patch we would need a diff file. It will be even better if you open a PR on apache james github: https://github.com/apache/james-project/. If you open a PR please prefix your commit name and your PR name by JAMES-2193. Best regards, > command metrics not done if doFilterChecks throws exception > ----------------------------------------------------------- > > Key: JAMES-2193 > URL: https://issues.apache.org/jira/browse/JAMES-2193 > Project: James Server > Issue Type: Bug > Components: SMTPServer > Affects Versions: 3.0.0 > Reporter: Randal Modowski > Priority: Critical > Attachments: AbstractHookableCmdHandler.java > > Original Estimate: 24h > Remaining Estimate: 24h > > If doFilterChecks throws an exception it is outside of the try block so the > metric in the finally will never be called. doFilterChecks should be moved to > inside the try catch. > see attachment for patch -- This message was sent by Atlassian JIRA (v6.4.14#64029) --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org