JAMES-2246 ProcessorConfiguration builder JMX enabled default value is not explicit
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/31f473f2 Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/31f473f2 Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/31f473f2 Branch: refs/heads/master Commit: 31f473f234753de4db019a1cfafd29b9d2006796 Parents: 1fb731a Author: benwa <btell...@linagora.com> Authored: Fri Dec 1 10:02:15 2017 +0700 Committer: benwa <btell...@linagora.com> Committed: Fri Dec 8 17:33:49 2017 +0700 ---------------------------------------------------------------------- .../james/mailets/configuration/ProcessorConfiguration.java | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/james-project/blob/31f473f2/server/mailet/integration-testing/src/test/java/org/apache/james/mailets/configuration/ProcessorConfiguration.java ---------------------------------------------------------------------- diff --git a/server/mailet/integration-testing/src/test/java/org/apache/james/mailets/configuration/ProcessorConfiguration.java b/server/mailet/integration-testing/src/test/java/org/apache/james/mailets/configuration/ProcessorConfiguration.java index cf95d69..e1de38d 100644 --- a/server/mailet/integration-testing/src/test/java/org/apache/james/mailets/configuration/ProcessorConfiguration.java +++ b/server/mailet/integration-testing/src/test/java/org/apache/james/mailets/configuration/ProcessorConfiguration.java @@ -20,6 +20,8 @@ package org.apache.james.mailets.configuration; +import java.util.Optional; + import com.google.common.base.Preconditions; import com.google.common.base.Strings; import com.google.common.collect.ImmutableList; @@ -37,7 +39,7 @@ public class ProcessorConfiguration implements SerializableAsXml { public static class Builder { private String state; - private boolean enableJmx; + private Optional<Boolean> enableJmx = Optional.empty(); private ImmutableList.Builder<MailetConfiguration> mailets; private Builder() { @@ -50,7 +52,7 @@ public class ProcessorConfiguration implements SerializableAsXml { } public Builder enableJmx(boolean enableJmx) { - this.enableJmx = enableJmx; + this.enableJmx = Optional.of(enableJmx); return this; } @@ -61,7 +63,7 @@ public class ProcessorConfiguration implements SerializableAsXml { public ProcessorConfiguration build() { Preconditions.checkState(!Strings.isNullOrEmpty(state), "'state' is mandatory"); - return new ProcessorConfiguration(state, enableJmx, mailets.build()); + return new ProcessorConfiguration(state, enableJmx.orElse(false), mailets.build()); } } --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
