JAMES-2352 Continue removing useless @see java-doc comments
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/ddc04847 Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/ddc04847 Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/ddc04847 Branch: refs/heads/master Commit: ddc04847414a72a6d97241b2e0e01a035dc957f7 Parents: 414f3e6 Author: benwa <btell...@linagora.com> Authored: Thu Mar 15 17:22:52 2018 +0700 Committer: Matthieu Baechler <matth...@apache.org> Committed: Fri Mar 16 11:13:15 2018 +0100 ---------------------------------------------------------------------- .../apache/james/mailbox/model/SearchQuery.java | 6 --- .../mailbox/jcr/mail/JCRMessageMapper.java | 11 ----- .../mailbox/jcr/mail/model/JCRProperty.java | 5 -- .../mailbox/store/SimpleMailboxMetaData.java | 12 ++--- .../store/mail/model/impl/SimpleMailbox.java | 4 +- .../james/protocols/api/AbstractResponse.java | 6 +-- .../protocols/api/CombinedInputStream.java | 10 +--- .../apache/james/protocols/api/Encryption.java | 8 ---- .../api/handler/ProtocolHandlerChainImpl.java | 40 ---------------- .../apache/james/imap/api/message/IdRange.java | 8 +--- .../imap/api/message/request/DayMonthYear.java | 8 +--- .../imap/decode/parser/SearchCommandParser.java | 4 -- .../james/imap/encode/ACLResponseEncoder.java | 9 ---- .../message/request/AbstractImapRequest.java | 4 -- .../response/ImmutableStatusResponse.java | 2 - .../imap/message/response/SearchResponse.java | 11 +---- .../james/imap/processor/IdleProcessor.java | 10 ---- .../fetch/PartialFetchBodyElement.java | 15 ------ .../imap/core/IMAPCommandDispatcher.java | 4 -- .../james/imap/processor/LSubProcessorTest.java | 10 ---- .../protocols/lmtp/AbstractLMTPServerTest.java | 12 +---- .../smtp/core/AbstractHookableCmdHandler.java | 12 ----- .../protocols/smtp/core/DataCmdHandler.java | 5 -- .../core/fastfail/MaxUnknownCmdHandlerTest.java | 4 -- .../fastfail/ResolvableEhloHeloHandlerTest.java | 8 ---- .../fastfail/ValidSenderDomainHandlerTest.java | 4 -- .../apache/james/server/core/MailHeaders.java | 6 --- ...oxConfigurationBeanFactoryPostProcessor.java | 4 -- .../lifecycle/ConfigurationProviderImpl.java | 2 - .../resource/DefaultJamesResourceLoader.java | 2 - .../util/retry/naming/RetryingContext.java | 12 ----- .../naming/directory/RetryingDirContext.java | 34 -------------- .../file/SieveFileRepository.java | 4 +- .../user/hbase/HBaseUsersRepositoryTest.java | 3 -- .../mailrepository/jdbc/JDBCMailRepository.java | 10 +--- .../mailrepository/jdbc/MessageInputStream.java | 3 -- .../jdbc/MimeMessageJDBCSource.java | 2 - .../rrt/jdbc/JDBCRecipientRewriteTableTest.java | 4 -- .../domainlist/lib/AbstractDomainList.java | 3 -- .../lib/AbstractMailRepository.java | 6 --- .../mailetcontainer/impl/JamesMailSpooler.java | 2 - .../james/transport/mailets/ToSenderFolder.java | 2 - .../mailets/jsieve/SieveMailAdapter.java | 4 +- .../org/apache/james/fetchmail/FetchMail.java | 8 +--- .../james/lmtpserver/netty/LMTPServer.java | 10 ---- .../james/smtpserver/SetMimeHeaderHandler.java | 3 -- .../james/smtpserver/fastfail/SPFHandler.java | 48 -------------------- .../james/smtpserver/netty/SMTPServer.java | 20 -------- .../apache/james/queue/file/FileMailQueue.java | 2 - 49 files changed, 20 insertions(+), 406 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/mailbox/api/src/main/java/org/apache/james/mailbox/model/SearchQuery.java ---------------------------------------------------------------------- diff --git a/mailbox/api/src/main/java/org/apache/james/mailbox/model/SearchQuery.java b/mailbox/api/src/main/java/org/apache/james/mailbox/model/SearchQuery.java index 6c11b3a..5d6977e 100644 --- a/mailbox/api/src/main/java/org/apache/james/mailbox/model/SearchQuery.java +++ b/mailbox/api/src/main/java/org/apache/james/mailbox/model/SearchQuery.java @@ -1073,17 +1073,11 @@ public class SearchQuery implements Serializable { return ALL; } - /** - * @see java.lang.Object#equals(java.lang.Object) - */ @Override public boolean equals(Object obj) { return obj instanceof AllCriterion; } - /** - * @see java.lang.Object#hashCode() - */ @Override public int hashCode() { return 1729; http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRMessageMapper.java ---------------------------------------------------------------------- diff --git a/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRMessageMapper.java b/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRMessageMapper.java index 33cb5d6..f3771a2 100644 --- a/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRMessageMapper.java +++ b/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/JCRMessageMapper.java @@ -237,12 +237,6 @@ public class JCRMessageMapper extends AbstractMessageMapper implements JCRImapCo } - /* - * (non-Javadoc) - * - * @see org.apache.james.mailbox.store.mail.MessageMapper# - * countUnseenMessagesInMailbox () - */ @Override public long countUnseenMessagesInMailbox(Mailbox mailbox) throws MailboxException { @@ -317,11 +311,6 @@ public class JCRMessageMapper extends AbstractMessageMapper implements JCRImapCo * * TODO: Maybe we should better use an ItemVisitor and just traverse through * the child nodes. This could be a way faster - * - * (non-Javadoc) - * - * @see org.apache.james.mailbox.store.mail.MessageMapper# - * findRecentMessageUidsInMailbox () */ @Override public List<MessageUid> findRecentMessageUidsInMailbox(Mailbox mailbox) throws MailboxException { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/model/JCRProperty.java ---------------------------------------------------------------------- diff --git a/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/model/JCRProperty.java b/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/model/JCRProperty.java index b939b48..0d935af 100644 --- a/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/model/JCRProperty.java +++ b/mailbox/jcr/src/main/java/org/apache/james/mailbox/jcr/mail/model/JCRProperty.java @@ -77,11 +77,6 @@ public class JCRProperty implements JCRImapConstants, Persistent, Property { return node; } - /* - * (non-Javadoc) - * - * @see org.apache.james.mailbox.store.mail.model.Property#getLocalName() - */ @Override public String getLocalName() { if (isPersistent()) { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/mailbox/store/src/main/java/org/apache/james/mailbox/store/SimpleMailboxMetaData.java ---------------------------------------------------------------------- diff --git a/mailbox/store/src/main/java/org/apache/james/mailbox/store/SimpleMailboxMetaData.java b/mailbox/store/src/main/java/org/apache/james/mailbox/store/SimpleMailboxMetaData.java index d7aefdc..1c8dca8 100644 --- a/mailbox/store/src/main/java/org/apache/james/mailbox/store/SimpleMailboxMetaData.java +++ b/mailbox/store/src/main/java/org/apache/james/mailbox/store/SimpleMailboxMetaData.java @@ -86,16 +86,12 @@ public class SimpleMailboxMetaData implements MailboxMetaData, Comparable<Mailbo return mailboxId; } - /** - * @see java.lang.Object#toString() - */ + @Override public String toString() { return "ListResult: " + path; } - /** - * @see java.lang.Object#hashCode() - */ + @Override public int hashCode() { final int PRIME = 31; int result = 1; @@ -103,9 +99,7 @@ public class SimpleMailboxMetaData implements MailboxMetaData, Comparable<Mailbo return result; } - /** - * @see java.lang.Object#equals(java.lang.Object) - */ + @Override public boolean equals(Object obj) { if (this == obj) { return true; http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/impl/SimpleMailbox.java ---------------------------------------------------------------------- diff --git a/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/impl/SimpleMailbox.java b/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/impl/SimpleMailbox.java index 85c243b..d104b2b 100644 --- a/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/impl/SimpleMailbox.java +++ b/mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/impl/SimpleMailbox.java @@ -103,9 +103,7 @@ public class SimpleMailbox implements Mailbox { return new MailboxPath(getNamespace(), getUser(), getName()); } - /** - * @see java.lang.Object#equals(java.lang.Object) - */ + @Override public boolean equals(Object obj) { if (obj instanceof SimpleMailbox) { SimpleMailbox o = (SimpleMailbox)obj; http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/api/src/main/java/org/apache/james/protocols/api/AbstractResponse.java ---------------------------------------------------------------------- diff --git a/protocols/api/src/main/java/org/apache/james/protocols/api/AbstractResponse.java b/protocols/api/src/main/java/org/apache/james/protocols/api/AbstractResponse.java index a607cad..9135d20 100644 --- a/protocols/api/src/main/java/org/apache/james/protocols/api/AbstractResponse.java +++ b/protocols/api/src/main/java/org/apache/james/protocols/api/AbstractResponse.java @@ -52,9 +52,7 @@ public abstract class AbstractResponse implements Response { this.setRetCode(code); this.appendLine(description); } - - /** * Append the responseLine to the SMTPResponse * @@ -103,9 +101,7 @@ public abstract class AbstractResponse implements Response { this.endSession = endSession; } - /** - * @see java.lang.Object#toString() - */ + @Override public final String toString() { return getLines().toString(); } http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/api/src/main/java/org/apache/james/protocols/api/CombinedInputStream.java ---------------------------------------------------------------------- diff --git a/protocols/api/src/main/java/org/apache/james/protocols/api/CombinedInputStream.java b/protocols/api/src/main/java/org/apache/james/protocols/api/CombinedInputStream.java index 31bbc71..a01f291 100644 --- a/protocols/api/src/main/java/org/apache/james/protocols/api/CombinedInputStream.java +++ b/protocols/api/src/main/java/org/apache/james/protocols/api/CombinedInputStream.java @@ -44,20 +44,12 @@ public class CombinedInputStream extends SequenceInputStream implements Iterable public Iterator<InputStream> iterator() { return new Iterator<InputStream>() { private int count = 0; - - /* - * (non-Javadoc) - * @see java.util.Iterator#hasNext() - */ + @Override public boolean hasNext() { return count < streams.length; } - /* - * (non-Javadoc) - * @see java.util.Iterator#next() - */ @Override public InputStream next() { if (hasNext()) { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/api/src/main/java/org/apache/james/protocols/api/Encryption.java ---------------------------------------------------------------------- diff --git a/protocols/api/src/main/java/org/apache/james/protocols/api/Encryption.java b/protocols/api/src/main/java/org/apache/james/protocols/api/Encryption.java index 588c974..0955670 100644 --- a/protocols/api/src/main/java/org/apache/james/protocols/api/Encryption.java +++ b/protocols/api/src/main/java/org/apache/james/protocols/api/Encryption.java @@ -37,10 +37,6 @@ public final class Encryption { this.enabledCipherSuites = enabledCipherSuites; } - /** - * - * @see #createStartTls(SSLContext, String[]) - */ public static Encryption createTls(SSLContext context) { return createTls(context, null); } @@ -58,10 +54,6 @@ public final class Encryption { return new Encryption(context, false, enabledCipherSuites); } - /** - * - * @see #createStartTls(SSLContext, String[]) - */ public static Encryption createStartTls(SSLContext context) { return createStartTls(context, null); } http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/api/src/main/java/org/apache/james/protocols/api/handler/ProtocolHandlerChainImpl.java ---------------------------------------------------------------------- diff --git a/protocols/api/src/main/java/org/apache/james/protocols/api/handler/ProtocolHandlerChainImpl.java b/protocols/api/src/main/java/org/apache/james/protocols/api/handler/ProtocolHandlerChainImpl.java index 6b01e5e..6fe802a 100644 --- a/protocols/api/src/main/java/org/apache/james/protocols/api/handler/ProtocolHandlerChainImpl.java +++ b/protocols/api/src/main/java/org/apache/james/protocols/api/handler/ProtocolHandlerChainImpl.java @@ -66,10 +66,6 @@ public class ProtocolHandlerChainImpl extends AbstractProtocolHandlerChain imple return ImmutableList.copyOf(handlers); } - /* - * (non-Javadoc) - * @see java.util.List#size() - */ @Override public int size() { return handlers.size(); @@ -214,64 +210,36 @@ public class ProtocolHandlerChainImpl extends AbstractProtocolHandlerChain imple this.handlers = handlers; } - /* - * (non-Javadoc) - * @see java.util.ListIterator#hasNext() - */ @Override public boolean hasNext() { return handlers.hasNext(); } - /* - * (non-Javadoc) - * @see java.util.ListIterator#next() - */ @Override public ProtocolHandler next() { return (ProtocolHandler) handlers.next(); } - /* - * (non-Javadoc) - * @see java.util.ListIterator#hasPrevious() - */ @Override public boolean hasPrevious() { return handlers.hasPrevious(); } - /* - * (non-Javadoc) - * @see java.util.ListIterator#previous() - */ @Override public ProtocolHandler previous() { return handlers.previous(); } - /* - * (non-Javadoc) - * @see java.util.ListIterator#nextIndex() - */ @Override public int nextIndex() { return handlers.nextIndex(); } - /* - * (non-Javadoc) - * @see java.util.ListIterator#previousIndex() - */ @Override public int previousIndex() { return handlers.previousIndex(); } - /* - * (non-Javadoc) - * @see java.util.ListIterator#remove() - */ @Override public void remove() { checkReadOnly(); @@ -279,10 +247,6 @@ public class ProtocolHandlerChainImpl extends AbstractProtocolHandlerChain imple handlers.previousIndex(); } - /* - * (non-Javadoc) - * @see java.util.ListIterator#set(java.lang.Object) - */ @Override public void set(ProtocolHandler e) { checkReadOnly(); @@ -290,10 +254,6 @@ public class ProtocolHandlerChainImpl extends AbstractProtocolHandlerChain imple handlers.set(e); } - /* - * (non-Javadoc) - * @see java.util.ListIterator#add(java.lang.Object) - */ @Override public void add(ProtocolHandler e) { checkReadOnly(); http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/imap/src/main/java/org/apache/james/imap/api/message/IdRange.java ---------------------------------------------------------------------- diff --git a/protocols/imap/src/main/java/org/apache/james/imap/api/message/IdRange.java b/protocols/imap/src/main/java/org/apache/james/imap/api/message/IdRange.java index 0b313f5..69f6d86 100644 --- a/protocols/imap/src/main/java/org/apache/james/imap/api/message/IdRange.java +++ b/protocols/imap/src/main/java/org/apache/james/imap/api/message/IdRange.java @@ -88,9 +88,7 @@ public final class IdRange implements Iterable<Long>, Comparable<IdRange> { return lowVal <= value && value <= highVal; } - /** - * @see java.lang.Object#hashCode() - */ + @Override public int hashCode() { final int PRIME = 31; int result = 1; @@ -99,9 +97,7 @@ public final class IdRange implements Iterable<Long>, Comparable<IdRange> { return result; } - /** - * @see java.lang.Object#equals(java.lang.Object) - */ + @Override public boolean equals(Object obj) { if (this == obj) { return true; http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/imap/src/main/java/org/apache/james/imap/api/message/request/DayMonthYear.java ---------------------------------------------------------------------- diff --git a/protocols/imap/src/main/java/org/apache/james/imap/api/message/request/DayMonthYear.java b/protocols/imap/src/main/java/org/apache/james/imap/api/message/request/DayMonthYear.java index f53c086..55bbcd3 100644 --- a/protocols/imap/src/main/java/org/apache/james/imap/api/message/request/DayMonthYear.java +++ b/protocols/imap/src/main/java/org/apache/james/imap/api/message/request/DayMonthYear.java @@ -88,9 +88,7 @@ public class DayMonthYear { return day + "-" + month + "-" + year; } - /** - * @see java.lang.Object#hashCode() - */ + @Override public int hashCode() { final int PRIME = 31; int result = 1; @@ -100,9 +98,7 @@ public class DayMonthYear { return result; } - /** - * @see java.lang.Object#equals(java.lang.Object) - */ + @Override public boolean equals(Object obj) { if (this == obj) { return true; http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/SearchCommandParser.java ---------------------------------------------------------------------- diff --git a/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/SearchCommandParser.java b/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/SearchCommandParser.java index 2e4fc37..1724e73 100644 --- a/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/SearchCommandParser.java +++ b/protocols/imap/src/main/java/org/apache/james/imap/decode/parser/SearchCommandParser.java @@ -142,10 +142,6 @@ public class SearchCommandParser extends AbstractUidCommandParser { // Just consume the [<entry-name> <entry-type-req>] and ignore it // See RFC4551 3.4. MODSEQ Search Criterion in SEARCH request.consumeQuoted(); - /* - * (non-Javadoc) - * @see org.apache.james.imap.decode.ImapRequestLineReader.CharacterValidator#isValid(char) - */ request.consumeWord(chr -> true); return SearchKey.buildModSeq(request.number()); } http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/imap/src/main/java/org/apache/james/imap/encode/ACLResponseEncoder.java ---------------------------------------------------------------------- diff --git a/protocols/imap/src/main/java/org/apache/james/imap/encode/ACLResponseEncoder.java b/protocols/imap/src/main/java/org/apache/james/imap/encode/ACLResponseEncoder.java index dd5a4f0..09f05a4 100644 --- a/protocols/imap/src/main/java/org/apache/james/imap/encode/ACLResponseEncoder.java +++ b/protocols/imap/src/main/java/org/apache/james/imap/encode/ACLResponseEncoder.java @@ -41,15 +41,6 @@ public class ACLResponseEncoder extends AbstractChainedImapEncoder { super(next); } - /* - * (non-Javadoc) - * - * @see - * org.apache.james.imap.encode.base.AbstractChainedImapEncoder#doEncode - * (org.apache.james.imap.api.ImapMessage, - * org.apache.james.imap.encode.ImapResponseComposer, - * org.apache.james.imap.api.process.ImapSession) - */ @Override protected void doEncode(ImapMessage acceptableMessage, ImapResponseComposer composer, ImapSession session) throws IOException { final ACLResponse aclResponse = (ACLResponse) acceptableMessage; http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/imap/src/main/java/org/apache/james/imap/message/request/AbstractImapRequest.java ---------------------------------------------------------------------- diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/request/AbstractImapRequest.java b/protocols/imap/src/main/java/org/apache/james/imap/message/request/AbstractImapRequest.java index 0198181..da0474a 100644 --- a/protocols/imap/src/main/java/org/apache/james/imap/message/request/AbstractImapRequest.java +++ b/protocols/imap/src/main/java/org/apache/james/imap/message/request/AbstractImapRequest.java @@ -37,8 +37,6 @@ public abstract class AbstractImapRequest implements ImapRequest { /** * Gets the IMAP command whose execution is requested by the client. - * - * @see org.apache.james.imap.api.message.request.ImapRequest#getCommand() */ @Override public final ImapCommand getCommand() { @@ -47,8 +45,6 @@ public abstract class AbstractImapRequest implements ImapRequest { /** * Gets the prefix tag identifying this request. - * - * @see org.apache.james.imap.api.message.request.ImapRequest#getTag() */ @Override public final String getTag() { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/imap/src/main/java/org/apache/james/imap/message/response/ImmutableStatusResponse.java ---------------------------------------------------------------------- diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/response/ImmutableStatusResponse.java b/protocols/imap/src/main/java/org/apache/james/imap/message/response/ImmutableStatusResponse.java index 5ab2d7d..fcfbe29 100644 --- a/protocols/imap/src/main/java/org/apache/james/imap/message/response/ImmutableStatusResponse.java +++ b/protocols/imap/src/main/java/org/apache/james/imap/message/response/ImmutableStatusResponse.java @@ -27,8 +27,6 @@ import com.google.common.base.MoreObjects; /** * Immutable status response. Suitable for unpooled usage. - * - * @see StatusResponse */ public class ImmutableStatusResponse implements StatusResponse { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/imap/src/main/java/org/apache/james/imap/message/response/SearchResponse.java ---------------------------------------------------------------------- diff --git a/protocols/imap/src/main/java/org/apache/james/imap/message/response/SearchResponse.java b/protocols/imap/src/main/java/org/apache/james/imap/message/response/SearchResponse.java index c8c9398..b2443b3 100644 --- a/protocols/imap/src/main/java/org/apache/james/imap/message/response/SearchResponse.java +++ b/protocols/imap/src/main/java/org/apache/james/imap/message/response/SearchResponse.java @@ -60,20 +60,13 @@ public class SearchResponse implements ImapResponseMessage { public final Long getHighestModSeq() { return highestModSeq; } - - /** - * @see java.lang.Object#hashCode() - */ - // @Override + @Override public int hashCode() { return ids.length; } - /** - * @see java.lang.Object#equals(java.lang.Object) - */ - // @Override + @Override public boolean equals(Object obj) { if (this == obj) { return true; http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/imap/src/main/java/org/apache/james/imap/processor/IdleProcessor.java ---------------------------------------------------------------------- diff --git a/protocols/imap/src/main/java/org/apache/james/imap/processor/IdleProcessor.java b/protocols/imap/src/main/java/org/apache/james/imap/processor/IdleProcessor.java index f5a4c9d..56e5a06 100644 --- a/protocols/imap/src/main/java/org/apache/james/imap/processor/IdleProcessor.java +++ b/protocols/imap/src/main/java/org/apache/james/imap/processor/IdleProcessor.java @@ -101,12 +101,6 @@ public class IdleProcessor extends AbstractMailboxProcessor<IdleRequest> impleme final AtomicBoolean idleActive = new AtomicBoolean(true); session.pushLineHandler(new ImapLineHandler() { - - /** - * @see - * org.apache.james.imap.api.process.ImapLineHandler - * #onLine(org.apache.james.imap.api.process.ImapSession, byte[]) - */ @Override public void onLine(ImapSession session, byte[] data) { String line; @@ -174,10 +168,6 @@ public class IdleProcessor extends AbstractMailboxProcessor<IdleRequest> impleme } } - /** - * @see org.apache.james.imap.processor.CapabilityImplementingProcessor - * #getImplementedCapabilities(org.apache.james.imap.api.process.ImapSession) - */ @Override public List<String> getImplementedCapabilities(ImapSession session) { return CAPS; http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/imap/src/main/java/org/apache/james/imap/processor/fetch/PartialFetchBodyElement.java ---------------------------------------------------------------------- diff --git a/protocols/imap/src/main/java/org/apache/james/imap/processor/fetch/PartialFetchBodyElement.java b/protocols/imap/src/main/java/org/apache/james/imap/processor/fetch/PartialFetchBodyElement.java index e8ff860..29905c0 100644 --- a/protocols/imap/src/main/java/org/apache/james/imap/processor/fetch/PartialFetchBodyElement.java +++ b/protocols/imap/src/main/java/org/apache/james/imap/processor/fetch/PartialFetchBodyElement.java @@ -106,9 +106,6 @@ final class PartialFetchBodyElement implements BodyElement { } } - /** - * @see java.io.FilterInputStream#read() - */ @Override public int read() throws IOException { checkOffset(); @@ -119,17 +116,11 @@ final class PartialFetchBodyElement implements BodyElement { return super.read(); } - /** - * @see java.io.FilterInputStream#read(byte[]) - */ @Override public int read(byte[] b) throws IOException { return read(b, 0, b.length); } - /** - * @see java.io.FilterInputStream#read(byte[], int, int) - */ @Override public int read(byte[] b, int off, int len) throws IOException { checkOffset(); @@ -150,17 +141,11 @@ final class PartialFetchBodyElement implements BodyElement { } - /** - * Throws {@link IOException} - */ @Override public long skip(long n) throws IOException { throw new IOException("Not implemented"); } - /** - * @see java.io.FilterInputStream#available() - */ @Override public int available() throws IOException { // Correctly calculate in available bytes. http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/imap/src/main/java/org/apache/james/protocols/imap/core/IMAPCommandDispatcher.java ---------------------------------------------------------------------- diff --git a/protocols/imap/src/main/java/org/apache/james/protocols/imap/core/IMAPCommandDispatcher.java b/protocols/imap/src/main/java/org/apache/james/protocols/imap/core/IMAPCommandDispatcher.java index 8093f78..45afc5c 100644 --- a/protocols/imap/src/main/java/org/apache/james/protocols/imap/core/IMAPCommandDispatcher.java +++ b/protocols/imap/src/main/java/org/apache/james/protocols/imap/core/IMAPCommandDispatcher.java @@ -57,10 +57,6 @@ public class IMAPCommandDispatcher extends CommandDispatcher<IMAPSession> { } - /* - * (non-Javadoc) - * @see org.apache.james.protocols.api.handler.MultiLineHandler#isReady(org.apache.james.protocols.api.ProtocolSession, java.nio.ByteBuffer) - */ @Override protected boolean isReady(IMAPSession session, ByteBuffer line) { long bytesRead = (Long) session.setAttachment(BYTES_READ, null, State.Transaction); http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/imap/src/test/java/org/apache/james/imap/processor/LSubProcessorTest.java ---------------------------------------------------------------------- diff --git a/protocols/imap/src/test/java/org/apache/james/imap/processor/LSubProcessorTest.java b/protocols/imap/src/test/java/org/apache/james/imap/processor/LSubProcessorTest.java index 7a377a3..67d7414 100644 --- a/protocols/imap/src/test/java/org/apache/james/imap/processor/LSubProcessorTest.java +++ b/protocols/imap/src/test/java/org/apache/james/imap/processor/LSubProcessorTest.java @@ -67,26 +67,16 @@ public class LSubProcessorTest { private static final String TAG = "TAG"; public static final MailboxSession.User USER = new MailboxSession.User() { - - /** - * @see MailboxSession.User#getLocalePreferences() - */ @Override public List<Locale> getLocalePreferences() { return new ArrayList<>(); } - /** - * @see MailboxSession.User#getPassword() - */ @Override public String getPassword() { return "test"; } - /** - * @see MailboxSession.User#getUserName() - */ @Override public String getUserName() { return "test"; http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/lmtp/src/test/java/org/apache/james/protocols/lmtp/AbstractLMTPServerTest.java ---------------------------------------------------------------------- diff --git a/protocols/lmtp/src/test/java/org/apache/james/protocols/lmtp/AbstractLMTPServerTest.java b/protocols/lmtp/src/test/java/org/apache/james/protocols/lmtp/AbstractLMTPServerTest.java index ee05ced..2667642 100644 --- a/protocols/lmtp/src/test/java/org/apache/james/protocols/lmtp/AbstractLMTPServerTest.java +++ b/protocols/lmtp/src/test/java/org/apache/james/protocols/lmtp/AbstractLMTPServerTest.java @@ -317,11 +317,7 @@ public abstract class AbstractLMTPServerTest extends AbstractSMTPServerTest { public MessageHookAdapter(MessageHook hook) { this.hook = hook; } - - /* - * (non-Javadoc) - * @see org.apache.james.protocols.lmtp.hook.DeliverToRecipientHook#deliver(org.apache.james.protocols.smtp.SMTPSession, org.apache.james.protocols.smtp.MailAddress, org.apache.james.protocols.smtp.MailEnvelope) - */ + @Override public HookResult deliver(SMTPSession session, MailAddress recipient, MailEnvelope envelope) { if (result == null) { @@ -344,11 +340,7 @@ public abstract class AbstractLMTPServerTest extends AbstractSMTPServerTest { private final class TestDeliverHook implements DeliverToRecipientHook { private final List<MailEnvelope> delivered = new ArrayList<>(); - - /* - * (non-Javadoc) - * @see org.apache.james.protocols.lmtp.hook.DeliverToRecipientHook#deliver(org.apache.james.protocols.smtp.SMTPSession, org.apache.james.protocols.smtp.MailAddress, org.apache.james.protocols.smtp.MailEnvelope) - */ + @Override public HookResult deliver(SMTPSession session, MailAddress recipient, MailEnvelope envelope) { if (RCPT1.equals(recipient.toString())) { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/AbstractHookableCmdHandler.java ---------------------------------------------------------------------- diff --git a/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/AbstractHookableCmdHandler.java b/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/AbstractHookableCmdHandler.java index 9e6d96c..e7063f2 100644 --- a/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/AbstractHookableCmdHandler.java +++ b/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/AbstractHookableCmdHandler.java @@ -129,28 +129,16 @@ public abstract class AbstractHookableCmdHandler<HookT extends org.apache.james. if ((hRes.getResult() & HookReturnCode.DISCONNECT) == HookReturnCode.DISCONNECT) { return new Response() { - /* - * (non-Javadoc) - * @see org.apache.james.protocols.api.Response#isEndSession() - */ @Override public boolean isEndSession() { return true; } - /* - * (non-Javadoc) - * @see org.apache.james.protocols.api.Response#getRetCode() - */ @Override public String getRetCode() { return response.getRetCode(); } - /* - * (non-Javadoc) - * @see org.apache.james.protocols.api.Response#getLines() - */ @Override public List<CharSequence> getLines() { return response.getLines(); http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/DataCmdHandler.java ---------------------------------------------------------------------- diff --git a/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/DataCmdHandler.java b/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/DataCmdHandler.java index 081acd2..d16639c 100644 --- a/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/DataCmdHandler.java +++ b/protocols/smtp/src/main/java/org/apache/james/protocols/smtp/core/DataCmdHandler.java @@ -94,12 +94,7 @@ public class DataCmdHandler implements CommandHandler<SMTPSession>, ExtensibleHa this.filter = filter; this.next = next; } - - /* - * (non-Javadoc) - * @see org.apache.james.protocols.api.handler.LineHandler#onLine(org.apache.james.protocols.api.ProtocolSession, java.nio.ByteBuffer) - */ @Override public Response onLine(SMTPSession session, ByteBuffer line) { line.rewind(); http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/core/fastfail/MaxUnknownCmdHandlerTest.java ---------------------------------------------------------------------- diff --git a/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/core/fastfail/MaxUnknownCmdHandlerTest.java b/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/core/fastfail/MaxUnknownCmdHandlerTest.java index 321d65c..81851c1 100644 --- a/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/core/fastfail/MaxUnknownCmdHandlerTest.java +++ b/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/core/fastfail/MaxUnknownCmdHandlerTest.java @@ -57,10 +57,6 @@ public class MaxUnknownCmdHandlerTest { } } - /* - * (non-Javadoc) - * @see org.apache.james.protocols.api.ProtocolSession#getAttachment(java.lang.String, org.apache.james.protocols.api.ProtocolSession.State) - */ @Override public Object getAttachment(String key, State state) { if (state == State.Connection) { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/core/fastfail/ResolvableEhloHeloHandlerTest.java ---------------------------------------------------------------------- diff --git a/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/core/fastfail/ResolvableEhloHeloHandlerTest.java b/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/core/fastfail/ResolvableEhloHeloHandlerTest.java index d633bf8..4e21a21 100644 --- a/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/core/fastfail/ResolvableEhloHeloHandlerTest.java +++ b/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/core/fastfail/ResolvableEhloHeloHandlerTest.java @@ -75,10 +75,6 @@ public class ResolvableEhloHeloHandlerTest { return map; } - /* - * (non-Javadoc) - * @see org.apache.james.protocols.api.ProtocolSession#setAttachment(java.lang.String, java.lang.Object, org.apache.james.protocols.api.ProtocolSession.State) - */ @Override public Object setAttachment(String key, Object value, State state) { if (state == State.Connection) { @@ -96,10 +92,6 @@ public class ResolvableEhloHeloHandlerTest { } } - /* - * (non-Javadoc) - * @see org.apache.james.protocols.api.ProtocolSession#getAttachment(java.lang.String, org.apache.james.protocols.api.ProtocolSession.State) - */ @Override public Object getAttachment(String key, State state) { if (state == State.Connection) { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/core/fastfail/ValidSenderDomainHandlerTest.java ---------------------------------------------------------------------- diff --git a/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/core/fastfail/ValidSenderDomainHandlerTest.java b/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/core/fastfail/ValidSenderDomainHandlerTest.java index b1dd3b5..bebe107 100644 --- a/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/core/fastfail/ValidSenderDomainHandlerTest.java +++ b/protocols/smtp/src/test/java/org/apache/james/protocols/smtp/core/fastfail/ValidSenderDomainHandlerTest.java @@ -89,10 +89,6 @@ public class ValidSenderDomainHandlerTest { } } - /* - * (non-Javadoc) - * @see org.apache.james.protocols.api.ProtocolSession#getAttachment(java.lang.String, org.apache.james.protocols.api.ProtocolSession.State) - */ @Override public Object getAttachment(String key, State state) { if (state == State.Connection) { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/container/core/src/main/java/org/apache/james/server/core/MailHeaders.java ---------------------------------------------------------------------- diff --git a/server/container/core/src/main/java/org/apache/james/server/core/MailHeaders.java b/server/container/core/src/main/java/org/apache/james/server/core/MailHeaders.java index 296042c..7847bcd 100644 --- a/server/container/core/src/main/java/org/apache/james/server/core/MailHeaders.java +++ b/server/container/core/src/main/java/org/apache/james/server/core/MailHeaders.java @@ -105,9 +105,6 @@ public class MailHeaders extends InternetHeaders implements Serializable, Clonea * If the new header is a Return-Path we get sure that we add it to the top * Javamail, at least until 1.4.0 does the wrong thing if it loaded a stream * with a return-path in the middle. - * - * @see javax.mail.internet.InternetHeaders#addHeader(java.lang.String, - * java.lang.String) */ @Override public synchronized void addHeader(String arg0, String arg1) { @@ -123,9 +120,6 @@ public class MailHeaders extends InternetHeaders implements Serializable, Clonea * If the new header is a Return-Path we get sure that we add it to the top * Javamail, at least until 1.4.0 does the wrong thing if it loaded a stream * with a return-path in the middle. - * - * @see javax.mail.internet.InternetHeaders#setHeader(java.lang.String, - * java.lang.String) */ @Override public synchronized void setHeader(String arg0, String arg1) { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/container/spring/src/main/java/org/apache/james/container/spring/bean/factorypostprocessor/MailboxConfigurationBeanFactoryPostProcessor.java ---------------------------------------------------------------------- diff --git a/server/container/spring/src/main/java/org/apache/james/container/spring/bean/factorypostprocessor/MailboxConfigurationBeanFactoryPostProcessor.java b/server/container/spring/src/main/java/org/apache/james/container/spring/bean/factorypostprocessor/MailboxConfigurationBeanFactoryPostProcessor.java index dd81722..4cbc9ad 100644 --- a/server/container/spring/src/main/java/org/apache/james/container/spring/bean/factorypostprocessor/MailboxConfigurationBeanFactoryPostProcessor.java +++ b/server/container/spring/src/main/java/org/apache/james/container/spring/bean/factorypostprocessor/MailboxConfigurationBeanFactoryPostProcessor.java @@ -38,10 +38,6 @@ import com.google.common.collect.ImmutableSet; * It will register it with the alias mailboxmanager */ public class MailboxConfigurationBeanFactoryPostProcessor implements BeanFactoryPostProcessor { - /** - * @see org.springframework.beans.factory.config.BeanFactoryPostProcessor#postProcessBeanFactory - * (org.springframework.beans.factory.config.ConfigurableListableBeanFactory) - */ private static final String JPA_MAILBOXMANAGER = "jpa-mailboxmanager"; private static final String MEMORY_MAILBOX_MANAGER = "memory-mailboxManager"; http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/ConfigurationProviderImpl.java ---------------------------------------------------------------------- diff --git a/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/ConfigurationProviderImpl.java b/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/ConfigurationProviderImpl.java index 0e26e36..20b6d65 100644 --- a/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/ConfigurationProviderImpl.java +++ b/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/ConfigurationProviderImpl.java @@ -72,8 +72,6 @@ public class ConfigurationProviderImpl implements ConfigurationProvider, Resourc /** * Responsible to register additional configurations for the injected * configurationMappings. - * - * @see org.springframework.beans.factory.InitializingBean#afterPropertiesSet() */ @Override public void afterPropertiesSet() throws Exception { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/container/spring/src/main/java/org/apache/james/container/spring/resource/DefaultJamesResourceLoader.java ---------------------------------------------------------------------- diff --git a/server/container/spring/src/main/java/org/apache/james/container/spring/resource/DefaultJamesResourceLoader.java b/server/container/spring/src/main/java/org/apache/james/container/spring/resource/DefaultJamesResourceLoader.java index e86a5fd..cec07a6 100644 --- a/server/container/spring/src/main/java/org/apache/james/container/spring/resource/DefaultJamesResourceLoader.java +++ b/server/container/spring/src/main/java/org/apache/james/container/spring/resource/DefaultJamesResourceLoader.java @@ -43,8 +43,6 @@ public class DefaultJamesResourceLoader extends DefaultResourceLoader implements /** * Return the {@link Resource} for the given url. If the resource can not be * found null get returned - * - * @see org.springframework.core.io.ResourceLoader#getResource(java.lang.String) */ @Override public Resource getResource(String fileURL) { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/container/util/src/main/java/org/apache/james/util/retry/naming/RetryingContext.java ---------------------------------------------------------------------- diff --git a/server/container/util/src/main/java/org/apache/james/util/retry/naming/RetryingContext.java b/server/container/util/src/main/java/org/apache/james/util/retry/naming/RetryingContext.java index e3e5476..37fc065 100644 --- a/server/container/util/src/main/java/org/apache/james/util/retry/naming/RetryingContext.java +++ b/server/container/util/src/main/java/org/apache/james/util/retry/naming/RetryingContext.java @@ -276,9 +276,6 @@ public abstract class RetryingContext implements Context, ExceptionRetryingProxy }.perform(); } - /** - * @see javax.naming.Context#list(javax.naming.Name) - */ @SuppressWarnings("unchecked") @Override public NamingEnumeration<NameClassPair> list(final Name name) throws NamingException { @@ -292,9 +289,6 @@ public abstract class RetryingContext implements Context, ExceptionRetryingProxy }.perform(); } - /** - * @see javax.naming.Context#list(java.lang.String) - */ @SuppressWarnings("unchecked") @Override public NamingEnumeration<NameClassPair> list(final String name) throws NamingException { @@ -308,9 +302,6 @@ public abstract class RetryingContext implements Context, ExceptionRetryingProxy }.perform(); } - /** - * @see javax.naming.Context#listBindings(javax.naming.Name) - */ @SuppressWarnings("unchecked") @Override public NamingEnumeration<Binding> listBindings(final Name name) throws NamingException { @@ -324,9 +315,6 @@ public abstract class RetryingContext implements Context, ExceptionRetryingProxy }.perform(); } - /** - * @see javax.naming.Context#listBindings(java.lang.String) - */ @SuppressWarnings("unchecked") @Override public NamingEnumeration<Binding> listBindings(final String name) throws NamingException { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/container/util/src/main/java/org/apache/james/util/retry/naming/directory/RetryingDirContext.java ---------------------------------------------------------------------- diff --git a/server/container/util/src/main/java/org/apache/james/util/retry/naming/directory/RetryingDirContext.java b/server/container/util/src/main/java/org/apache/james/util/retry/naming/directory/RetryingDirContext.java index 32c0004..d630a8c 100644 --- a/server/container/util/src/main/java/org/apache/james/util/retry/naming/directory/RetryingDirContext.java +++ b/server/container/util/src/main/java/org/apache/james/util/retry/naming/directory/RetryingDirContext.java @@ -284,10 +284,6 @@ public abstract class RetryingDirContext extends RetryingContext implements DirC }.perform(); } - /** - * @see javax.naming.directory.DirContext#search(javax.naming.Name, - * javax.naming.directory.Attributes) - */ @SuppressWarnings("unchecked") @Override public NamingEnumeration<SearchResult> search(final Name name, @@ -303,10 +299,6 @@ public abstract class RetryingDirContext extends RetryingContext implements DirC }.perform(); } - /** - * @see javax.naming.directory.DirContext#search(java.lang.String, - * javax.naming.directory.Attributes) - */ @SuppressWarnings("unchecked") @Override public NamingEnumeration<SearchResult> search(final String name, @@ -322,10 +314,6 @@ public abstract class RetryingDirContext extends RetryingContext implements DirC }.perform(); } - /** - * @see javax.naming.directory.DirContext#search(javax.naming.Name, - * javax.naming.directory.Attributes, java.lang.String[]) - */ @SuppressWarnings("unchecked") @Override public NamingEnumeration<SearchResult> search(final Name name, @@ -341,10 +329,6 @@ public abstract class RetryingDirContext extends RetryingContext implements DirC }.perform(); } - /** - * @see javax.naming.directory.DirContext#search(java.lang.String, - * javax.naming.directory.Attributes, java.lang.String[]) - */ @SuppressWarnings("unchecked") @Override public NamingEnumeration<SearchResult> search(final String name, @@ -361,10 +345,6 @@ public abstract class RetryingDirContext extends RetryingContext implements DirC }.perform(); } - /** - * @see javax.naming.directory.DirContext#search(javax.naming.Name, - * java.lang.String, javax.naming.directory.SearchControls) - */ @SuppressWarnings("unchecked") @Override public NamingEnumeration<SearchResult> search(final Name name, final String filter, @@ -380,10 +360,6 @@ public abstract class RetryingDirContext extends RetryingContext implements DirC }.perform(); } - /** - * @see javax.naming.directory.DirContext#search(java.lang.String, - * java.lang.String, javax.naming.directory.SearchControls) - */ @SuppressWarnings("unchecked") @Override public NamingEnumeration<SearchResult> search(final String name, final String filter, @@ -399,11 +375,6 @@ public abstract class RetryingDirContext extends RetryingContext implements DirC }.perform(); } - /** - * @see javax.naming.directory.DirContext#search(javax.naming.Name, - * java.lang.String, java.lang.Object[], - * javax.naming.directory.SearchControls) - */ @SuppressWarnings("unchecked") @Override public NamingEnumeration<SearchResult> search(final Name name, final String filterExpr, @@ -418,11 +389,6 @@ public abstract class RetryingDirContext extends RetryingContext implements DirC }.perform(); } - /** - * @see javax.naming.directory.DirContext#search(java.lang.String, - * java.lang.String, java.lang.Object[], - * javax.naming.directory.SearchControls) - */ @SuppressWarnings("unchecked") @Override public NamingEnumeration<SearchResult> search(final String name, final String filterExpr, http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/data/data-file/src/main/java/org/apache/james/sieverepository/file/SieveFileRepository.java ---------------------------------------------------------------------- diff --git a/server/data/data-file/src/main/java/org/apache/james/sieverepository/file/SieveFileRepository.java b/server/data/data-file/src/main/java/org/apache/james/sieverepository/file/SieveFileRepository.java index 54984aa..400cad5 100644 --- a/server/data/data-file/src/main/java/org/apache/james/sieverepository/file/SieveFileRepository.java +++ b/server/data/data-file/src/main/java/org/apache/james/sieverepository/file/SieveFileRepository.java @@ -171,10 +171,8 @@ public class SieveFileRepository implements SieveRepository { /** * The default quota, if any, is stored in file '.quota' in the sieve root directory. Quotas for * specific users are stored in file '.quota' in the user's directory. - * <p/> - * <p>The '.quota' file contains a single positive integer value representing the quota in octets. * - * @see SieveRepository#haveSpace(java.lang.String, java.lang.String, long) + * The '.quota' file contains a single positive integer value representing the quota in octets. */ @Override public void haveSpace(String user, String name, long size) throws QuotaExceededException, StorageException { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/data/data-hbase/src/test/java/org/apache/james/user/hbase/HBaseUsersRepositoryTest.java ---------------------------------------------------------------------- diff --git a/server/data/data-hbase/src/test/java/org/apache/james/user/hbase/HBaseUsersRepositoryTest.java b/server/data/data-hbase/src/test/java/org/apache/james/user/hbase/HBaseUsersRepositoryTest.java index 4099a3e..4647a76 100644 --- a/server/data/data-hbase/src/test/java/org/apache/james/user/hbase/HBaseUsersRepositoryTest.java +++ b/server/data/data-hbase/src/test/java/org/apache/james/user/hbase/HBaseUsersRepositoryTest.java @@ -47,9 +47,6 @@ public class HBaseUsersRepositoryTest extends AbstractUsersRepositoryTest { TablePool.getInstance(cluster.getConf()); } - /** - * @see org.apache.james.user.lib.AbstractUsersRepositoryTest#setUp() - */ @Before @Override public void setUp() throws Exception { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/JDBCMailRepository.java ---------------------------------------------------------------------- diff --git a/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/JDBCMailRepository.java b/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/JDBCMailRepository.java index 9ce7211..dae0b7b 100644 --- a/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/JDBCMailRepository.java +++ b/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/JDBCMailRepository.java @@ -757,9 +757,7 @@ public class JDBCMailRepository extends AbstractMailRepository { return datasource.getConnection(); } - /** - * @see java.lang.Object#equals(Object) - */ + @Override public boolean equals(Object obj) { if (!(obj instanceof JDBCMailRepository)) { return false; @@ -770,11 +768,7 @@ public class JDBCMailRepository extends AbstractMailRepository { return ((repository.tableName.equals(tableName)) || ((repository.tableName != null) && repository.tableName.equals(tableName))) && ((repository.repositoryName.equals(repositoryName)) || ((repository.repositoryName != null) && repository.repositoryName.equals(repositoryName))); } - /** - * Provide a hash code that is consistent with equals for this class - * - * @return the hash code - */ + @Override public int hashCode() { int result = 17; if (tableName != null) { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/MessageInputStream.java ---------------------------------------------------------------------- diff --git a/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/MessageInputStream.java b/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/MessageInputStream.java index fdba5f1..b4fb725 100644 --- a/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/MessageInputStream.java +++ b/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/MessageInputStream.java @@ -196,9 +196,6 @@ final class MessageInputStream extends InputStream { throw (IOException) caughtException; } else { throw new IOException("Exception caugth in worker thread " + caughtException.getMessage()) { - /** - * @see java.lang.Throwable#getCause() - */ @Override public Throwable getCause() { return caughtException; http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/MimeMessageJDBCSource.java ---------------------------------------------------------------------- diff --git a/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/MimeMessageJDBCSource.java b/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/MimeMessageJDBCSource.java index 8f64a80..953ebe2 100644 --- a/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/MimeMessageJDBCSource.java +++ b/server/data/data-jdbc/src/main/java/org/apache/james/mailrepository/jdbc/MimeMessageJDBCSource.java @@ -117,8 +117,6 @@ public class MimeMessageJDBCSource extends MimeMessageSource { * This should be smart enough to work even if the file does not exist. This * is to support a repository with the entire message in the database, which * is how James 1.2 worked. - * - * @see org.apache.james.server.core.MimeMessageSource#getInputStream() */ @Override public synchronized InputStream getInputStream() throws IOException { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/data/data-jdbc/src/test/java/org/apache/james/rrt/jdbc/JDBCRecipientRewriteTableTest.java ---------------------------------------------------------------------- diff --git a/server/data/data-jdbc/src/test/java/org/apache/james/rrt/jdbc/JDBCRecipientRewriteTableTest.java b/server/data/data-jdbc/src/test/java/org/apache/james/rrt/jdbc/JDBCRecipientRewriteTableTest.java index fcf2132..6549074 100644 --- a/server/data/data-jdbc/src/test/java/org/apache/james/rrt/jdbc/JDBCRecipientRewriteTableTest.java +++ b/server/data/data-jdbc/src/test/java/org/apache/james/rrt/jdbc/JDBCRecipientRewriteTableTest.java @@ -45,10 +45,6 @@ public class JDBCRecipientRewriteTableTest extends AbstractRecipientRewriteTable super.tearDown(); } - - /** - * @see org.apache.james.rrt.lib.AbstractRecipientRewriteTableTest#getRecipientRewriteTable() - */ @SuppressWarnings("deprecation") @Override protected AbstractRecipientRewriteTable getRecipientRewriteTable() throws Exception { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/data/data-library/src/main/java/org/apache/james/domainlist/lib/AbstractDomainList.java ---------------------------------------------------------------------- diff --git a/server/data/data-library/src/main/java/org/apache/james/domainlist/lib/AbstractDomainList.java b/server/data/data-library/src/main/java/org/apache/james/domainlist/lib/AbstractDomainList.java index c104024..e448492 100644 --- a/server/data/data-library/src/main/java/org/apache/james/domainlist/lib/AbstractDomainList.java +++ b/server/data/data-library/src/main/java/org/apache/james/domainlist/lib/AbstractDomainList.java @@ -210,9 +210,6 @@ public abstract class AbstractDomainList implements DomainList, Configurable { .distinct(); } - /** - * @see #getDomainsIP(List, DNSService, Logger) - */ private static Stream<String> getDomainIpStream(String domain, DNSService dns, Logger log) { try { return dns.getAllByName(domain).stream() http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/data/data-library/src/main/java/org/apache/james/mailrepository/lib/AbstractMailRepository.java ---------------------------------------------------------------------- diff --git a/server/data/data-library/src/main/java/org/apache/james/mailrepository/lib/AbstractMailRepository.java b/server/data/data-library/src/main/java/org/apache/james/mailrepository/lib/AbstractMailRepository.java index b00bcac..bc9b813 100644 --- a/server/data/data-library/src/main/java/org/apache/james/mailrepository/lib/AbstractMailRepository.java +++ b/server/data/data-library/src/main/java/org/apache/james/mailrepository/lib/AbstractMailRepository.java @@ -120,9 +120,6 @@ public abstract class AbstractMailRepository implements MailRepository, Configur } } - /** - * @see #store(Mail) - */ protected abstract void internalStore(Mail mc) throws MessagingException, IOException; @Override @@ -151,9 +148,6 @@ public abstract class AbstractMailRepository implements MailRepository, Configur } } - /** - * @see #remove(String) - */ protected abstract void internalRemove(String key) throws MessagingException; @Override http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/JamesMailSpooler.java ---------------------------------------------------------------------- diff --git a/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/JamesMailSpooler.java b/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/JamesMailSpooler.java index f9b6a0b..4100533 100644 --- a/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/JamesMailSpooler.java +++ b/server/mailet/mailetcontainer-camel/src/main/java/org/apache/james/mailetcontainer/impl/JamesMailSpooler.java @@ -202,8 +202,6 @@ public class JamesMailSpooler implements Runnable, Disposable, Configurable, Mai * <p/> * This implementation shuts down the LinearProcessors managed by this * JamesSpoolManager - * - * @see org.apache.james.lifecycle.api.Disposable#dispose() */ @PreDestroy @Override http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/ToSenderFolder.java ---------------------------------------------------------------------- diff --git a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/ToSenderFolder.java b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/ToSenderFolder.java index ffaf1f6..10e52ea 100644 --- a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/ToSenderFolder.java +++ b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/ToSenderFolder.java @@ -67,8 +67,6 @@ public class ToSenderFolder extends GenericMailet { /** * Delivers a mail to a local mailbox in a given folder. - * - * @see org.apache.mailet.base.GenericMailet#service(org.apache.mailet.Mail) */ @Override public void service(Mail mail) throws MessagingException { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/jsieve/SieveMailAdapter.java ---------------------------------------------------------------------- diff --git a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/jsieve/SieveMailAdapter.java b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/jsieve/SieveMailAdapter.java index 6ec17af..82b236d 100644 --- a/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/jsieve/SieveMailAdapter.java +++ b/server/mailet/mailets/src/main/java/org/apache/james/transport/mailets/jsieve/SieveMailAdapter.java @@ -314,9 +314,7 @@ public class SieveMailAdapter implements MailAdapter, EnvelopeAccessors, ActionC fieldMailetContext = mailetContext; } - /** - * @see java.lang.Object#toString() - */ + @Override public String toString() { String messageID = null; try { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/protocols/fetchmail/src/main/java/org/apache/james/fetchmail/FetchMail.java ---------------------------------------------------------------------- diff --git a/server/protocols/fetchmail/src/main/java/org/apache/james/fetchmail/FetchMail.java b/server/protocols/fetchmail/src/main/java/org/apache/james/fetchmail/FetchMail.java index 5cd5279..82d8dd7 100644 --- a/server/protocols/fetchmail/src/main/java/org/apache/james/fetchmail/FetchMail.java +++ b/server/protocols/fetchmail/src/main/java/org/apache/james/fetchmail/FetchMail.java @@ -112,16 +112,12 @@ public class FetchMail implements Runnable, Configurable { setSequenceNumber(sequenceNumber); } - /** - * @see java.lang.Object#equals(Object) - */ + @Override public boolean equals(Object obj) { return null != obj && obj.getClass() == getClass() && (getUserName().equals(((DynamicAccountKey) obj).getUserName()) && getSequenceNumber() == ((DynamicAccountKey) obj).getSequenceNumber()); } - /** - * @see java.lang.Object#hashCode() - */ + @Override public int hashCode() { return getUserName().hashCode() ^ getSequenceNumber(); } http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/protocols/protocols-lmtp/src/main/java/org/apache/james/lmtpserver/netty/LMTPServer.java ---------------------------------------------------------------------- diff --git a/server/protocols/protocols-lmtp/src/main/java/org/apache/james/lmtpserver/netty/LMTPServer.java b/server/protocols/protocols-lmtp/src/main/java/org/apache/james/lmtpserver/netty/LMTPServer.java index 89f3f1a..68b259d 100644 --- a/server/protocols/protocols-lmtp/src/main/java/org/apache/james/lmtpserver/netty/LMTPServer.java +++ b/server/protocols/protocols-lmtp/src/main/java/org/apache/james/lmtpserver/netty/LMTPServer.java @@ -85,26 +85,16 @@ public class LMTPServer extends AbstractProtocolAsyncServer implements LMTPServe */ public class LMTPConfigurationImpl extends LMTPConfiguration { - /** - * @see org.apache.james.protocols.smtp.SMTPConfiguration#getHelloName() - */ @Override public String getHelloName() { return LMTPServer.this.getHelloName(); } - - - /** - * @see org.apache.james.protocols.smtp.SMTPConfiguration#getMaxMessageSize() - */ @Override public long getMaxMessageSize() { return LMTPServer.this.maxMessageSize; } - /** - */ public String getSMTPGreeting() { return LMTPServer.this.lmtpGreeting; } http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/SetMimeHeaderHandler.java ---------------------------------------------------------------------- diff --git a/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/SetMimeHeaderHandler.java b/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/SetMimeHeaderHandler.java index 1fd96a9..1356272 100644 --- a/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/SetMimeHeaderHandler.java +++ b/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/SetMimeHeaderHandler.java @@ -65,9 +65,6 @@ public class SetMimeHeaderHandler implements JamesMessageHook, ProtocolHandler { /** * Adds header to the message - * - * @see org.apache.james.smtpserver.JamesMessageHook#onMessage(org.apache.james.protocols.smtp.SMTPSession, - * org.apache.mailet.Mail) */ @Override public HookResult onMessage(SMTPSession session, Mail mail) { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/fastfail/SPFHandler.java ---------------------------------------------------------------------- diff --git a/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/fastfail/SPFHandler.java b/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/fastfail/SPFHandler.java index e36f562..26eae88 100644 --- a/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/fastfail/SPFHandler.java +++ b/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/fastfail/SPFHandler.java @@ -181,129 +181,81 @@ public class SPFHandler implements JamesMessageHook, MailHook, RcptHook, Protoco this.serviceLog = FALLBACK_LOG; } - /** - * @see org.apache.james.jspf.core.Logger#debug(String) - */ @Override public void debug(String message) { serviceLog.debug(message); } - /** - * @see org.apache.james.jspf.core.Logger#debug(String, Throwable) - */ @Override public void debug(String message, Throwable t) { serviceLog.debug(message, t); } - /** - * @see org.apache.james.jspf.core.Logger#error(String) - */ @Override public void error(String message) { serviceLog.error(message); } - /** - * @see org.apache.james.jspf.core.Logger#error(String, Throwable) - */ @Override public void error(String message, Throwable t) { serviceLog.error(message, t); } - /** - * @see org.apache.james.jspf.core.Logger#fatalError(String) - */ @Override public void fatalError(String message) { serviceLog.error(message); } - /** - * @see org.apache.james.jspf.core.Logger#fatalError(String, Throwable) - */ @Override public void fatalError(String message, Throwable t) { serviceLog.error(message, t); } - /** - * @see org.apache.james.jspf.core.Logger#info(String) - */ @Override public void info(String message) { serviceLog.info(message); } - /** - * @see org.apache.james.jspf.core.Logger#info(String, Throwable) - */ @Override public void info(String message, Throwable t) { serviceLog.info(message, t); } - /** - * @see org.apache.james.jspf.core.Logger#isDebugEnabled() - */ @Override public boolean isDebugEnabled() { return serviceLog.isDebugEnabled(); } - /** - * @see org.apache.james.jspf.core.Logger#isErrorEnabled() - */ @Override public boolean isErrorEnabled() { return serviceLog.isErrorEnabled(); } - /** - * @see org.apache.james.jspf.core.Logger#isFatalErrorEnabled() - */ @Override public boolean isFatalErrorEnabled() { return serviceLog.isErrorEnabled(); } - /** - * @see org.apache.james.jspf.core.Logger#isInfoEnabled() - */ @Override public boolean isInfoEnabled() { return serviceLog.isInfoEnabled(); } - /** - * @see org.apache.james.jspf.core.Logger#isWarnEnabled() - */ @Override public boolean isWarnEnabled() { return serviceLog.isWarnEnabled(); } - /** - * @see org.apache.james.jspf.core.Logger#warn(String) - */ @Override public void warn(String message) { serviceLog.warn(message); } - /** - * @see org.apache.james.jspf.core.Logger#warn(String, Throwable) - */ @Override public void warn(String message, Throwable t) { serviceLog.warn(message, t); } - /** - * @see org.apache.james.jspf.core.Logger#getChildLogger(String) - */ @Override public org.apache.james.jspf.core.Logger getChildLogger(String name) { return this; http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/netty/SMTPServer.java ---------------------------------------------------------------------- diff --git a/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/netty/SMTPServer.java b/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/netty/SMTPServer.java index c35e778..632f574 100644 --- a/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/netty/SMTPServer.java +++ b/server/protocols/protocols-smtp/src/main/java/org/apache/james/smtpserver/netty/SMTPServer.java @@ -212,25 +212,16 @@ public class SMTPServer extends AbstractProtocolAsyncServer implements SMTPServe */ public class SMTPHandlerConfigurationDataImpl implements SMTPConfiguration { - /** - * @see org.apache.james.protocols.smtp.SMTPConfiguration#getHelloName() - */ @Override public String getHelloName() { return SMTPServer.this.getHelloName(); } - /** - * @see org.apache.james.protocols.smtp.SMTPConfiguration#getMaxMessageSize() - */ @Override public long getMaxMessageSize() { return SMTPServer.this.maxMessageSize; } - /** - * @see org.apache.james.protocols.smtp.SMTPConfiguration#isRelayingAllowed(String) - */ @Override public boolean isRelayingAllowed(String remoteIP) { boolean relayingAllowed = false; @@ -240,31 +231,20 @@ public class SMTPServer extends AbstractProtocolAsyncServer implements SMTPServe return relayingAllowed; } - /** - * @see org.apache.james.protocols.smtp.SMTPConfiguration#useHeloEhloEnforcement() - */ @Override public boolean useHeloEhloEnforcement() { return SMTPServer.this.heloEhloEnforcement; } - /** - */ public String getSMTPGreeting() { return SMTPServer.this.smtpGreeting; } - /** - * @see org.apache.james.protocols.smtp.SMTPConfiguration#useAddressBracketsEnforcement() - */ @Override public boolean useAddressBracketsEnforcement() { return SMTPServer.this.addressBracketsEnforcement; } - /** - * @see org.apache.james.protocols.smtp.SMTPConfiguration#isAuthRequired(java.lang.String) - */ @Override public boolean isAuthRequired(String remoteIP) { if (SMTPServer.this.authRequired == AUTH_ANNOUNCE) { http://git-wip-us.apache.org/repos/asf/james-project/blob/ddc04847/server/queue/queue-file/src/main/java/org/apache/james/queue/file/FileMailQueue.java ---------------------------------------------------------------------- diff --git a/server/queue/queue-file/src/main/java/org/apache/james/queue/file/FileMailQueue.java b/server/queue/queue-file/src/main/java/org/apache/james/queue/file/FileMailQueue.java index 461d450..4b2e462 100644 --- a/server/queue/queue-file/src/main/java/org/apache/james/queue/file/FileMailQueue.java +++ b/server/queue/queue-file/src/main/java/org/apache/james/queue/file/FileMailQueue.java @@ -425,8 +425,6 @@ public class FileMailQueue implements ManageableMailQueue { /** * TODO: implement me - * - * @see ManageableMailQueue#remove(org.apache.james.queue.api.ManageableMailQueue.Type, String) */ @Override public long remove(Type type, String value) throws MailQueueException { --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org
