JAMES-2382: Change the method name. The method is named "hasAnnotatedProperty" that is a query of asking whether the propertyDescriptor has the AnnotatedProperty or not. Actually, the method returns an AnnotatedProperty found by the propertyDescriptor. Thus, the method name "findAnnotatedProperty" should be intuitive than "hasAnnotatedProperty".
Project: http://git-wip-us.apache.org/repos/asf/james-project/repo Commit: http://git-wip-us.apache.org/repos/asf/james-project/commit/a66a8cf8 Tree: http://git-wip-us.apache.org/repos/asf/james-project/tree/a66a8cf8 Diff: http://git-wip-us.apache.org/repos/asf/james-project/diff/a66a8cf8 Branch: refs/heads/master Commit: a66a8cf80e36685f336c90ec7b7197d4fd22e0fd Parents: c0b89b0 Author: Kui LIU <[email protected]> Authored: Tue Apr 24 08:24:43 2018 +0200 Committer: benwa <[email protected]> Committed: Fri Apr 27 14:24:55 2018 +0700 ---------------------------------------------------------------------- .../lifecycle/osgi/AbstractOSGIAnnotationBeanPostProcessor.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/james-project/blob/a66a8cf8/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/osgi/AbstractOSGIAnnotationBeanPostProcessor.java ---------------------------------------------------------------------- diff --git a/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/osgi/AbstractOSGIAnnotationBeanPostProcessor.java b/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/osgi/AbstractOSGIAnnotationBeanPostProcessor.java index 6ec3d07..4bad5f5 100644 --- a/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/osgi/AbstractOSGIAnnotationBeanPostProcessor.java +++ b/server/container/spring/src/main/java/org/apache/james/container/spring/lifecycle/osgi/AbstractOSGIAnnotationBeanPostProcessor.java @@ -178,7 +178,7 @@ public abstract class AbstractOSGIAnnotationBeanPostProcessor<A extends Annotati MutablePropertyValues newprops = new MutablePropertyValues(pvs); for (PropertyDescriptor pd : pds) { - A s = hasAnnotatedProperty(pd); + A s = findAnnotatedProperty(pd); if (s != null && !pvs.contains(pd.getName())) { try { logger.debug("Processing annotation [{}] for [{}.{}]", s, beanName, pd.getName()); @@ -267,7 +267,7 @@ public abstract class AbstractOSGIAnnotationBeanPostProcessor<A extends Annotati } - private A hasAnnotatedProperty(PropertyDescriptor propertyDescriptor) { + private A findAnnotatedProperty(PropertyDescriptor propertyDescriptor) { Method setter = propertyDescriptor.getWriteMethod(); return setter != null ? AnnotationUtils.getAnnotation(setter, getAnnotation()) : null; } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
