[ https://issues.apache.org/jira/browse/JAMES-2171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16733929#comment-16733929 ]
ASF GitHub Bot commented on JAMES-2171: --------------------------------------- Github user chibenwa commented on a diff in the pull request: https://github.com/apache/james-project/pull/145#discussion_r245234684 --- Diff: mailet/standard/src/main/java/org/apache/james/transport/mailets/LogMessage.java --- @@ -86,12 +103,11 @@ public String getMailetInfo() { @Override public void service(Mail mail) { - logger.info("Logging mail {}", mail.getName()); - logComment(); + StringBuilder logs = new StringBuilder(); + logs.append(logComment()); try { - MimeMessage message = mail.getMessage(); - logHeaders(message); - logBody(message); + logs.append(logHeaders(mail) + logBody(mail) + logAttribute(mail)); --- End diff -- We can avoid the string concatenation as we do have a string builder: ``` logs.append(logHeaders(mail)); logs.append(logBody(lail)); logs.append(logAttrribute(mail)); ``` > LogMessage mailet improvments > ----------------------------- > > Key: JAMES-2171 > URL: https://issues.apache.org/jira/browse/JAMES-2171 > Project: James Server > Issue Type: Improvement > Components: Mailet Contributions > Affects Versions: master > Reporter: Tellier Benoit > Priority: Major > Labels: easyfix, newbie > > Today, one can use the LogMessage to generate log messages upon mail reception > But the LogMessage have the following limits: > - It do not let you configure the warn level > - It does generate several logs. One would be simpler to review. > - It does add some unneeded informations, like mail name already carried by > the MDC > - It does not allow logging of specific headers or specific attributeNames. > This leads to missing information as well as "to much information". > - The code quality of the mailet is poor. > You will: > - Ensure a single log message will be generated. For this you will call the > logger one time and concatenate log messages parts. > - Remove the log line with mail name. > - Add a **level** configuration option. It can takes value **warn**, > **info**, **debug** or **error**. It will be used to set the logger log level. > - Add a **specificHeaders** configuration option. It takes a comma separated > list of header names to include in the log message. By default it is empty. > - Add a **specificAttributes** configuration option. It takes a comma > separated list of attribute names to be included in the log message. By > default it is empty. > - **body** configuration option should be false by default > - **header** configuration option should be false by default > - **init** should propagate exception while initilizing (Integer parse > exception, also passing a negative max body should throw.) > - Remove inlined affectation for field. They can be unset on their > declaration and set when init is called. > Correct *LogMessageTest* accordingly. > Don't hesitate to reach us on the *gitter* chat if you have any question. -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org