This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 4a278263563ce9ae7acdac3e4ff96abe151eed42 Author: tran tien duc <[email protected]> AuthorDate: Thu Feb 21 18:27:09 2019 +0700 MAILBOX-379 Introduce PreDeletionHook API --- .../java/org/apache/james/mailbox/extension/PreDeletionHook.java | 2 ++ .../org/apache/james/mailbox/extension/PreDeletionHookTest.java | 9 +++++++++ 2 files changed, 11 insertions(+) diff --git a/mailbox/api/src/main/java/org/apache/james/mailbox/extension/PreDeletionHook.java b/mailbox/api/src/main/java/org/apache/james/mailbox/extension/PreDeletionHook.java index 022e511..1f41593 100644 --- a/mailbox/api/src/main/java/org/apache/james/mailbox/extension/PreDeletionHook.java +++ b/mailbox/api/src/main/java/org/apache/james/mailbox/extension/PreDeletionHook.java @@ -27,6 +27,7 @@ import java.util.UUID; import org.apache.james.mailbox.MetadataWithMailboxId; import org.reactivestreams.Publisher; +import com.google.common.base.Preconditions; import com.google.common.collect.ImmutableSet; public interface PreDeletionHook { @@ -44,6 +45,7 @@ public interface PreDeletionHook { private final UUID id; private DeletionId(UUID id) { + Preconditions.checkNotNull(id, "id for deletion cannot be null"); this.id = id; } diff --git a/mailbox/api/src/test/java/org/apache/james/mailbox/extension/PreDeletionHookTest.java b/mailbox/api/src/test/java/org/apache/james/mailbox/extension/PreDeletionHookTest.java index 2b19ce1..b32a2cf 100644 --- a/mailbox/api/src/test/java/org/apache/james/mailbox/extension/PreDeletionHookTest.java +++ b/mailbox/api/src/test/java/org/apache/james/mailbox/extension/PreDeletionHookTest.java @@ -18,6 +18,8 @@ ****************************************************************/ package org.apache.james.mailbox.extension; +import static org.assertj.core.api.Assertions.assertThatThrownBy; + import org.junit.jupiter.api.Nested; import org.junit.jupiter.api.Test; @@ -33,6 +35,13 @@ class PreDeletionHookTest { EqualsVerifier.forClass(PreDeletionHook.DeletionId.class) .verify(); } + + @Test + void shouldThrowWhenPassingNullId() { + assertThatThrownBy(() -> PreDeletionHook.DeletionId.of(null)) + .isInstanceOf(NullPointerException.class) + .hasMessage("id for deletion cannot be null"); + } } @Nested --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
