[ https://issues.apache.org/jira/browse/JAMES-2717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16836273#comment-16836273 ]
Tellier Benoit edited comment on JAMES-2717 at 5/9/19 10:31 AM: ---------------------------------------------------------------- Merged PRs - Part 1 : JAMES-2717 Replace Embedded ES by Docker ES in tests https://github.com/linagora/james-project/pull/2341 - Part 2 : JAMES-2717 Replace EmbeddedElasticSearchExtension https://github.com/linagora/james-project/pull/2344 Ongoing PRs - Part 3 : JAMES-2717 Replace the remaining embedded ES components in IT tests https://github.com/linagora/james-project/pull/2346 - Part 4 : JAMES-2717 Remove EmbeddedElasticSearch in unit tests https://github.com/linagora/james-project/pull/2347 was (Author: btellier): Merged PRs - Part 1 : JAMES-2717 Replace Embedded ES by Docker ES in tests https://github.com/linagora/james-project/pull/2341 - Part 2 : JAMES-2717 Replace EmbeddedElasticSearchExtension https://github.com/linagora/james-project/pull/2344 Ongoing PRs - Part 3 : JAMES-2717 Replace the remaining embedded ES components in IT tests https://github.com/linagora/james-project/pull/2346 - Part 4 : JAMES-2717 Remove EmbeddedElasticSearch in unit tests > [ES] Replace EmbeddedElasticSearch by Docker ES > ----------------------------------------------- > > Key: JAMES-2717 > URL: https://issues.apache.org/jira/browse/JAMES-2717 > Project: James Server > Issue Type: New Feature > Components: elasticsearch > Reporter: Rene Cordier > Priority: Major > Fix For: 3.4.0 > > > EmbeddedElasticSearch is used for creating ES > 'org.elasticsearch.client.Client' from embedded ES node. The job is done in > 'TestingClientProvider'. > It can be replaced by 'ClientProviderImpl' connects to a docker ES. > There are places where EmbeddedElasticSearch is used: > * server/protocols/webadmin-integration-test UnauthorizedEndpointsTest > * server/protocols/jmap-integration-testing: CassandraStepdefs, > RabbitMQStepdefs > * mpt/impl/imap-mailbox/elasticsearch ElasticSearchUidSearchOnIndexTest > * backends-common/elasticsearch ElasticSearchIndexerTest > * mailbox/elasticsearch ElasticSearchIntegrationTest > * mailbox/plugin/quota-search-elasticsearch > ElasticSearchQuotaMailboxListenerTest > * server/container/guice/cassandra-guice many places > _Steps_: > * Extract a DockerElasticSearch based a DockerGenericContainer instance (& > associated singleton) + wait strategy > * Provide junit 4 rules & junit 5 extension - allowing test to retrieve > clients > * Expose a method for awaiting an ES docker is up + await indexation is done > (akka flush) > * Define a test isolation strategy. Proposal: random index & aliases names, > no data removal. Alternative: list then delete index & aliases. > _Note_: > * Need to optimize ES docker life cycle management (e.g: using Singleton > instance like DockerCassandraSingleton) -- This message was sent by Atlassian JIRA (v7.6.3#76005) --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org