[ https://issues.apache.org/jira/browse/MAILBOX-391?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16971424#comment-16971424 ]
Benoit Tellier commented on MAILBOX-391: ---------------------------------------- https://github.com/linagora/james-project/pull/2862 pull request for this. I dropped some code in JPA saying that a username can be null, which seems legitimate. > Use of MailboxPath to represent queries > --------------------------------------- > > Key: MAILBOX-391 > URL: https://issues.apache.org/jira/browse/MAILBOX-391 > Project: James Mailbox > Issue Type: Improvement > Components: store > Reporter: Benoit Tellier > Priority: Major > > I got shut down on a refactoring because we use MailboxPath not only to > identifies names of mailboxes (along with their owner) but also as a way to > query the various names. > This hurts me back as I was trying to impose stronger validation over > MailboxPath mailboxName. > Given the "query" context, I could not make MailboxPath stricter. > For mailbox search within MailboxMapper, we should rely on a more suited > object. I propose to rely on raw "MailboxQuery object". At the noticeable > difference that we need to make sure the username & namespace is being > specified at the mapper layer. -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org