This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 0adcf291c68ca32798d7a4a192b0594dd8642c09
Author: Benoit Tellier <btell...@linagora.com>
AuthorDate: Sun Nov 17 11:30:04 2019 +0700

    [Refactoring] Switch RFC2822Headers to an interface
---
 .../org/apache/mailet/base/RFC2822Headers.java     | 59 +++++++++-------------
 1 file changed, 25 insertions(+), 34 deletions(-)

diff --git 
a/mailet/base/src/main/java/org/apache/mailet/base/RFC2822Headers.java 
b/mailet/base/src/main/java/org/apache/mailet/base/RFC2822Headers.java
index 304e1c2..70a0409 100644
--- a/mailet/base/src/main/java/org/apache/mailet/base/RFC2822Headers.java
+++ b/mailet/base/src/main/java/org/apache/mailet/base/RFC2822Headers.java
@@ -17,166 +17,157 @@
  * under the License.                                           *
  ****************************************************************/
 
-
 package org.apache.mailet.base;
 
 /**
  * This utility class provides the set of header names explicitly defined in 
RFC 2822
  *
  */
-public class RFC2822Headers  {
+public interface RFC2822Headers  {
 
     // See Section 3.6.1 of RFC 2822
 
     /**
      * The name of the RFC 2822 header that stores the mail date.
      */
-    public static final String DATE = "Date";
+    String DATE = "Date";
 
     // See Section 3.6.2 of RFC 2822
 
     /**
      * The name of the RFC 2822 header that stores the mail author(s).
      */
-    public static final String FROM = "From";
+    String FROM = "From";
 
     /**
      * The name of the RFC 2822 header that stores the actual mail 
transmission agent,
      * if this differs from the author of the message.
      */
-    public static final String SENDER = "Sender";
+    String SENDER = "Sender";
 
     /**
      * The name of the RFC 2822 header that stores the reply-to address.
      */
-    public static final String REPLY_TO = "Reply-To";
+    String REPLY_TO = "Reply-To";
 
     // See Section 3.6.3 of RFC 2822
 
     /**
      * The name of the RFC 2822 header that stores the primary mail recipients.
      */
-    public static final String TO = "To";
+    String TO = "To";
 
     /**
      * The name of the RFC 2822 header that stores the carbon copied mail 
recipients.
      */
-    public static final String CC = "Cc";
+    String CC = "Cc";
 
     /**
      * The name of the RFC 2822 header that stores the blind carbon copied 
mail recipients.
      */
-    public static final String BCC = "Bcc";
+    String BCC = "Bcc";
 
     // See Section 3.6.4 of RFC 2822
 
     /**
      * The name of the RFC 2822 header that stores the message id.
      */
-    public static final String MESSAGE_ID = "Message-ID";
+    String MESSAGE_ID = "Message-ID";
 
     /**
      * A common variation on the name of the RFC 2822 header that
      * stores the message id.  This is needed for certain filters and
      * processing of incoming mail.
      */
-    public static final String MESSAGE_ID_VARIATION = "Message-Id";
+    String MESSAGE_ID_VARIATION = "Message-Id";
 
     /**
      * The name of the RFC 2822 header that stores the message id of the 
message
      * that to which this email is a reply.
      */
-    public static final String IN_REPLY_TO = "In-Reply-To";
+    String IN_REPLY_TO = "In-Reply-To";
 
     /**
      * The name of the RFC 2822 header that is used to identify the thread to
      * which this message refers.
      */
-    public static final String REFERENCES = "References";
+    String REFERENCES = "References";
 
     // See Section 3.6.5 of RFC 2822
 
     /**
      * The name of the RFC 2822 header that stores the subject.
      */
-    public static final String SUBJECT = "Subject";
+    String SUBJECT = "Subject";
 
     /**
      * The name of the RFC 2822 header that stores human-readable comments.
      */
-    public static final String COMMENTS = "Comments";
+    String COMMENTS = "Comments";
 
     /**
      * The name of the RFC 2822 header that stores human-readable keywords.
      */
-    public static final String KEYWORDS = "Keywords";
+    String KEYWORDS = "Keywords";
 
     // See Section 3.6.6 of RFC 2822
 
     /**
      * The name of the RFC 2822 header that stores the date the message was 
resent.
      */
-    public static final String RESENT_DATE = "Resent-Date";
+    String RESENT_DATE = "Resent-Date";
 
     /**
      * The name of the RFC 2822 header that stores the originator of the 
resent message.
      */
-    public static final String RESENT_FROM = "Resent-From";
+    String RESENT_FROM = "Resent-From";
 
     /**
      * The name of the RFC 2822 header that stores the transmission agent
      * of the resent message.
      */
-    public static final String RESENT_SENDER = "Resent-Sender";
+    String RESENT_SENDER = "Resent-Sender";
 
     /**
      * The name of the RFC 2822 header that stores the recipients
      * of the resent message.
      */
-    public static final String RESENT_TO = "Resent-To";
+    String RESENT_TO = "Resent-To";
 
     /**
      * The name of the RFC 2822 header that stores the carbon copied recipients
      * of the resent message.
      */
-    public static final String RESENT_CC = "Resent-Cc";
+    String RESENT_CC = "Resent-Cc";
 
     /**
      * The name of the RFC 2822 header that stores the blind carbon copied 
recipients
      * of the resent message.
      */
-    public static final String RESENT_BCC = "Resent-Bcc";
+    String RESENT_BCC = "Resent-Bcc";
 
     /**
      * The name of the RFC 2822 header that stores the message id
      * of the resent message.
      */
-    public static final String RESENT_MESSAGE_ID = "Resent-Message-ID";
+    String RESENT_MESSAGE_ID = "Resent-Message-ID";
 
     // See Section 3.6.7 of RFC 2822
 
     /**
      * The name of the RFC 2822 headers that store the tracing data for the 
return path.
      */
-    public static final String RETURN_PATH = "Return-Path";
+    String RETURN_PATH = "Return-Path";
 
     /**
      * The name of the RFC 2822 headers that store additional tracing data.
      */
-    public static final String RECEIVED = "Received";
+    String RECEIVED = "Received";
 
     // MIME headers
 
     /**
      * The name of the MIME header that stores the content type.
      */
-    public static final String CONTENT_TYPE = "Content-Type";
-
-    /**
-     * Private constructor to prevent instantiation
-     */
-    private RFC2822Headers() {
-
-    }
-
+    String CONTENT_TYPE = "Content-Type";
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org

Reply via email to