[james-project] 30/43: [Refactoring] UIDVALIDITY retrieval without Mailbox.MetaData call

[btellier]

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 62782cbc5497d0c9f78afc9127fc89f50bd722da
Author: Benoit Tellier <btell...@linagora.com>
AuthorDate: Fri Nov 15 14:25:48 2019 +0700

    [Refactoring] UIDVALIDITY retrieval without Mailbox.MetaData call
    
    This further optimize IMAP APPEND command
---
 .../main/java/org/apache/james/imap/processor/AppendProcessor.java   | 5 +++--
 .../java/org/apache/james/pop3server/mailbox/MailboxAdapter.java     | 2 +-
 2 files changed, 4 insertions(+), 3 deletions(-)

diff --git 
a/protocols/imap/src/main/java/org/apache/james/imap/processor/AppendProcessor.java
 
b/protocols/imap/src/main/java/org/apache/james/imap/processor/AppendProcessor.java
index 983d855..5bbb43d 100644
--- 
a/protocols/imap/src/main/java/org/apache/james/imap/processor/AppendProcessor.java
+++ 
b/protocols/imap/src/main/java/org/apache/james/imap/processor/AppendProcessor.java
@@ -43,7 +43,6 @@ import org.apache.james.imap.message.request.AppendRequest;
 import org.apache.james.mailbox.MailboxManager;
 import org.apache.james.mailbox.MailboxSession;
 import org.apache.james.mailbox.MessageManager;
-import org.apache.james.mailbox.MessageManager.MetaData.FetchGroup;
 import org.apache.james.mailbox.exception.MailboxException;
 import org.apache.james.mailbox.exception.MailboxNotFoundException;
 import org.apache.james.mailbox.model.ComposedMessageId;
@@ -135,7 +134,9 @@ public class AppendProcessor extends 
AbstractMailboxProcessor<AppendRequest> {
             }
 
             // get folder UIDVALIDITY
-            Long uidValidity = mailboxManager.getMailbox(mailboxPath, 
mailboxSession).getMetaData(false, mailboxSession, 
FetchGroup.NO_COUNT).getUidValidity();
+            Long uidValidity = mailboxManager.getMailbox(mailboxPath, 
mailboxSession)
+                .getMailboxEntity()
+                .getUidValidity();
 
             unsolicitedResponses(session, responder, false);
 
diff --git 
a/server/protocols/protocols-pop3/src/main/java/org/apache/james/pop3server/mailbox/MailboxAdapter.java
 
b/server/protocols/protocols-pop3/src/main/java/org/apache/james/pop3server/mailbox/MailboxAdapter.java
index fabeea1..b6ca3b2 100644
--- 
a/server/protocols/protocols-pop3/src/main/java/org/apache/james/pop3server/mailbox/MailboxAdapter.java
+++ 
b/server/protocols/protocols-pop3/src/main/java/org/apache/james/pop3server/mailbox/MailboxAdapter.java
@@ -192,7 +192,7 @@ public class MailboxAdapter implements Mailbox {
     public String getIdentifier() throws IOException {
         try {
             mailboxManager.startProcessingRequest(session);
-            long validity = manager.getMetaData(false, session, 
MessageManager.MetaData.FetchGroup.NO_COUNT)
+            long validity = manager.getMailboxEntity()
                     .getUidValidity();
             return Long.toString(validity);
         } catch (MailboxException e) {


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org