This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git
commit a53e12bbf148354a7954193d213ce2caccfe6920 Author: Benoit Tellier <[email protected]> AuthorDate: Sun Nov 17 21:16:10 2019 +0700 [Refactoring] ProtocolHandlerChainImpl::addHandler never throws --- .../james/protocols/lib/ProtocolHandlerChainImpl.java | 19 +++++++------------ 1 file changed, 7 insertions(+), 12 deletions(-) diff --git a/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/ProtocolHandlerChainImpl.java b/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/ProtocolHandlerChainImpl.java index ca3542c..e1a0712 100644 --- a/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/ProtocolHandlerChainImpl.java +++ b/server/protocols/protocols-library/src/main/java/org/apache/james/protocols/lib/ProtocolHandlerChainImpl.java @@ -110,17 +110,13 @@ public class ProtocolHandlerChainImpl implements ProtocolHandlerChain { List<String> c = handlersPackage.getHandlers(); for (String cName : c) { - try { - CombinedConfiguration conf = new CombinedConfiguration(); - HierarchicalConfiguration<ImmutableNode> cmdConf = addHandler(cName); - conf.addConfiguration(cmdConf); - if (handlerConfig != null) { - conf.addConfiguration(handlerConfig); - } - children.add(conf); - } catch (ConfigurationException e) { - throw new ConfigurationException("Unable to create configuration for handler " + cName, e); + CombinedConfiguration conf = new CombinedConfiguration(); + HierarchicalConfiguration<ImmutableNode> cmdConf = addHandler(cName); + conf.addConfiguration(cmdConf); + if (handlerConfig != null) { + conf.addConfiguration(handlerConfig); } + children.add(conf); } } @@ -130,9 +126,8 @@ public class ProtocolHandlerChainImpl implements ProtocolHandlerChain { * * @param className The class name * @return DefaultConfiguration - * @throws ConfigurationException */ - private HierarchicalConfiguration<ImmutableNode> addHandler(String className) throws ConfigurationException { + private HierarchicalConfiguration<ImmutableNode> addHandler(String className) { HierarchicalConfiguration<ImmutableNode> hConf = new BaseHierarchicalConfiguration(); hConf.addProperty("[@class]", className); return hConf; --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
