[james-project] 11/42: [Refactoring] Move FlagsFactoryTest to JUnit 5

[rcordier]

This is an automated email from the ASF dual-hosted git repository.

rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit 60489d85b47f2ebf95aa63dbb9c8090aa4e8b6bc
Author: Rene Cordier <rcord...@linagora.com>
AuthorDate: Thu Dec 5 16:17:48 2019 +0700

    [Refactoring] Move FlagsFactoryTest to JUnit 5
---
 .../mailbox/store/mail/model/FlagsFactoryTest.java | 38 +++++++++++-----------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git 
a/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/FlagsFactoryTest.java
 
b/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/FlagsFactoryTest.java
index 053bfd1..42e7878 100644
--- 
a/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/FlagsFactoryTest.java
+++ 
b/mailbox/store/src/test/java/org/apache/james/mailbox/store/mail/model/FlagsFactoryTest.java
@@ -23,20 +23,20 @@ import static org.assertj.core.api.Assertions.assertThat;
 import javax.mail.Flags;
 import javax.mail.Flags.Flag;
 
-import org.junit.Before;
-import org.junit.Test;
+import org.junit.jupiter.api.BeforeEach;
+import org.junit.jupiter.api.Test;
 
 import com.google.common.collect.ImmutableList;
 
-public class FlagsFactoryTest {
+class FlagsFactoryTest {
 
-    private ImmutableList<Flag> listOfSystemFlags = 
ImmutableList.of(Flag.SEEN, Flag.RECENT, Flag.ANSWERED);
-    private ImmutableList<String> listOfUserFlags = 
ImmutableList.of("userFlag", "soCool");
-    private Flags emptyFlags;
-    private Flags someFlags;
+    ImmutableList<Flag> listOfSystemFlags = ImmutableList.of(Flag.SEEN, 
Flag.RECENT, Flag.ANSWERED);
+    ImmutableList<String> listOfUserFlags = ImmutableList.of("userFlag", 
"soCool");
+    Flags emptyFlags;
+    Flags someFlags;
 
-    @Before
-    public void setup() {
+    @BeforeEach
+    void setup() {
         emptyFlags = new Flags();
         someFlags = new Flags();
         listOfSystemFlags.forEach(someFlags::add);
@@ -44,23 +44,23 @@ public class FlagsFactoryTest {
     }
 
     @Test
-    public void builderShouldAllowEmptyFactory() {
+    void builderShouldAllowEmptyFactory() {
         assertThat(FlagsFactory.builder().build()).isEqualTo(emptyFlags);
     }
 
     @Test
-    public void builderShouldNotRequireFlagsInstanceWhenUserFlagsDefined() {
+    void builderShouldNotRequireFlagsInstanceWhenUserFlagsDefined() {
         Flags actual = FlagsFactory.builder().addUserFlags("userFlag").build();
         assertThat(actual.getUserFlags()).containsOnly("userFlag");
     }
 
     @Test
-    public void builderShouldNotRequireUserFlagsWhenFlagsInstanceDefined() {
+    void builderShouldNotRequireUserFlagsWhenFlagsInstanceDefined() {
         assertThat(FlagsFactory.builder().flags(new 
Flags()).build()).isNotNull();
     }
 
     @Test
-    public void builderShouldAcceptNullUserFlags() {
+    void builderShouldAcceptNullUserFlags() {
         assertThat(
             FlagsFactory.builder()
                 .addUserFlags((String)null)
@@ -69,7 +69,7 @@ public class FlagsFactoryTest {
     }
 
     @Test
-    public void builderShouldFilterUserFlags() {
+    void builderShouldFilterUserFlags() {
         Flags actual = FlagsFactory.builder()
             .flags(someFlags)
             .filteringFlags(
@@ -82,7 +82,7 @@ public class FlagsFactoryTest {
     }
 
     @Test
-    public void builderShouldFilterSystemFlags() {
+    void builderShouldFilterSystemFlags() {
         Flags actual = FlagsFactory.builder()
             .flags(someFlags)
             .filteringFlags(
@@ -95,7 +95,7 @@ public class FlagsFactoryTest {
     }
 
     @Test
-    public void builderShouldAllowFilteringOnEmptyFlags() {
+    void builderShouldAllowFilteringOnEmptyFlags() {
         Flags actual = FlagsFactory.builder()
             .flags(emptyFlags)
             .filteringFlags(
@@ -109,7 +109,7 @@ public class FlagsFactoryTest {
     }
 
     @Test
-    public void builderShouldFilterOnFlags() {
+    void builderShouldFilterOnFlags() {
         Flags actual = FlagsFactory.builder()
             .flags(someFlags)
             .filteringFlags(
@@ -124,7 +124,7 @@ public class FlagsFactoryTest {
     }
 
     @Test
-    public void builderShouldTrimEmptyUserFlags() {
+    void builderShouldTrimEmptyUserFlags() {
         Flags flags = new Flags();
         flags.add("");
         flags.add("value2");
@@ -133,7 +133,7 @@ public class FlagsFactoryTest {
     }
 
     @Test
-    public void builderShouldTrimNullUserFlags() {
+    void builderShouldTrimNullUserFlags() {
         Flags actual = FlagsFactory.builder().addUserFlags(null, 
"value").build();
         assertThat(actual.getUserFlags()).containsOnly("value");
     }


---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org