This is an automated email from the ASF dual-hosted git repository.

rcordier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git

commit d66d9a7731810afe854db140b8cc4182fd8f64b0
Author: Rene Cordier <[email protected]>
AuthorDate: Mon Feb 3 15:32:15 2020 +0700

    JAMES-3033 Update checkstyle dependency 8.23 -> 8.29.
    
    This introduced some breaking changes that are not really a problem for our 
checkstyle :
     * https://github.com/checkstyle/checkstyle/issues/2116 : Change LineLength 
Check parent from TreeWalker to Checker
     * https://github.com/checkstyle/checkstyle/issues/7096 : 
JavadocMethodCheck: remove deprecated properties ignoreMethodNamesRegex, 
minLineCount, allowMissingJavadoc, allowMissingPropertyJavadoc
     * https://github.com/checkstyle/checkstyle/issues/7329 : Remove properties 
related to class loading from JavadocMethod
---
 checkstyle.xml | 15 ++++++---------
 pom.xml        |  2 +-
 2 files changed, 7 insertions(+), 10 deletions(-)

diff --git a/checkstyle.xml b/checkstyle.xml
index 3ff4a59..c445617 100644
--- a/checkstyle.xml
+++ b/checkstyle.xml
@@ -46,12 +46,6 @@
       <property name="allowByTailComment" value="true"/>
       <property name="allowNonPrintableEscapes" value="true"/>
     </module>
-    <module name="LineLength">
-      <property name="severity" value="ignore"/>
-      <property name="ignorePattern" value="^package.*|^import.*|a 
href|href|http://|https://|ftp://"/>
-      <property name="max" value="100"/>
-      <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" 
value="inherit"/>
-    </module>
     <module name="AvoidStarImport"/>
     <module name="OneTopLevelClass"/>
     <module name="NoLineWrap"/>
@@ -230,12 +224,9 @@
     </module>
     <module name="JavadocMethod">
       <property name="severity" value="ignore"/>
-      <property name="minLineCount" value="2"/>
       <property name="allowedAnnotations" value="Override, Test"/>
       <property name="scope" value="public"/>
-      <property name="allowThrowsTagsForSubclasses" value="true"/>
       <property name="allowMissingParamTags" value="true"/>
-      <property name="allowMissingThrowsTags" value="true"/>
       <property name="allowMissingReturnTag" value="true"/>
       <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" 
value="inherit"/>
     </module>
@@ -273,4 +264,10 @@
   <module name="FileTabCharacter">
     <property name="eachLine" value="true"/>
   </module>
+  <module name="LineLength">
+    <property name="severity" value="ignore"/>
+    <property name="ignorePattern" value="^package.*|^import.*|a 
href|href|http://|https://|ftp://"/>
+    <property name="max" value="100"/>
+    <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" 
value="inherit"/>
+  </module>
 </module>
diff --git a/pom.xml b/pom.xml
index bd6137e..c491d1b 100644
--- a/pom.xml
+++ b/pom.xml
@@ -3237,7 +3237,7 @@
                     <dependency>
                         <groupId>com.puppycrawl.tools</groupId>
                         <artifactId>checkstyle</artifactId>
-                        <version>8.23</version>
+                        <version>8.29</version>
                     </dependency>
                 </dependencies>
                 <executions>


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to