This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git
commit b761946870256b395ae1a4767e1507d3e474af6a Author: Benoit Tellier <[email protected]> AuthorDate: Tue Mar 31 11:43:30 2020 +0700 [Performance] Use MailboxId rather than MailboxPath in IMAP logs Retrieving the mailboxPath of the selected mailbox requires some backend queries, and the mailboxPath is mutable. Retrieving the mailboxId of the selected mailbox does not require backend queries, and the mailboxId is immutable. --- .../org/apache/james/imap/processor/AbstractMailboxProcessor.java | 2 +- .../org/apache/james/imap/processor/AbstractSelectionProcessor.java | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java b/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java index 487e347..12c7733 100644 --- a/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java +++ b/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java @@ -247,7 +247,7 @@ public abstract class AbstractMailboxProcessor<R extends ImapRequest> extends Ab final MessageUid uid = mr.getUid(); int msn = selected.msn(uid); if (msn == SelectedMailbox.NO_SUCH_MESSAGE) { - LOGGER.debug("No message found with uid {} in the uid<->msn mapping for mailbox {}. This may be because it was deleted by a concurrent session. So skip it..", uid, selected.getPath().asString()); + LOGGER.debug("No message found with uid {} in the uid<->msn mapping for mailbox {}. This may be because it was deleted by a concurrent session. So skip it..", uid, selected.getMailboxId().serialize()); // skip this as it was not found in the mapping // // See IMAP-346 diff --git a/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java b/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java index affcb1e..5441cc5 100644 --- a/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java +++ b/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractSelectionProcessor.java @@ -135,7 +135,7 @@ abstract class AbstractSelectionProcessor<R extends AbstractMailboxSelectionRequ while (unseen(responder, firstUnseen, selected) == false) { // if we not was able to get find the unseen within 5 retries we should just not send it if (retryCount == 5) { - LOGGER.info("Unable to uid for unseen message {} in mailbox {}", firstUnseen, selected.getPath()); + LOGGER.info("Unable to uid for unseen message {} in mailbox {}", firstUnseen, selected.getMailboxId().serialize()); break; } firstUnseen = selectMailbox(fullMailboxPath, session).getFirstUnseen(); @@ -352,7 +352,7 @@ abstract class AbstractSelectionProcessor<R extends AbstractMailboxSelectionRequ int msn = selected.msn(unseenUid); if (msn == SelectedMailbox.NO_SUCH_MESSAGE) { - LOGGER.debug("No message found with uid {} in mailbox {}", unseenUid, selected.getPath().asString()); + LOGGER.debug("No message found with uid {} in mailbox {}", unseenUid, selected.getMailboxId().serialize()); return false; } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
