This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git
commit bb5f0e7f47dc63d1b817cf09a333b5569d5c8d2b Author: Matthieu Baechler <[email protected]> AuthorDate: Wed Mar 25 12:12:13 2020 +0100 [Refactoring] remove useless String operations --- .../java/org/apache/james/mailbox/maildir/MaildirFolder.java | 10 +++++----- .../org/apache/james/mailbox/maildir/MaildirMessageName.java | 2 +- .../main/java/org/apache/mailet/base/FlowedMessageUtils.java | 2 +- .../java/org/apache/james/transport/mailets/AbstractSign.java | 2 +- .../james/transport/matcher/IsX509CertificateSubject.java | 2 +- .../java/org/apache/james/transport/mailets/AddFooter.java | 4 ++-- .../apache/james/imap/processor/AbstractMailboxProcessor.java | 2 +- .../test/java/org/apache/james/blob/api/BlobStoreContract.java | 2 +- .../src/main/java/org/apache/james/rrt/lib/MappingSource.java | 2 +- 9 files changed, 14 insertions(+), 14 deletions(-) diff --git a/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirFolder.java b/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirFolder.java index 6475c3e..e4f56bb 100644 --- a/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirFolder.java +++ b/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirFolder.java @@ -541,7 +541,7 @@ public class MaildirFolder { } MessageUid uid = MessageUid.of(Long.parseLong(line.substring(0, gap))); - String name = line.substring(gap + 1, line.length()); + String name = line.substring(gap + 1); for (String recentFile : recentFiles) { if (recentFile.equals(name)) { recentMessages.put(uid, newMaildirMessageName(MaildirFolder.this, recentFile)); @@ -615,7 +615,7 @@ public class MaildirFolder { throw new MailboxException("Corrupted entry in uid-file " + uidList + " line " + lineNumber); } MessageUid uid = MessageUid.of(Long.parseLong(line.substring(0, gap))); - String name = line.substring(gap + 1, line.length()); + String name = line.substring(gap + 1); reverseUidMap.put(stripMetaFromName(name), uid); } } @@ -670,7 +670,7 @@ public class MaildirFolder { if (to != null && uid.compareTo(to) > 0) { break; } - String name = line.substring(gap + 1, line.length()); + String name = line.substring(gap + 1); uidMap.put(uid, newMaildirMessageName(MaildirFolder.this, name)); } } @@ -724,7 +724,7 @@ public class MaildirFolder { } int gap2 = line.indexOf(" ", gap1 + 1); lastUid = Optional.of(MessageUid.of(Long.parseLong(line.substring(gap1 + 1, gap2)))); - messageCount = Integer.parseInt(line.substring(gap2 + 1, line.length())); + messageCount = Integer.parseInt(line.substring(gap2 + 1)); } /** @@ -884,7 +884,7 @@ public class MaildirFolder { } if (uid.equals(MessageUid.of(Long.parseLong(line.substring(0, line.indexOf(" ")))))) { - deletedMessage = newMaildirMessageName(MaildirFolder.this, line.substring(gap + 1, line.length())); + deletedMessage = newMaildirMessageName(MaildirFolder.this, line.substring(gap + 1)); messageCount--; } else { lines.add(line); diff --git a/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirMessageName.java b/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirMessageName.java index 313edf9..37c38e5 100644 --- a/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirMessageName.java +++ b/mailbox/maildir/src/main/java/org/apache/james/mailbox/maildir/MaildirMessageName.java @@ -249,7 +249,7 @@ public class MaildirMessageName { int secondEnd = fullName.indexOf('.', firstEnd + 1); timestamp = fullName.substring(0, firstEnd); uniqueString = fullName.substring(firstEnd + 1, secondEnd); - hostnameAndMeta = fullName.substring(secondEnd + 1, fullName.length()); + hostnameAndMeta = fullName.substring(secondEnd + 1); } /** diff --git a/mailet/base/src/main/java/org/apache/mailet/base/FlowedMessageUtils.java b/mailet/base/src/main/java/org/apache/mailet/base/FlowedMessageUtils.java index 85327c1..4568908 100644 --- a/mailet/base/src/main/java/org/apache/mailet/base/FlowedMessageUtils.java +++ b/mailet/base/src/main/java/org/apache/mailet/base/FlowedMessageUtils.java @@ -251,7 +251,7 @@ public final class FlowedMessageUtils { } } - result.append(line.substring(0, j + 1)); + result.append(line, 0, j + 1); if (j < line.length() - 1) { if (delSp) { result.append(RFC2646_SPACE); diff --git a/mailet/crypto/src/main/java/org/apache/james/transport/mailets/AbstractSign.java b/mailet/crypto/src/main/java/org/apache/james/transport/mailets/AbstractSign.java index 99f60c8..6de0ef5 100644 --- a/mailet/crypto/src/main/java/org/apache/james/transport/mailets/AbstractSign.java +++ b/mailet/crypto/src/main/java/org/apache/james/transport/mailets/AbstractSign.java @@ -713,7 +713,7 @@ public abstract class AbstractSign extends GenericMailet { int fromIndex = 0; int index; while ((index = template.indexOf(pattern, fromIndex)) >= 0) { - sb.append(template.substring(fromIndex, index)); + sb.append(template, fromIndex, index); sb.append(actual); fromIndex = index + pattern.length(); } diff --git a/mailet/crypto/src/main/java/org/apache/james/transport/matcher/IsX509CertificateSubject.java b/mailet/crypto/src/main/java/org/apache/james/transport/matcher/IsX509CertificateSubject.java index cfebc6c..2bf5823 100644 --- a/mailet/crypto/src/main/java/org/apache/james/transport/matcher/IsX509CertificateSubject.java +++ b/mailet/crypto/src/main/java/org/apache/james/transport/matcher/IsX509CertificateSubject.java @@ -63,7 +63,7 @@ public class IsX509CertificateSubject extends GenericMatcher { int pos = condition.indexOf(";"); sourceAttribute = AttributeName.of(condition.substring(0,pos).trim()); - check = condition.substring(pos + 1, condition.length()); + check = condition.substring(pos + 1); } @Override diff --git a/mailet/standard/src/main/java/org/apache/james/transport/mailets/AddFooter.java b/mailet/standard/src/main/java/org/apache/james/transport/mailets/AddFooter.java index 44ef5c7..9ce6c45 100644 --- a/mailet/standard/src/main/java/org/apache/james/transport/mailets/AddFooter.java +++ b/mailet/standard/src/main/java/org/apache/james/transport/mailets/AddFooter.java @@ -147,9 +147,9 @@ public class AddFooter extends GenericMailet { } int insertionIndex = matcher.start(matcher.groupCount() - 1); return new StringBuilder() - .append(content.substring(0, insertionIndex)) + .append(content, 0, insertionIndex) .append(getFooterHTML()) - .append(content.substring(insertionIndex, content.length())) + .append(content.substring(insertionIndex)) .toString(); } diff --git a/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java b/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java index 12c7733..f094609 100644 --- a/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java +++ b/protocols/imap/src/main/java/org/apache/james/imap/processor/AbstractMailboxProcessor.java @@ -360,7 +360,7 @@ public abstract class AbstractMailboxProcessor<R extends ImapRequest> extends Ab * Joins the elements of a mailboxPath together and returns them as a string */ private String joinMailboxPath(MailboxPath mailboxPath, char delimiter) { - StringBuilder sb = new StringBuilder(""); + StringBuilder sb = new StringBuilder(); if (mailboxPath.getNamespace() != null && !mailboxPath.getNamespace().equals("")) { sb.append(mailboxPath.getNamespace()); } diff --git a/server/blob/blob-api/src/test/java/org/apache/james/blob/api/BlobStoreContract.java b/server/blob/blob-api/src/test/java/org/apache/james/blob/api/BlobStoreContract.java index c01e480..dc49969 100644 --- a/server/blob/blob-api/src/test/java/org/apache/james/blob/api/BlobStoreContract.java +++ b/server/blob/blob-api/src/test/java/org/apache/james/blob/api/BlobStoreContract.java @@ -107,7 +107,7 @@ public interface BlobStoreContract extends DeleteBlobStoreContract, BucketBlobSt BlobStore store = testee(); BucketName defaultBucketName = store.getDefaultBucketName(); - BlobId blobId = Mono.from(store.save(defaultBucketName, new String(), storagePolicy)).block(); + BlobId blobId = Mono.from(store.save(defaultBucketName, "", storagePolicy)).block(); byte[] bytes = Mono.from(store.readBytes(defaultBucketName, blobId)).block(); diff --git a/server/data/data-api/src/main/java/org/apache/james/rrt/lib/MappingSource.java b/server/data/data-api/src/main/java/org/apache/james/rrt/lib/MappingSource.java index 8bf6cd4..c512248 100644 --- a/server/data/data-api/src/main/java/org/apache/james/rrt/lib/MappingSource.java +++ b/server/data/data-api/src/main/java/org/apache/james/rrt/lib/MappingSource.java @@ -78,7 +78,7 @@ public class MappingSource implements Serializable { return wildCard(); default: if (mappingSource.startsWith(WILDCARD + "@")) { - return fromDomain(Domain.of(mappingSource.substring(2, mappingSource.length()))); + return fromDomain(Domain.of(mappingSource.substring(2))); } return fromUser(Username.of(mappingSource)); } --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
