This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 1ef139ab619f0755a11540249bc7c4543a75c765 Author: Benoit Tellier <[email protected]> AuthorDate: Mon May 11 10:53:10 2020 +0700 [Refactoring] MailboxContentMetaData recent field should be immutable --- .../api/src/main/java/org/apache/james/mailbox/MessageManager.java | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mailbox/api/src/main/java/org/apache/james/mailbox/MessageManager.java b/mailbox/api/src/main/java/org/apache/james/mailbox/MessageManager.java index 1ddd74b..6c21579 100644 --- a/mailbox/api/src/main/java/org/apache/james/mailbox/MessageManager.java +++ b/mailbox/api/src/main/java/org/apache/james/mailbox/MessageManager.java @@ -23,7 +23,6 @@ import java.io.ByteArrayInputStream; import java.io.IOException; import java.io.InputStream; import java.nio.charset.StandardCharsets; -import java.util.ArrayList; import java.util.Date; import java.util.EnumSet; import java.util.Iterator; @@ -419,7 +418,7 @@ public interface MessageManager { } private final long recentCount; - private final List<MessageUid> recent; + private final ImmutableList<MessageUid> recent; private final Flags permanentFlags; private final UidValidity uidValidity; private final MessageUid nextUid; @@ -432,7 +431,7 @@ public interface MessageManager { private final MailboxACL acl; public MailboxMetaData(List<MessageUid> recent, Flags permanentFlags, UidValidity uidValidity, MessageUid uidNext, ModSeq highestModSeq, long messageCount, long unseenCount, MessageUid firstUnseen, boolean writeable, boolean modSeqPermanent, MailboxACL acl) { - this.recent = Optional.ofNullable(recent).orElseGet(ArrayList::new); + this.recent = Optional.ofNullable(recent).map(ImmutableList::copyOf).orElseGet(ImmutableList::of); this.highestModSeq = highestModSeq; this.recentCount = this.recent.size(); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
