This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-project.git
commit ca08ef2c3c052afac95777216ba3ce5b19d253b0 Author: Benoit Tellier <[email protected]> AuthorDate: Thu May 14 12:21:24 2020 +0700 [ADR] Handle LDAP product variation via module choice --- ...036-against-use-of-conditional-statements-in-guice-modules.md | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/adr/0036-against-use-of-conditional-statements-in-guice-modules.md b/src/adr/0036-against-use-of-conditional-statements-in-guice-modules.md index efc0bdb..55307e7 100644 --- a/src/adr/0036-against-use-of-conditional-statements-in-guice-modules.md +++ b/src/adr/0036-against-use-of-conditional-statements-in-guice-modules.md @@ -82,6 +82,9 @@ The following modules perform conditional statements upon injection time: - BlobStoreChoosingModule::provideBlobStore: Choice of BlobStore technology: Cassandra, ObjectStorage or Hybrid - [Cached blob store](https://github.com/linagora/james-project/pull/3319) represents a similar problem: should the blobStore be wrapped by a caching layer? + +Cassandra and Distributed products are furthermore duplicated to offer a version supporting LDAP authentication. JPA +product does not offer LDAP support. ## Decision @@ -111,4 +114,8 @@ The following conditional statements in guice modules needs to be removed : ObjectStorageDependenciesModule::selectBlobStoreBuilder and Cassandra Blob Store Cache conditional statement. - [S3 native blobStore implementation](https://github.com/linagora/james-project/pull/3099) along side with S3 endpoints support as part of Swift removes the need to select the Object Storage implementation. - - Follow up work needs to be plan concerning `BlobExportMechanismModule` and `TikaMailboxModule::provideTextExtractor`. \ No newline at end of file + - Follow up work needs to be plan concerning `BlobExportMechanismModule` and `TikaMailboxModule::provideTextExtractor`. + +We furthermore need to enable a module choice for LDAP on top of other existing products. We should remove LDAP variations +for LDAP products. Corresponding docker image will be based on their non LDAP version, overriding the `usersrepository.xml` +configuration file, be marked as deprecated and eventually removed. \ No newline at end of file --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
