Matthieu Baechler created JAMES-3427:
----------------------------------------
Summary: definitely delete mailbox-store module
Key: JAMES-3427
URL: https://issues.apache.org/jira/browse/JAMES-3427
Project: James Server
Issue Type: Improvement
Components: mailbox
Reporter: Matthieu Baechler
mailbox-store module aims at sharing code between mailbox implementations.
To Achieve that, it relies on inheritance and a level of abstraction, namely
Mappers.
This design promotes code sharing as a way to share behaviors of Managers
implementation.
This strategy is brittle because there's no way to ensure that inheriting a
class will define its behavior.
In James, we usually define Contract TestSuites to ensure that the
implementation of an interface behaves as expected, Managers are an exception
to this rule.
Also, the use of the Mapper layers offer very weak guarantees and at the same
time constrains the way we implement Managers.
Dropping the mapper layer would help simplify the codebase.
So the plan is to push methods down in all implementations, remove abstract
classes, inline Mappers in Managers and port relevant Mappers tests to Managers
level.
Some efforts to reduce duplication generated by pushing methods down the
hierarchy will lead to new helper classes to share between classes or enriching
existing APIs for a higher level of abstraction.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
