[
https://issues.apache.org/jira/browse/JAMES-2124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17234974#comment-17234974
]
ASF GitHub Bot commented on JAMES-2124:
---------------------------------------
jeantil commented on pull request #263:
URL: https://github.com/apache/james-project/pull/263#issuecomment-729919156
I added 4 commits to address the comments and improve the PR a bit
- 073b33c drops the incorrect blank line in server/pom.xml
- bcd0a26 switches to using explicit groupIds for apache-mime4j dependencies
- 7a062c3 reverts incorrectly changed empty tags
- defb95b switches pom validation and sorting from compile to earlier
validate phase, meaning the build will fail even earlier and running `mvn
validate -PsortPom` lets developpers fix poms in a few seconds instead of a
several minutes compilation
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Sanitize all POM
> ----------------
>
> Key: JAMES-2124
> URL: https://issues.apache.org/jira/browse/JAMES-2124
> Project: James Server
> Issue Type: Improvement
> Components: Build System
> Affects Versions: master
> Reporter: Benoit Tellier
> Priority: Major
> Fix For: master
>
>
> We should order the POMs:
> https://github.com/Ekryd/sortpom
> Then we should move all dependency management to the root pom.xml
> Finally, we should uniformize versions.
> And also enforce usage of ${project.groupId} on all internal dependencies.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
