[
https://issues.apache.org/jira/browse/JAMES-3477?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255517#comment-17255517
]
ASF GitHub Bot commented on JAMES-3477:
---------------------------------------
chibenwa commented on pull request #282:
URL: https://github.com/apache/james-project/pull/282#issuecomment-751667026
`If you are certain that concurrent access may no longer occur on
MimeMessageInputStreamSource`
... How can I be sure of such a thing? :-)
` I suggest dropping the misleading synchronized.`
+1 this will make clear it is not thread safe... Just like we did in
MimeMessageWrapper.
`on a side note: List<InputStream> streams the ordering property of lists
doesn't seem to have any importance in the implementation, a Set would be more
appropriate.`
true
`I guess we will have to wait and see if shared access to MimeMessageWrapper
instances occurs or not.`
I pretty much agree with this statement...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> MimeMessageCopyOnWriteProxy is not thread safe
> ----------------------------------------------
>
> Key: JAMES-3477
> URL: https://issues.apache.org/jira/browse/JAMES-3477
> Project: James Server
> Issue Type: Wish
> Reporter: Benoit Tellier
> Priority: Major
>
> https://www.mail-archive.com/[email protected]/msg69221.html
> &
> https://github.com/jeantil/james-project/commit/c0354ea21c5b0a8f6d46e9919f7db0d97db9eb23
> proves there is a concurrency issue in MimeMessageCopyOnWriteProxy class that
> we need to investigate.
> It causes our test suite to be flacky.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
