[ https://issues.apache.org/jira/browse/JAMES-2543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256874#comment-17256874 ]
ASF GitHub Bot commented on JAMES-2543: --------------------------------------- jeantil commented on a change in pull request #283: URL: https://github.com/apache/james-project/pull/283#discussion_r550423455 ########## File path: mpt/impl/smtp/cassandra-rabbitmq-object-storage/src/test/resources/imapserver.xml ########## @@ -0,0 +1,54 @@ +<?xml version="1.0"?> Review comment: I tried ! If absent, the configuration mechanism will pick up the default configs in sever/protocols and try to bind on priviledged ports (such as 143), somehow despite having test-jar dependencies to the guice-cassandra and guice-cassandra-rabbit project it did not find the files there. I gave up after wasting a full day trying to trace it :( ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > remove usage of junit 4 > ----------------------- > > Key: JAMES-2543 > URL: https://issues.apache.org/jira/browse/JAMES-2543 > Project: James Server > Issue Type: Task > Components: tests > Affects Versions: 3.1.0 > Reporter: Matthieu Baechler > Priority: Major > > Now that Junit 5 is working well, we should migrate our test code to it to > benefits from great new features. > For that, as Junit 5 assertions changed from junit 4 ones, the easiest path > is to migrate all assertions to assertj (because they are better anyway). > A second step will be to migrate from @Rule to extensions. > Then there will probably the need to use cucumber for junit5 integration. > This ticket will track the progress on this task -- This message was sent by Atlassian Jira (v8.3.4#803005) --------------------------------------------------------------------- To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org For additional commands, e-mail: server-dev-h...@james.apache.org