[
https://issues.apache.org/jira/browse/JAMES-3225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17256895#comment-17256895
]
ASF GitHub Bot commented on JAMES-3225:
---------------------------------------
jeantil commented on a change in pull request #264:
URL: https://github.com/apache/james-project/pull/264#discussion_r550431463
##########
File path: Jenkinsfile
##########
@@ -87,36 +87,37 @@ pipeline {
sh 'mvn -U -B -e clean install -DskipTests -T1C'
}
}
-
- stage('Stable Tests') {
- steps {
- echo 'Running tests'
- // all tests run is very very long (10 hours on Apache Jenkins)
- sh 'mvn -B -e -fae test '
- }
- post {
- always {
- junit(testResults: '**/surefire-reports/*.xml',
allowEmptyResults: true)
- junit(testResults: '**/failsafe-reports/*.xml',
allowEmptyResults: true)
+ stage('Tests') {
+ parallel {
Review comment:
I'm not sure what you are referring to :
* [PR
264#1](https://ci-builds.apache.org/blue/organizations/jenkins/james%2FApacheJames/detail/PR-264/1/tests)
failures are on OOM and duplicate JMX bindings that I suspect are leftovers
bindings of the OOM failures
* [PR
268#51](https://ci-builds.apache.org/blue/organizations/jenkins/james%2FApacheJames/detail/PR-268/51/tests)
failures are all related to a DockerCassandraSingleton startup failure which I
can't explain at this stage : it occurred in both stable and unstable stages,
both of which spawn different JVM and are thus supposed to build their own copy
of the image on the first initialization of the singleton.
* [PR
268#47](https://ci-builds.apache.org/blue/organizations/jenkins/james%2FApacheJames/detail/PR-268/47/tests)
failed because of new tests added on master (MailboxChangeTest) I assume I was
unlucky to get my PR merged with a new commit which had bad tests, this was
fixed after a rebase (I assume the tests were fixed in between :) )
* [PR
268#46](https://ci-builds.apache.org/blue/organizations/jenkins/james%2FApacheJames/detail/PR-268/46/tests)
same as previous + a weird cassandra error (I should probably have tagged the
CassandraSubscriptionManagerTest as unstable)
* [PR
268#44](https://ci-builds.apache.org/blue/organizations/jenkins/james%2FApacheJames/detail/PR-268/44/tests)
fails on a flaky test
*[PR
268#43](https://ci-builds.apache.org/blue/organizations/jenkins/james%2FApacheJames/detail/PR-268/43/pipeline)
failed on a surefire timeout the logs are inconclusive :/
Also of note:
* using parallel for the unstable tests reduces the build from 3h40 to 2h57
* tests should not bind to fixed ports but maybe there are constraints I'm
not aware of ...
##########
File path: Jenkinsfile
##########
@@ -87,36 +87,37 @@ pipeline {
sh 'mvn -U -B -e clean install -DskipTests -T1C'
}
}
-
- stage('Stable Tests') {
- steps {
- echo 'Running tests'
- // all tests run is very very long (10 hours on Apache Jenkins)
- sh 'mvn -B -e -fae test '
- }
- post {
- always {
- junit(testResults: '**/surefire-reports/*.xml',
allowEmptyResults: true)
- junit(testResults: '**/failsafe-reports/*.xml',
allowEmptyResults: true)
+ stage('Tests') {
+ parallel {
Review comment:
I'm not sure what you are referring to :
* [PR
264#1](https://ci-builds.apache.org/blue/organizations/jenkins/james%2FApacheJames/detail/PR-264/1/tests)
failures are on OOM and duplicate JMX bindings that I suspect are leftovers
bindings of the OOM failures
* [PR
268#51](https://ci-builds.apache.org/blue/organizations/jenkins/james%2FApacheJames/detail/PR-268/51/tests)
failures are all related to a DockerCassandraSingleton startup failure which I
can't explain at this stage : it occurred in both stable and unstable stages,
both of which spawn different JVM and are thus supposed to build their own copy
of the image on the first initialization of the singleton.
* [PR
268#47](https://ci-builds.apache.org/blue/organizations/jenkins/james%2FApacheJames/detail/PR-268/47/tests)
failed because of new tests added on master (MailboxChangeTest) I assume I was
unlucky to get my PR merged with a new commit which had bad tests, this was
fixed after a rebase (I assume the tests were fixed in between :) )
* [PR
268#46](https://ci-builds.apache.org/blue/organizations/jenkins/james%2FApacheJames/detail/PR-268/46/tests)
same as previous + a weird cassandra error (I should probably have tagged the
CassandraSubscriptionManagerTest as unstable)
* [PR
268#44](https://ci-builds.apache.org/blue/organizations/jenkins/james%2FApacheJames/detail/PR-268/44/tests)
fails on a flaky test
* [PR
268#43](https://ci-builds.apache.org/blue/organizations/jenkins/james%2FApacheJames/detail/PR-268/43/pipeline)
failed on a surefire timeout the logs are inconclusive :/
Also of note:
* using parallel for the unstable tests reduces the build from 3h40 to 2h57
* tests should not bind to fixed ports but maybe there are constraints I'm
not aware of ...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Provide automated builds for Apache James - (restore builds.apache.org ?)
> --------------------------------------------------------------------------
>
> Key: JAMES-3225
> URL: https://issues.apache.org/jira/browse/JAMES-3225
> Project: James Server
> Issue Type: Task
> Reporter: Ioan Eugen Stan
> Assignee: Ioan Eugen Stan
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> For a long time we had builds that ran on the Apache Infrastructure
> https://builds.apache.org/view/All/job/james-mailet/ .
> The build infrastructure is not running for ~ 3 years now.
> I believe it is important for us to have automated builds.
> This ticket should gather the work needed to make this a reality.
> There are lots of things to take into consideration.
> My ( [~ieugen] ) opinions on how to handle this.
> * builds should run automatically
> * builds should run fast < 10 min
> * there are several things they should do (not exhaustive)
> ** verify the source code
> ** compile the source code
> ** run the unit tests
> ** run the integration tests
> ** publish SNAPSHOTS (only from master or develop ?!)
> ** run code analytics
> ** publish reports relating to build
> ** provide build status for other services
> For smaller projects this is a no-brainer.
> For the current state of Apache James this is a challange, especially in the
> context of
> - multiple git branches and PR's
> - the distributed integration tests which take a long time
> Given the limited resources available for us on the Apache infrastructure we
> will have to be selective of what we do.
> Personally I don't see how we can run the current (40mni +) integration suite
> on each push / build. I'm pretty sure we will get banned :) or throttled.
> So a discussion should be in order on how to solve these issues but some
> options regarding what we can do:
> - make integration tests OPT-IN
> - run (distributed) integration tests once a day or once every 6h / 12h
> - have build profiles that build a common subset all the time and run
> The nuclear option: prune some of the components we have in James and we
> don't want to support or move them out of the common project.
> This is something we should consider especially for buggy components or for
> components that don't have a maintainer.
> We have limited time and resources.
> We can't maintain everything for everybody.
> We should be mindful of this.
> We can take inspiration from the OFBiz project
> https://builds.apache.org/view/All/job/Apache%20OFBiz/ .
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
