[
https://issues.apache.org/jira/browse/JAMES-2382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17282896#comment-17282896
]
ASF GitHub Bot commented on JAMES-2382:
---------------------------------------
ShangwenWang commented on pull request #110:
URL: https://github.com/apache/james-project/pull/110#issuecomment-777250491
Hello every, I think here "findAnnotatedProperty" means similarly to
"getAnnotatedProperty". I believe they are semantically the same, both to try
to obtain something.
I'd like to know your opinions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Inconsistent method name
> ------------------------
>
> Key: JAMES-2382
> URL: https://issues.apache.org/jira/browse/JAMES-2382
> Project: James Server
> Issue Type: Improvement
> Reporter: KuiLIU
> Priority: Major
>
> The following method is named "hasAnnotatedProperty" that is a query of
> asking whether the propertyDescriptor has the AnnotatedProperty or not.
> Actually, the method returns an AnnotatedProperty found by the
> propertyDescriptor.
> Thus, the method name "findAnnotatedProperty" should be intuitive than
> "hasAnnotatedProperty".
> {code:java}
> private A hasAnnotatedProperty(PropertyDescriptor propertyDescriptor) {
> Method setter = propertyDescriptor.getWriteMethod();
> return setter != null ? AnnotationUtils.getAnnotation(setter,
> getAnnotation()) : null;
> }
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
