[ 
https://issues.apache.org/jira/browse/JAMES-3569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17330346#comment-17330346
 ] 

Benoit Tellier commented on JAMES-3569:
---------------------------------------

> I can't really tell why it is/was necessary ...

When we worked on this we wrote tests asserting the existing behavior without 
challenging it. Thus having explicit unit tests would IMO not be a proof of the 
usefulness of this behavior.

> The fix we made with  Matthieu Baechler (PR incoming) doesn't change this 
> behaviour (maybe matthieu has a better undertanding why it was necessary)

Cool! I'm fine keeping the existing behaviour (we have been living with it for 
quite some time already) however challenging the existing behavior is also 
worth it.

> (our fix also contains a bit of boyscouting and removes mockito usage in the 
> processor test along with adding an assertion that the attributes are not 
> lost )

Nice!


> RecipientRewriteTable sometimes drops attributes from emails
> ------------------------------------------------------------
>
>                 Key: JAMES-3569
>                 URL: https://issues.apache.org/jira/browse/JAMES-3569
>             Project: James Server
>          Issue Type: Bug
>          Components: SMTPServer
>    Affects Versions: 3.6.0
>            Reporter: Jean Helou
>            Priority: Major
>
> When a mail has a recipient with a mapping to a remote email address, 
> RecipientRewriteTable creates a new mail and copies over a few fields.
> Unfortunately it doesn't copy all the fields and in particular it drops the 
> mail attributes that have been computed by the pipeline up to this point.  
> For recipients which are rewritten to a local address there is no information 
> loss.  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to