This is an automated email from the ASF dual-hosted git repository. btellier pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/james-mime4j.git
commit bbabb72aa029d383190c9e625b302c5e60ddada1 Author: Benoit Tellier <[email protected]> AuthorDate: Mon May 24 17:47:50 2021 +0700 [REFACTORING] AbstractHeader was calling toLowerCase twice This generates needless object allocation and uselessly huggs CPU --- .../main/java/org/apache/james/mime4j/message/AbstractHeader.java | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/dom/src/main/java/org/apache/james/mime4j/message/AbstractHeader.java b/dom/src/main/java/org/apache/james/mime4j/message/AbstractHeader.java index 267b63a..6b121ed 100644 --- a/dom/src/main/java/org/apache/james/mime4j/message/AbstractHeader.java +++ b/dom/src/main/java/org/apache/james/mime4j/message/AbstractHeader.java @@ -67,10 +67,11 @@ public abstract class AbstractHeader implements Header { * @param field the field to add. */ public void addField(Field field) { - List<Field> values = fieldMap.get(field.getName().toLowerCase(Locale.US)); + String lowerCaseFieldName = field.getName().toLowerCase(Locale.US); + List<Field> values = fieldMap.get(lowerCaseFieldName); if (values == null) { values = new LinkedList<Field>(); - fieldMap.put(field.getName().toLowerCase(Locale.US), values); + fieldMap.put(lowerCaseFieldName, values); } values.add(field); fields.add(field); --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
