[james-mime4j] 05/07: [WARNING] Manual calls to Math.max

[btellier]

This is an automated email from the ASF dual-hosted git repository.

btellier pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-mime4j.git

commit 7cabf17f4b8bdd4944b2f4c3685effd53c233da7
Author: Benoit Tellier <btell...@linagora.com>
AuthorDate: Thu May 27 14:45:27 2021 +0700

    [WARNING] Manual calls to Math.max
    
    Using Math.max is more explicit and thus
    should be favored.
---
 .../org/apache/james/mime4j/io/EOLConvertingInputStreamTest.java    | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/core/src/test/java/org/apache/james/mime4j/io/EOLConvertingInputStreamTest.java
 
b/core/src/test/java/org/apache/james/mime4j/io/EOLConvertingInputStreamTest.java
index 116bae5..ce55b2d 100644
--- 
a/core/src/test/java/org/apache/james/mime4j/io/EOLConvertingInputStreamTest.java
+++ 
b/core/src/test/java/org/apache/james/mime4j/io/EOLConvertingInputStreamTest.java
@@ -69,7 +69,7 @@ public class EOLConvertingInputStreamTest {
                 new EOLConvertingInputStream(InputStreams.createAscii(s1),
                         EOLConvertingInputStream.CONVERT_BOTH);
         int n = in.read(bytes);
-        Assert.assertEquals(s2, ContentUtil.toAsciiString(bytes, 0, n > 0 ? n 
: 0));
+        Assert.assertEquals(s2, ContentUtil.toAsciiString(bytes, 0, 
Math.max(n, 0)));
 
         in.close();
     }
@@ -81,7 +81,7 @@ public class EOLConvertingInputStreamTest {
                 new EOLConvertingInputStream(InputStreams.createAscii(s1),
                         EOLConvertingInputStream.CONVERT_CR);
         int n = in.read(bytes);
-        Assert.assertEquals(s2, ContentUtil.toAsciiString(bytes, 0, n > 0 ? n 
: 0));
+        Assert.assertEquals(s2, ContentUtil.toAsciiString(bytes, 0, 
Math.max(n, 0)));
 
         in.close();
     }
@@ -93,7 +93,7 @@ public class EOLConvertingInputStreamTest {
                 new EOLConvertingInputStream(InputStreams.createAscii(s1),
                         EOLConvertingInputStream.CONVERT_LF);
         int n = in.read(bytes);
-        Assert.assertEquals(s2, ContentUtil.toAsciiString(bytes, 0, n > 0 ? n 
: 0));
+        Assert.assertEquals(s2, ContentUtil.toAsciiString(bytes, 0, 
Math.max(n, 0)));
 
         in.close();
     }

---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org