[
https://issues.apache.org/jira/browse/JAMES-3917?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benoit Tellier closed JAMES-3917.
---------------------------------
Fix Version/s: master
Resolution: Fixed
> Maven build should be strict about Scala imports ordering in the code
> ---------------------------------------------------------------------
>
> Key: JAMES-3917
> URL: https://issues.apache.org/jira/browse/JAMES-3917
> Project: James Server
> Issue Type: New Feature
> Reporter: Tung TRAN
> Priority: Minor
> Fix For: master
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> For now, we do not have strict rules with Scala regarding import orders. Not
> everybody has the same layout and it potentially reduces readability in PRs
> on code change if somebody got a different import layout than the initial
> code.
> We should be more strict on import ordering like we do with Java.
> Proposed layout:
> {code:java}
> base package imports
> ___blank line___
> java
> ___blank line___
> all other imports
> ___blank line___
> scala{code}
> Should modify the scalafix maven plugin to do a strict check on import and
> fail the build if that last one isn't respected.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscr...@james.apache.org
For additional commands, e-mail: server-dev-h...@james.apache.org
