I only see one problem with the one that is in CVS compared to the one that was offered. The CVS one does not take in account that linux reuses the process numbers, and therefore there can be some other process that use the same pid, the one offered tries to take this into account with the usage of grep phoenix.home (should it not be phoenix\.home really)

Especially if the main problem is after a unclean shutdown of the james server and then an reboot of the machine this would be the case.

I have some time ago downloaded a shell script some time ago that was designed to be used for the init.d (with start,stop,restart,status, etc)
This script has the same problem, and I was baffled before I discovered it why my servers would not start at a reboot. I ended up having to code in not just checking that the process was living,but that it was a java process that had some parameters that identified it as my server.


/Christian

Niclas Hedhman wrote:
On Thursday 04 March 2004 08:46, Noel J. Bergman wrote:

       if [ -f $PHOENIX_PID ]
       then
           phpid=`cat $PHOENIX_PID 2>/dev/null`
           piddata=`ps $phpid | grep phoenix.home 2>/dev/null`
           if [ "$piddata" != "" ]
           then
                   echo "Already Running!!"
                   exit 1
           fi
       fi

Not sure wether the phoenix team would be interested in doing somthing
similar so as to avoid this kind of problem!

I'll cc the Avalon folks so that they can consider it.



This is already present in Phoenix, at least what is in the CVS.


  start)
        echo "Starting Phoenix: "

        if [ -f $PHOENIX_PID ]
        then
           if ps -p `cat $PHOENIX_PID ` >/dev/null 2>/dev/null
           then
               echo "Already Running!!"
               exit 1
           fi
        fi


Cheers Niclas

--------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]



Reply via email to