this one.. http://svn.apache.org/viewvc?rev=1164977&view=rev
bye norman Am Sonntag, 4. September 2011 schrieb Saibabu Vallurupalli < [email protected]>: > Hi Eric, > > Can you point me to the fix? I wanted to integrate this fix to my 3.0-Beta2 > version and test. The reason is we are ready to move forward with 3.0-Beta2 > after all rounds of testing with our other products and updating it to > current might skip the dates. For now, I can take the fix and integrate to > 3.0-Beta2 (Locally) for our needs and upgrade to current later. > > Please point me to this source file in the trunk. > > Thanks, > Sai > > > On Sun, Sep 4, 2011 at 11:32 AM, Eric Charles <[email protected] >wrote: > >> There was always an additional character at the end of all mail bodies. >> I retested with trunk, and now everything is fine. >> >> Thx Norman. >> >> Eric >> >> On 04/09/11 06:03, Norman Maurer wrote: >> >>> What you mean ? >>> >>> Bye, >>> Norman >>> >>> >>> 2011/9/4 Eric Charles<eric.charles@u-**mangate.com< [email protected]> >>> >: >>> >>>> Did you also see the a ')' at the end of the body? >>>> Eric >>>> >>>> On 04/09/11 01:57, Norman Maurer wrote: >>>> >>>>> >>>>> Just fixed.. now the separator is included again.. >>>>> >>>>> Bye, >>>>> Norman >>>>> >>>>> >>>>> 2011/9/2 Eric Charles<eric.umg.charles@**gmail.com< [email protected]> >>>>> >: >>>>> >>>>>> >>>>>> Hi Sai, >>>>>> >>>>>> It seems that your fix made the encryption work. Thx again! >>>>>> >>>>>> However, mail bodies are not more displayed by mail clients, although >>>>>> the >>>>>> source of the mail contains the body. >>>>>> >>>>>> The mail format seems strange: no separation before the body, a ) >>>>>> ending >>>>>> the >>>>>> body. >>>>>> >>>>>> This is even the case if no encryption is used. >>>>>> >>>>>> I have to double-check all this, but I'm running out-of-time today, and >>>>>> tomorrow will also be a busy day. I hope to come back to it this >>>>>> weekend. >>>>>> >>>>>> Thx. >>>>>> >>>>>> >>>>>> On 01/09/11 08:39, Saibabu Vallurupalli wrote: >>>>>> >>>>>>> >>>>>>> What I have got it - mailbox-store 0.3 and mailbox-jpa from trunk do >>>>>>> you >>>>>>> think there is some inconsistency between these two modules? The >>>>>>> reason >>>>>>> behind is Norman integrated Encryption code to trunck so I have to >>>>>>> build >>>>>>> JPA >>>>>>> from Trunk and use it. Rest of the modules all are part of James 3.0 >>>>>>> beta >>>>>>> 2 >>>>>>> release. >>>>>>> >>>>>>> Thanks, Sai >>>>>>> >>>>>>> On Thu, Sep 1, 2011 at 11:19 AM, Eric >>>>>>> Charles<eric.umg.charles@**gmail.com <[email protected]> >>>>>>> >wrote: >>>>>>> >>>>>>> ouch, not sure if move is broken or not... >>>>>>>> Need more time to review this. >>>>>>>> Eric >>>>>>>> >>>>>>>> >>>>>>>> On 01/09/11 08:13, Eric Charles wrote: >>>>>>>> >>>>>>>> Running with encryption gives issue while moving mails (at least >>>>>>>>> getting >>>>>>>>> the content of a folder after mails has been moved to it). >>>>>>>>> >>>>>>>>> I tried the same with standard (no encryption) and it gives the same >>>>>>>>> issue. >>>>>>>>> >>>>>>>>> There are no excpetion in log. >>>>>>>>> >>>>>>>>> The good news is that it's unrelated to encryption. >>>>>>>>> The bad news is that mail move seems broken in trunk. >>>>>>>>> >>>>>>>>> Sai, Can you reproduce this also (without encryption)? >>>>>>>>> >>>>>>>>> Thx. >>>>>>>>> >>>>>>>>> On 01/09/11 07:45, Eric Charles wrote: >>>>>>>>> >>>>>>>>> Hi Sai, >>>>>>>>>> I took a little time to further look. >>>>>>>>>> No need to change code to return JPAEncryptedMessage. >>>>>>>>>> OpenJPAMailboxManager does it depending on the constructor called >>>>>>>>>> by >>>>>>>>>> spring (with a boolean or with a string). >>>>>>>>>> >>>>>>>>>> I have now changed >>>>>>>>>> https://svn.apache.org/repos/****asf/james/mailbox/trunk/**< https://svn.apache.org/repos/**asf/james/mailbox/trunk/**> >>>>>>>>>> spring/src/main/resources/****META-INF/org/apache/james/** >>>>>>>>>> >>>>>>>>>> >>>>>>>>>> spring-mailbox-jpa.xml<https:/**/svn.apache.org/repos/asf/** >>>>>>>>>> james/mailbox/trunk/spring/**src/main/resources/META-INF/** >>>>>>>>>> org/apache/james/spring-**mailbox-jpa.xml< https://svn.apache.org/repos/asf/james/mailbox/trunk/spring/src/main/resources/META-INF/org/apache/james/spring-mailbox-jpa.xml > >>>>>>>>>> > >>>>>>>>>> >>>>>>>>>> to test and I'll report back the result. >>>>>>>>>> >>>>>>>>>> Thx. >>>>>>>>>> >>>>>>>>>> On 01/09/11 03:50, Eric Charles wrote: >>>>>>>>>> >>>>>>>>>> Hi Sai, >>>>>>>>>>> >>>>>>>>>>> When you run the tests in the mailbox-jpa module, there are no >>>>>>>>>>> persistence.xml, but all the JPA properties are set via code. >>>>>>>>>>> >>>>>>>>>>> If you look at the 3 classes in >>>>>>>>>>> http://svn.apache.org/repos/****asf/james/mailbox/trunk/jpa/**< http://svn.apache.org/repos/**asf/james/mailbox/trunk/jpa/**> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> src/test/java/org/apache/****james/mailbox/jpa/<http://svn.** >>>>>>>>>>> apache.org/repos/asf/james/**mailbox/trunk/jpa/src/test/** >>>>>>>>>>> java/org/apache/james/mailbox/**jpa/< http://svn.apache.org/repos/asf/james/mailbox/trunk/jpa/src/test/java/org/apache/james/mailbox/jpa/ > >>>>>>>>>>> > >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> , you will see for example >>>>>>>>>>> >>>>>>>>>>> properties.put("openjpa.****MetaDataFactory", "jpa(Types=" + >>>>>>>>>>> JPAMailbox.class.getName() + ";" + >>>>>>>>>>> AbstractJPAMessage.class.****getName() + ";" + >>>>>>>>>>> JPAMessage.class.getName() + ";" + >>>>>>>>>>> JPAProperty.class.getName() + ";" + >>>>>>>>>>> JPAUserFlag.class.getName() + ";" + >>>>>>>>>>> JPASubscription.class.getName(****) + ")"); >>>>>>>>>>> >>>>>>>>>>> This is where you have to change to add the JPAEncryptedMessage. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> When you run the server as a whole, you need to build the app >>>>>>>>>>> module. >>>>>>>>>>> >>>>>>>>>>> In this case, the file to change is >>>>>>>>>>> http://svn.apache.org/repos/****asf/james/app/trunk/src/main/****< http://svn.apache.org/repos/**asf/james/app/trunk/src/main/**> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> config/james/META-INF/****persistence.xml<http://svn.** >>>>>>>>>>> apache.org/repos/asf/james/**app/trunk/src/main/config/** >>>>>>>>>>> james/META-INF/persistence.xml< http://svn.apache.org/repos/asf/james/app/trunk/src/main/config/james/META-INF/persistence.xml > >>>>>>>>>>> **> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> You will do 'mvn package', and the generated zip/tar.gz will >>>>>>>>>>> contain >>>>>>>>>>> that file. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> I hope you can make it, even if I am a bit late for you work >>>>>>>>>>> night. >>>>>>>>>>> >>>>>>>>>>> Thx. >>>>>>>>>>> >>>>>>>>>>> >>>>>>>>>>> On 31/08/11 18:53, Saibabu Vallurupalli wrote: >>>>>>>>>>> >>>>>>>>>>> Hi Eric, >>>>>>>>>>>> >>>>>>>>>>>> O.k.. I agree with you. But I need little bit more details >>>>>>>>>>>> regarding >>>>>>>>>>>> what >>>>>>>>>>>> should I do for the path. Since, I have the environment I can try >>>>>>>>>>>> this >>>>>>>>>>>> locally and also deploy in our Test environment and perform quick >>>>>>>>>>>> regression >>>>>>>>>>>> testing. >>>>>>>>>>>> >>>>>>>>>>>> Path: >>>>>>>>>>>> JPAMainboxManager.java is using JPAMessage object I need to >>>>>>>>>>>> modify >>>>>>>>>>>> the >>>>>>>>>>>> code >>>>>>>>>>>> to use JPAEncryptedMessage and return the same. >>>>>>>>>>>> >>>>>>>>>>>> I am trying this locally and the tests failed, Now my >>>>>>>>>>>> understanding >>>>>>>>>>>> is I >>>>>>>>>>>> also need to change persistence.xml file. Since, I am not 100% >>>>>>>>>>>> used >>>>>>>>>>>> to >>>>>>>>>>>> the >>>>>>>>>>>> development environment I need to know how Maven uses this file >>>>>>>>>>>> and >>>>>>>>>>>> from >>>>>>>>>>>> where this file will be picked? >>>>>>>>>>>> >>>>>>>>>>>> Can you please give me some insight about the path? I will be >>>>>>>>>>>> working >>>>>>>>>>>> tonight to get this patch out. If you could help me I really >>>>>>>>>>>> appreciate you. >>>>>>>>>>>> I am in USA EST timezone. >>>>>>>>>>>> >>>>>>>>>>>> Thanks, >>>>>>>>>>>> Sai >>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> On Wed, Aug 31, 2011 at 7:27 PM, Eric >>>>>>>>>>>> Charles<eric.charles@u-**manga**te.com <http://mangate.com>< >>>>>>>>>>>> eric.charles@u-mangate.**com <[email protected]>> >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> wrote: >>>>>>>>>>>>> >>>>>>>>>>>> >>>>>>>>>>>> Hi Sai, >>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> If you change JPAMessage to JPAEncryptedMessage in the >>>>>>>>>>>>> JPAMessageManager, >>>>>>>>>>>>> you must update persistence.xml accordingly. >>>>>>>>>>>>> >>>>>>>>>>>>> However, even if OpenJPAMailboxManager handles the encryption >>>>>>>>>>>>> feature to >>>>>>>>>>>>> initialize the EncryptionDecryptHelper if needed, the >>>>>>>>>>>>> JPAMailboxManager >>>>>>>>>>>>> should also verify the feature, and return a JPAEncryptedMessage >>>>>>>>>>>>> if >>>>>>>>>>>>> needed. >>>>>>>>>>>>> >>>>>>>>>>>>> I hope this makes sense, and if yes, a patch is needed. >>>>>>>>>>>>> >>>>>>>>>>>>> wdyt? >>>>>>>>>>>>> >>>>>>>>>>>>> >>>>>>>>>>>>> On 31/08/11 15:19, Saibabu Vallurupalli wrote: >>>>>>>>>>>>> >>>>>>>>>>>>> Hi Eric/Norman: >>>>>>>>>>>>> >>>>>>>>>>>>>> >>>>>>>>>>>>>> I am able to reproduce this error in a simple way. In my >>>>>>>>>>>>>> checked-out >>>>>>>>>>>>>> version >>>>>>>>>>>>>> - >>>>>>>>>>>>>> C:\work\workspace\james\******mailbox\trunk\jpa\src\main\** >>>>>>>>>>>>>> java\org\apache\james\mailbox\******jpa\JPAMessageManager.java >>>>>>>>>>>>>> There is reference to JPAMessage.java class and I changed it to >>>>>>>>>>>>>> JPAEncryptedMessage.java ran the maven clean package and the >>>>>>>>>>>>>> tests >>>>>>>>>>>>>> failed >>>>>>>>>>>>>> with the similar exception: >>>>>>>>>>>>>> >>>>>>>>>>>>>> Thought of letting you. Thank you very much in advance. >>>>>>>>>>>>>>>>>>>>>>>> >>>>>>>>>>>
