On Tue, 14 Jun 2022 12:27:06 GMT, Magnus Ihse Bursie <[email protected]> wrote:
>> make/autoconf/flags-ldflags.m4 line 132: >> >>> 130: >>> 131: if test "x$TOOLCHAIN_TYPE" = xmicrosoft; then >>> 132: REPRODUCIBLE_LDFLAGS="-experimental:deterministic" >> >> For the cflag, we check that the compiler supports it, but for the linker >> flag you are just setting it without a check. Before this patch, if we got >> here and ENABLE_REPRODUCIBLE_BUILD was true, it meant that the test had >> passed for the compiler, from which we could assume it would also work for >> the linker, but that is no longer the case. > > Good point. > I made some additional cleanup associated with shmem. I think that sysAssert > can (and probably should) > be replaced with SHMEM_ASSERT. I can fix that as well, if someone from > serviceability says that I should do it. Please do it. There is no reason to keep 2 identical defines. ------------- PR: https://git.openjdk.org/jdk/pull/9152
