Hi Martin and David,
On 14 Jun 2009, at 21:37, Martin Buchholz wrote:
I've polished the changes in preparation for committing.
I'll commit once I have reviewer approval.
I have the same concern as David. I think that throwing OOME, in
places where there is obviously a simple programming error, is not a
good idea. Will it be possible to change it to throw
IllegalArgumentException instead?
I have one more comment about the patch itself - changes to src/share/
vm/gc_interface/collectedHeap.inline.hpp and src/share/vm/utilities/
exceptions.hpp are unrelated to the bugfix. I think it will be better
to separate them to the different changeset.
Bye,
--
Tomas Hurka <mailto:[email protected]>
NetBeans Profiler http://profiler.netbeans.org
VisualVM http://visualvm.dev.java.net
Software Engineer, Developer Platforms Group
Sun Microsystems, Praha Czech Republic
