Kelly O'Hair wrote:

:

Dan had pointed out my typo in the jdk/test/Makefile ($->$$)
but when I started running and re-running the tests I ran into
more unstable tests. This webrev includes fixes to 3 tests
and unfortuntately more additions to the ProblemList file.
It would be good to create a bug (or ensure there is an existing bug) for any tests that you add to the list.

:
  java/io/File/SetLastModified.java
I tried to duplicate this without success. Is the test directory on a SAMBA drive when it fails?

  java/nio/channels/DatagramChannel/SRTest.java
  java/nio/channels/DatagramChannel/Sender.java
  java/nio/channels/Selector/SelectWrite.java
  java/nio/channels/DatagramChannel/EmptyBuffer.java
The older NIO test uses a fixed port which is problematic when tests run in parallel. One of these days/weeks I will fix all these issues (they manifest in various forms including hangs during initialization, or address already in use errors).

  java/nio/channels/DatagramChannel/MulticastSendReceiveTests.java
This is an important test and I'd like to track down the reason it failed for you rather than excluding it.

  java/util/Collection/MOAT.java
Over Martin's dead body :-)

  java/nio/channels/AsynchronousSocketChannel/Basic.java
Excluding this test will eliminate almost all test coverage of AsynchronousSocketChannel so I don't think we should exclude it. I see that the issue is a connection to a non-existent host is failing immediately whereas the test expects it to timeout. I'll fix the test to handle this case in b79.

  java/nio/channels/AsynchronousChannelGroup/Unbounded.java
As Windows 2000 Pro was EOL'ed eons ago we didn't put any effort into the asynchronous I/O implementation to support that edition (it needs Windows XP or newer). Can you just exclude this with windows-5.0 rather than generic-all so that it continues to run on other platforms?

  java/nio/channels/FileChannel/Transfer.java
This test does take a long time on Windows. I'd be interested to see the log as the right solution might be to increase the timeout or else just exclude it on windows-5.0 (not generic-all as the test provides important coverage).

-Alan.

Reply via email to